Remove XUL grid implementation
Categories
(Core :: XUL, task, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
rm -rf layout/xul/grid
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D53296
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
FYI, this is also needed, otherwise the linter complains the path does not exist.
Comment 6•4 years ago
|
||
... and a few more things that can be removed.
Assignee | ||
Comment 7•4 years ago
|
||
Comment on attachment 9185052 [details] [diff] [review] additonal fix 2 Review of attachment 9185052 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching the unused bits! ::: layout/style/test/test_non_content_accessible_values.html @@ -12,5 @@ > ], > "display": [ > - "-moz-grid", > - "-moz-grid-group", > - "-moz-grid-line", I kept those originally because you don't want to expose these values to content even if the code is removed. That's probably an unlikely future issue though, so up to you whether you want to remove them.
Comment 8•4 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #7)
I kept those originally because you don't want to expose these values to
content even if the code is removed.
There's not much value in testing display
keywords that no longer exist in the style system, so I think we should remove them from this test. I don' think there's any risk that we'd add them back by accident.
Comment 9•4 years ago
|
||
We should probably let bug 1583696 bake for a while before landing this though, just in case some regression is found.
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
Hi Richard & Magnus,
Just a heads up that there are XUL grid usages in the mail/extensions/openpgp directory.
There are also quite a few in the editor/ & suite/ directories, but I was told before this isn't maintained/used for TB?
If nothing goes wrong, this bug should land in Firefox 85. Thanks to everyone involved in helping make this a reality!
Assignee | ||
Comment 11•4 years ago
|
||
Comment 12•4 years ago
|
||
Thanks, I filed bug 1677427 about the final bits in Thunderbird. Yes, editor/ and suite/ are practically dead, and not used by Thunderbird.
Comment 13•4 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0bacd1b4ff62 Remove/replace usages of XUL grid display values. r=emilio https://hg.mozilla.org/integration/autoland/rev/044d198df333 Remove support for XUL grid display values. r=emilio https://hg.mozilla.org/integration/autoland/rev/517f352dbde7 Remove layout/xul/grid directory. r=emilio
Comment 14•4 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0bacd1b4ff6264741ade6ef8caa45fe7085683c5
https://hg.mozilla.org/mozilla-central/rev/044d198df33340ee7d81b06231896c1db972929e
https://hg.mozilla.org/mozilla-central/rev/517f352dbde71f4afff47e5bcaf38e063c4b3ca3
Description
•