User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

1. Go to https://www.google.com/
2. Fire up Developer Tools > Network panel
3. Click on any request
4. Go to the Response tab
5. Click on any row inside the Response tab
6. Press key up/down

Actual results:

Subsequent key up/down events do not work anymore.

Expected results:

Subsequent key up/down events should work and users can navigate to other rows just using key events.

Thanks for the report!

I can reproduce this on my machine Fx67, Win10

Honza

Allow keyboard events when CodeMirror is focused

Hi :Honza

The patch is ready for review :)

More context for this bug/patch:

Reason why there is a need to focus on the TreeView component (https://searchfox.org/mozilla-central/source/devtools/client/shared/components/tree/TreeView.js#316) is related to Bug 1428436 and Bug 1520107.

The code that handles key events (https://searchfox.org/mozilla-central/source/devtools/client/shared/components/tree/TreeView.js#264) is only targeting "rows" like Preview and Response payload in the Response panel. Therefore, the key events are not sent to the CodeMirror editor at all.

This patch checks if the CodeMirror editor is currently focused. If the editor is currently focused, the TreeView component should not be focused after subsequent key events.

Commented in Phabricator.
Honza

Hi :Honza

Please assign me this issue so I'll remember to follow up :)

Hi Honza

It seems like step 5 of the STR doesn't place the cursor in the code editor anymore, thus this issue is not reproducible anymore.

Do you know which patch helped address this issue (albeit unknowingly)?

I don't see the cursor either, but it looks to me like a bug. It should be there, so the user can navigate within CM by keyboard.
Not sure what patch could cause this regression.

Honza

Hi Heng Yeow. I'm just checking if you are still interested in working on this bug. There hasn't been any activity here or on the patch in phabricator for some time. If you just need more time, that's fine. If you, however, are not planning on working on this bug anymore, let us know so it can be made available for others to pick up.