Closed Bug 1547699 Opened 6 years ago Closed 5 years ago

improvements/simplifications for MozAttachmentlist

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: mkmelin, Assigned: arshad)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1523607 +++

This is the followup to bug 1523607 comment 53

ALso fix Bug 1554943 and Bug 1552965.

target.matches error is not fixed yet.

Comment on attachment 9068884 [details] [diff] [review] attachmentListImprovements.patch Review of attachment 9068884 [details] [diff] [review]: ----------------------------------------------------------------- Seems to work, and try is happy - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c2e4cbe9650b6e90e5a73b303c9694994a802293 It would have been preferable to do each issue in their own dedicated bug. But...
Attachment #9068884 - Flags: review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment on attachment 9068884 [details] [diff] [review] attachmentListImprovements.patch And this needs beta uplift so the various problems get fixed there as well.
Attachment #9068884 - Flags: approval-comm-beta+

(In reply to Arshad Khan [:arshad] from comment #3)

Fixes Bug 1554943, Bug 1552965 and https://bugzilla.mozilla.org/show_bug.cgi?id=1547699#c1

Yes, I verified that the two bugs are fixed. The issue from bug 1523607 comment #64 is not fixed, I still get:

JavaScript error: chrome://messenger/content/messengercompose/MsgComposeCommands.js, line 5825: TypeError: target.matches is not a function

and an attachment still can't be dragged to after the last item to it becomes the last item.

Yes, but better to do that in a separate bug.

Blocks: 1556192

This bug needs a rebase if Bug 1556122 is pushed first.

Sure, already lined up for landing.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5d14d6540a92
Improvements/Simplifications for MozAttachmentlist. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
Blocks: 1613004
Regressions: 1613284
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: