Closed
Bug 1581754
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mail/components/compose/content/dialogs/EdInsertTOC.xul
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Comment on attachment 9093230 [details] [diff] [review] Bug-1581754_remove-grid-EdInsertTOC.patch Review of attachment 9093230 [details] [diff] [review]: ----------------------------------------------------------------- Actually, this seems like it should be an html:table ::: mail/components/compose/content/dialogs/EdInsertTOC.xul @@ +29,5 @@ > + <hbox class="groupbox-title"> > + <label class="header">&buildToc.label;</label> > + </hbox> > + <html:div class="grid-three-column"> > + <html:div></html:div> use something like "grid-column: 2 / 3"; instead. @@ +31,5 @@ > + </hbox> > + <html:div class="grid-three-column"> > + <html:div></html:div> > + <html:div class="flex-items-center"> > + <label value="&tag.label;"/> just &tag.label;, no need for the label
Attachment #9093230 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 3•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #2)
Actually, this seems like it should be an html:table
I try to use grid-layout first. If it does not work because of odd margins and paddings, I switch to html:table. Here, grid-layout worked so I went with it.
Assignee | ||
Comment 4•5 years ago
|
||
Attachment #9093230 -
Attachment is obsolete: true
Attachment #9093256 -
Flags: review?(mkmelin+mozilla)
Comment 5•5 years ago
|
||
But the data is semantically tabular data. If you flip the axis, it still works. A grid layout that would try to adapt for responsivness would easily make the data non-readable. (You can't have it any other way than 3 elements on the one row, try changing to a grid of 2 or 4, and nobody understands a thing there.)
Assignee | ||
Comment 6•5 years ago
|
||
Apply after patch from Bug 1581558.
Attachment #9093256 -
Attachment is obsolete: true
Attachment #9093256 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•5 years ago
|
Attachment #9093373 -
Flags: review?(mkmelin+mozilla)
Comment 7•5 years ago
|
||
Comment on attachment 9093373 [details] [diff] [review] Bug-1581754_remove-grid-EdInsertTOC.patch Review of attachment 9093373 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/compose/content/dialogs/EdInsertTOC.xul @@ +35,5 @@ > + &tag.label; > + </html:th> > + <html:th> > + &class.label; > + </html:th> for cases like this were it would fit very nicely on one line, maybe change it to <html:th>&class.label;</html:th>
Attachment #9093373 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 8•5 years ago
|
||
Attachment #9093373 -
Attachment is obsolete: true
Attachment #9093895 -
Flags: review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/59ea04a195f6
remove grid usage from EdInsertTOC.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•