[Mac] Open Help shortcut lacks modifier
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: stefanh, Assigned: iannbugzilla)
References
(Regression)
Details
(Whiteboard: SM2.53.3)
Attachments
(1 file)
|
(deleted),
patch
|
stefanh
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Bug 1611714 removed our platform-specific overlays. In the Mac version we had:
<key id="key_openHelp"
key="&openHelpCmd.key;"
modifiers="&openHelpCmd.modifiers;"
command="cmd_openHelp"/>
It looks like the modifiers part got lost. The shortcut for open Help is now "?" instead of "Cmd+?" which is weird :-).
[Approval Request Comment]
Regression caused by (bug #): 1611714
User impact if declined: Missing modifier
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None
Modifier was in the l10n just missed off the xul
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 2•4 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0d37700f47f4
[Mac] Open Help shortcut lacks modifier. r=stefanh
|
|
||
Comment 4•4 years ago
|
||
Target 2.53.3
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f1489afbc559ab59dfe4592838870268aa7cd289
Description
•