Add distribution search engine defaults and orders to modern search configuration
Categories
(Firefox :: Search, task, P2)
Tracking
()
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(5 files)
Following on from bug 1615060, we want to move the information about default engines and sort orders into mozilla-central as well. This helps to simplify the search service code as well (see follow-up bug).
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D72817
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D72948
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D72949
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D72950
Assignee | ||
Comment 5•5 years ago
|
||
Adrian, the distribution changes I mentioned earlier are now on production preview. You'll need to use the next nightly build for verification as it has a separate engine for Qwant Junior (which is needed here).
Comment 6•5 years ago
|
||
Thanks, we'll start on this today, but please be advised that we're probably gonna finish this early next week Mon-Tue due to the fact that 1st may is also RO national day, so our team is off tomorrow.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #5)
Adrian, the distribution changes I mentioned earlier are now on production preview.
Tests completed on main-preview with a few failures. Results are here - column A (uncertain if we should've used the original one)
Assignee | ||
Comment 8•5 years ago
|
||
Hi Adrian, I've now updated main-preview with the latest changes from the dependant bugs. It is probably worth waiting for tomorrow morning's nightlies to make sure the extra Yandex file is in the build.
I think just retesting the failed distributions is enough.
Comment 9•5 years ago
|
||
Shouldn't we wait for bug 1635056 and bug 1634562 to land aswell before re-checking?
With the note that IMO, we can check the already fixed stuff w/o the above fixes, since I don't think they are dependent.
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
(In reply to Adrian Florinescu [:aflorinescu] from comment #9)
Shouldn't we wait for bug 1635056 and bug 1634562 to land aswell before re-checking?
With the note that IMO, we can check the already fixed stuff w/o the above fixes, since I don't think they are dependent.
The fixes for those are configuration updates only (though they do include unit test additions). I've already uploaded those additional configuration changes to main-preview.
Comment 11•5 years ago
|
||
Distributions with fixed issues have been retested. Looks good with the following issues still remaining:
- bug 1636037 - search code, not distribution related
- https://bugzilla.mozilla.org/show_bug.cgi?id=1634562#c7 distribution id mailru from mailru distribution still has issues.
Assignee | ||
Comment 12•5 years ago
|
||
(In reply to Adrian Florinescu [:aflorinescu] from comment #11)
Distributions with fixed issues have been retested. Looks good with the following issues still remaining:
- bug 1636037 - search code, not distribution related
- https://bugzilla.mozilla.org/show_bug.cgi?id=1634562#c7 distribution id mailru from mailru distribution still has issues.
Thank you. They are both now fixed, so I think we are good to go? Please could you confirm.
Comment 13•5 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #12)
Thank you. They are both now fixed, so I think we are good to go? Please could you confirm.
Yes, I would assume the config fixes are contained and do not require regression testing outside the fix verification, so if we are still aligned on this matter, I'd say we are green to go with the prod approval.
Updated•5 years ago
|
Assignee | ||
Comment 14•5 years ago
|
||
Thanks, I will ask Mike Connor to approve.
Assignee | ||
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
uplift |
Disable part of test_distributions.js as it will fail on search configuration update which is disabled on 77 anyway. r=daleharvey a=test-only
https://hg.mozilla.org/releases/mozilla-beta/rev/0561052e38b299b6d7b18141d65ed6a32f152a8d
Comment 17•5 years ago
|
||
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb00deacf1a1
https://hg.mozilla.org/mozilla-central/rev/51f67ab9be2c
https://hg.mozilla.org/mozilla-central/rev/156d0a13ecf2
https://hg.mozilla.org/mozilla-central/rev/136fc0c8c958
Updated•5 years ago
|
Description
•