Closed Bug 1630980 Opened 5 years ago Closed 5 years ago

Add distribution search engine defaults and orders to modern search configuration

Categories

(Firefox :: Search, task, P2)

task
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 78
Iteration:
78.1 - May 4 - May 17
Tracking Status
firefox77 --- wontfix
firefox78 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(5 files)

Following on from bug 1615060, we want to move the information about default engines and sort orders into mozilla-central as well. This helps to simplify the search service code as well (see follow-up bug).

Depends on: 1630981
Depends on: 1633705

Adrian, the distribution changes I mentioned earlier are now on production preview. You'll need to use the next nightly build for verification as it has a separate engine for Qwant Junior (which is needed here).

Flags: needinfo?(aflorinescu)

Thanks, we'll start on this today, but please be advised that we're probably gonna finish this early next week Mon-Tue due to the fact that 1st may is also RO national day, so our team is off tomorrow.

Depends on: 1634562
Iteration: 77.2 - Apr 20 - May 3 → 78.1 - May 4 - May 17
Severity: -- → N/A

(In reply to Mark Banner (:standard8) from comment #5)

Adrian, the distribution changes I mentioned earlier are now on production preview.

Tests completed on main-preview with a few failures. Results are here - column A (uncertain if we should've used the original one)

Flags: needinfo?(aflorinescu)

Hi Adrian, I've now updated main-preview with the latest changes from the dependant bugs. It is probably worth waiting for tomorrow morning's nightlies to make sure the extra Yandex file is in the build.

I think just retesting the failed distributions is enough.

Flags: needinfo?(aflorinescu)

Shouldn't we wait for bug 1635056 and bug 1634562 to land aswell before re-checking?
With the note that IMO, we can check the already fixed stuff w/o the above fixes, since I don't think they are dependent.

Flags: needinfo?(aflorinescu)
Flags: needinfo?(standard8)

(In reply to Adrian Florinescu [:aflorinescu] from comment #9)

Shouldn't we wait for bug 1635056 and bug 1634562 to land aswell before re-checking?
With the note that IMO, we can check the already fixed stuff w/o the above fixes, since I don't think they are dependent.

The fixes for those are configuration updates only (though they do include unit test additions). I've already uploaded those additional configuration changes to main-preview.

Flags: needinfo?(standard8) → needinfo?(aflorinescu)

Distributions with fixed issues have been retested. Looks good with the following issues still remaining:
- bug 1636037 - search code, not distribution related
- https://bugzilla.mozilla.org/show_bug.cgi?id=1634562#c7 distribution id mailru from mailru distribution still has issues.

Flags: needinfo?(aflorinescu) → needinfo?(standard8)

(In reply to Adrian Florinescu [:aflorinescu] from comment #11)

Distributions with fixed issues have been retested. Looks good with the following issues still remaining:
- bug 1636037 - search code, not distribution related
- https://bugzilla.mozilla.org/show_bug.cgi?id=1634562#c7 distribution id mailru from mailru distribution still has issues.

Thank you. They are both now fixed, so I think we are good to go? Please could you confirm.

Flags: needinfo?(standard8) → needinfo?(aflorinescu)

(In reply to Mark Banner (:standard8) from comment #12)

Thank you. They are both now fixed, so I think we are good to go? Please could you confirm.

Yes, I would assume the config fixes are contained and do not require regression testing outside the fix verification, so if we are still aligned on this matter, I'd say we are green to go with the prod approval.

Flags: needinfo?(aflorinescu)
Flags: needinfo?(standard8)

Thanks, I will ask Mike Connor to approve.

Flags: needinfo?(standard8)

Disable part of test_distributions.js as it will fail on search configuration update which is disabled on 77 anyway. r=daleharvey a=test-only
https://hg.mozilla.org/releases/mozilla-beta/rev/0561052e38b299b6d7b18141d65ed6a32f152a8d

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb00deacf1a1 Add default engine information for distribution engines to the modern search configuration. r=daleharvey,mkaply https://hg.mozilla.org/integration/autoland/rev/51f67ab9be2c Remove orders for current engines, let them be alphabetical. r=daleharvey,mkaply https://hg.mozilla.org/integration/autoland/rev/156d0a13ecf2 Add orders for distribution engines. r=daleharvey,mkaply https://hg.mozilla.org/integration/autoland/rev/136fc0c8c958 Add more tests for search engine distributions in different locales and fix yandex.ua inclusion. r=daleharvey,mkaply
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: