Closed Bug 1653319 Opened 4 years ago Closed 4 years ago

Use the new frameLoader.printPreview() API in the frontend

Categories

(Toolkit :: Printing, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: mstriemer, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

Bug 1649202 will integrate a print preview in the tab modal print UI but printUtils.js is currently only set up to handle one print preview at a time.

We can likely get a preview in that bug by closing any existing print modals when a new one is opened but getting multiple open at once will take some refactoring or a rewrite of the printUtils.js functionality.

Blocks: 133787
No longer depends on: 133787
Whiteboard: [print2020_v80] → [print2020_v81]

This depends on the updated preview API which will take print settings as an argument rather than pulling the current saved settings.

Depends on: 1653340

If we can't use the new frameLoader API we could potentially serialize the settings we have to JSON and pass them through https://gist.github.com/mstriemer/7ab51d4c2cba4d7ad22add6f6a76899c

The frameLoader API is on its way, we should be able to use that soon.

Summary: Support multiple print UIs at once → Use the new frameLoader.updatePrintPreview API in the frontend
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Summary: Use the new frameLoader.updatePrintPreview API in the frontend → Use the new frameLoader.rintPreview() API in the frontend
Summary: Use the new frameLoader.rintPreview() API in the frontend → Use the new frameLoader.printPreview() API in the frontend
Blocks: 1661662
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/2d279a8a5787 Use the new FrameLoader.printPreview API in the frontend. r=mstriemer,emalysz,emilio
Regressions: 1662844
No longer regressions: 1662844
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9172832 [details]
Bug 1653319. Use the new FrameLoader.printPreview API in the frontend. r=mstriemer,emalysz,sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: Print settings not applied correctly to preview or paper output.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Medium
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9172832 - Flags: approval-mozilla-beta?
Blocks: 1661975

Comment on attachment 9172832 [details]
Bug 1653319. Use the new FrameLoader.printPreview API in the frontend. r=mstriemer,emalysz,sfoster

Approved for 81.0b6.

Attachment #9172832 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1663503
No longer regressions: 1663503
Regressions: 1663669
Regressions: 1664129
No longer regressions: 1664129
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: