Fix "Print Selection Only" in the system print dialog when opened from the new print UI
Categories
(Toolkit :: Printing, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox-esr78 | --- | unaffected |
| firefox80 | --- | unaffected |
| firefox81 | --- | verified |
| firefox82 | --- | verified |
People
(Reporter: 6dnail, Assigned: bobowen)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [print2020_v81][old-ui-])
Attachments
(2 files)
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0
Steps to reproduce:
Selected a portion of a webpage
used File->print
Actual results:
I can print the whole thing or a specific page however, I cannot print the selected portion of a webpage.
This works on Firefox 80 however, it fails on Firefox 82 (Currently my Firefox nightly is at build 20200830093945). System is Ubuntu 16.04. It is also failing on Ubuntu 18.04
Expected results:
Somewhere in the print dialog, if necessary, within the 'print using the system dialog', it should be possible to print just a selection. Reference Firefox 80, which behaves correctly.
|
||
Comment 1•4 years ago
|
||
Page range "Selection" radio button is no longer enabled in System dialog on Windows10.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3b208361444be5b6e5df2b2d2d80c05c901f534e&tochange=ec5d71be904568a05c1bfb81a4c1a28178d61d6b
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 2•4 years ago
|
||
oops sorry, wrong tracking flag
|
|
||
Updated•4 years ago
|
|
|
||
Comment 3•4 years ago
|
||
Thanks for reporting this, Lee! And thanks for the regression range, Alice!
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 4•4 years ago
|
||
This is then used in the front end to set the option in the settings.
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/3dceff8392d1 Add whether we have a selection to PrintPreviewResultInfo. r=jwatt
|
||
Comment 6•4 years ago
|
||
Hi Mike, This bug doesn't have a severity set, could you please help?
|
|
Assignee | |
Comment 8•4 years ago
|
||
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/22eeb213f761 part 2: Follow-up to fix nsPrintJob::FirePrintingErrorEvent. r=jwatt
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3dceff8392d1
https://hg.mozilla.org/mozilla-central/rev/22eeb213f761
|
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9173471 [details]
Bug 1661975: Add whether we have a selection to PrintPreviewResultInfo. r=jwatt!
Beta/Release Uplift Approval Request
- User impact if declined: "Print selection only" will not be available from from the system print dialog when opened from the new print UI.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Very contained.
- String changes made/needed:
|
|
||
Updated•4 years ago
|
|
||
Comment 12•4 years ago
|
||
Comment on attachment 9173471 [details]
Bug 1661975: Add whether we have a selection to PrintPreviewResultInfo. r=jwatt!
Approved for 81.0b6.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 13•4 years ago
|
||
| bugherder uplift | ||
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 14•4 years ago
|
||
Confirming this issue as verified fixed on macOS 10.15, Ubuntu 18.04 and Windows 10x64. Verified using 82.0a1 (2020-09-09) and 81.0b8.
|
Reporter | |
Comment 15•4 years ago
|
||
This cannot be verified on Ubuntu 16.04 because 1) bug 1662946 is not fixed - until that bug is fixed, it's not possible to see the print dialog and 2) as of last night's build 20200910093613, firefox crashes if print is selected (new bug coming shortly)
Description
•