Closed Bug 1587459 Opened 5 years ago Closed 4 years ago

Open the print dialog from the frontend instead of the core printing code

Categories

(Toolkit :: Printing, task, P2)

task

Tracking

()

RESOLVED FIXED
82 Branch
Fission Milestone M6c
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

This is similar to bug 1558907, but for the print dialog as opposed to the print progress dialog.

The print dialog should be opened directly by (and determined by) the app frontend code, not by the core printing code.

This is part of moving the print code off the MessageManager and towards making it work with Fission enabled.

Depends on: 1594391
Blocks: 1557645
Status: NEW → ASSIGNED
Fission Milestone: --- → M5
Type: defect → task
Depends on: 1486968, 1602125, 1602410
Blocks: 133787

Deferring to Fission Nightly (M6) because printing bugs don't need to block M5 dogfooding.

Fission Milestone: M5 → M6
Depends on: 1636803
Blocks: 1140929
No longer blocks: 1557645
No longer blocks: 133787
Whiteboard: [print2020]

Tracking for Fission Nightly (M6c)

Fission Milestone: M6 → M6c
Whiteboard: [print2020] → [print2020_v80]
Whiteboard: [print2020_v80] → [print2020_v81]
Depends on: 1653961
Depends on: 1652337
No longer depends on: 1602410

The patch only fixes this bug for the new printing UI. I'm hoping to avoid fixing the old code by virtue of that code being removed soon, but we can open a new bug for that if necessary.

Depends on: 1660794
Depends on: 1660918
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/ec5d71be9045
Open the print dialog from the frontend code instead of the platform code. r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9171210 [details]
Bug 1587459. Open the print dialog from the frontend code instead of the platform code. r=sfoster

Beta/Release Uplift Approval Request

  • User impact if declined: Blocker for printing project.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Makes the frontend open the printing dialog instead of relying on the platform code doing it.
  • String changes made/needed:
Attachment #9171210 - Flags: approval-mozilla-beta?

Comment on attachment 9171210 [details]
Bug 1587459. Open the print dialog from the frontend code instead of the platform code. r=sfoster

Approved for 81.0b2.

Attachment #9171210 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1661975
Blocks: 1660794
No longer depends on: 1660794
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: