Open the print dialog from the frontend instead of the core printing code
Categories
(Toolkit :: Printing, task, P2)
Tracking
()
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Whiteboard: [print2020_v81])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
This is similar to bug 1558907, but for the print dialog as opposed to the print progress dialog.
The print dialog should be opened directly by (and determined by) the app frontend code, not by the core printing code.
This is part of moving the print code off the MessageManager and towards making it work with Fission enabled.
Updated•5 years ago
|
Updated•5 years ago
|
![]() |
Assignee | |
Updated•5 years ago
|
Comment 1•4 years ago
|
||
Deferring to Fission Nightly (M6) because printing bugs don't need to block M5 dogfooding.
![]() |
Assignee | |
Updated•4 years ago
|
![]() |
Assignee | |
Updated•4 years ago
|
Updated•4 years ago
|
![]() |
Assignee | |
Comment 3•4 years ago
|
||
![]() |
Assignee | |
Comment 4•4 years ago
|
||
The patch only fixes this bug for the new printing UI. I'm hoping to avoid fixing the old code by virtue of that code being removed soon, but we can open a new bug for that if necessary.
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/ec5d71be9045 Open the print dialog from the frontend code instead of the platform code. r=sfoster
Comment 6•4 years ago
|
||
bugherder |
![]() |
Assignee | |
Comment 7•4 years ago
|
||
Comment on attachment 9171210 [details]
Bug 1587459. Open the print dialog from the frontend code instead of the platform code. r=sfoster
Beta/Release Uplift Approval Request
- User impact if declined: Blocker for printing project.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Makes the frontend open the printing dialog instead of relying on the platform code doing it.
- String changes made/needed:
Comment 8•4 years ago
|
||
Comment on attachment 9171210 [details]
Bug 1587459. Open the print dialog from the frontend code instead of the platform code. r=sfoster
Approved for 81.0b2.
Comment 9•4 years ago
|
||
uplift |
![]() |
Assignee | |
Updated•4 years ago
|
Description
•