Closed
Bug 1671906
Opened 4 years ago
Closed 4 years ago
Share notifyResourceAvailable, notifyResourceUpdates and notifyResourceDeleted between watcher and target actors
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox84 fixed)
RESOLVED
FIXED
84 Branch
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
These methods have the same implementation (or should have) and should be written once.
The issue is that Actors aren't use ES Classes (only Fronts do), and so it is harder to share code via inheritance.
We could probably also share: addWatcherDataEntry
, removeWatcherDataEntry
, watchTargetResources
and unwatchTargetResources
between all target actors.
Assignee | ||
Comment 1•4 years ago
|
||
Similarly to the frontend, I'm introducing a mixin in order to share code between at target actors.
We might be able to share more, like sources. But at least we share new addition related to watcher and resources.
This would probably have been easier if Actor were using ES Classes.
Updated•4 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5834209a1e4f [devtools] Introduce a target actor mixin in order to share common code between all targets. r=jdescottes
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•