Closed Bug 1678258 Opened 4 years ago Closed 4 years ago

overlay buttons triggered for breakpoint not reacting to clicks (continue, step)

Categories

(DevTools :: Debugger, defect, P1)

defect

Tracking

(firefox-esr78 unaffected, firefox83 unaffected, firefox84+ verified, firefox85+ verified)

VERIFIED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 + verified
firefox85 + verified

People

(Reporter: aryx, Assigned: nchevobbe)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Firefox 85.0a1 and 84.0b2 on Windows 8.1

From bug 1671906 (or bug 1673328):

The overlay buttons triggered for a debugger breakpoint are not reacting to clicks (continue, step) but the buttons in the right sidebar work as expected.

Steps to reproduce:

  1. Open https://bugherder.mozilla.org/ (other pages will also work, you just have to know where to set a breakpoints and how to trigger it).
  2. Open the debugger (either from the menu or with Ctrl+Shift+Z).
  3. In the left sidebar, expand the folder and select the following file: bugherder.mozilla.org/thirdparty/bzjs/bz-0.4.3.js
  4. Go to line 262: var that = this;
  5. Click on the line number to set a breakpoint.
  6. Put the following into the input field in the page: 36ef6c97da5bbabfa3d65ad493d1872bfb77b355
  7. Click the 'Submit' button.

The breakpoint gets triggered.

  1. Click on either the arrow (step over, supposed to go to next line in debugger) or play button (continue script execution).

Actual result: Nothing happens.

  1. Click one of these buttons in the right sidebar

Actual and expected result: Expected action executed.

Component: CSS and Themes → Debugger
Flags: needinfo?(poirot.alex)

I checked, and I think it was rather regressed by Bug 1673328.
I'll try to fix this soon (and add a test for the paused overlay, which we don't have at the moment :/)

Flags: needinfo?(poirot.alex)
Regressed by: 1673328
No longer regressed by: 1671906
Has Regression Range: --- → yes
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

In Bug 1673328, the signature of the resume function was modified,
but we missed that the function was called from the paused overlay,
which means we didn't pass the correct signature anymore, and buttons
of the paused overlay weren't working at all.
This patch fixes the callsite and adds a mochitest where we go
through a simple case of pausing and then stepping and resuming
by clicking on the overlay buttons.
Since the pause overlay is different from the other highlighters
for which we already had test helpers, we needed to add dedicated
test helpers for the pause overlay, in the test actor.

Blocks: dbg-overlay
Severity: -- → S3
Priority: -- → P3

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Priority: P3 → P1
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80c88b1aca84 [devtools] Fix debugger paused overlay buttons. r=rcaliman.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

Comment on attachment 9189144 [details]
Bug 1678258 - [devtools] Fix debugger paused overlay buttons. r=rcaliman.

Beta/Release Uplift Approval Request

  • User impact if declined: User won't be able to resume from the overlay displayed on the page when the debugger is paused, making it look broken
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  1. Open a tab with data:text/html,<meta charset=utf8><button>Click me to pause</button><script>document.querySelector("button").addEventListener("click", () => {debugger;})</script>
  2. Open devtools
  3. Click on the button in the content page
  4. The overlay should be displayed in the page, click on the resume button

-> the debugger should resume, and the overlay should be hidden

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 2 lines fix with an automated test
  • String changes made/needed:
Attachment #9189144 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9189144 [details]
Bug 1678258 - [devtools] Fix debugger paused overlay buttons. r=rcaliman.

approved for 84.0b6

Attachment #9189144 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Reproduced this issue on Firefox 84 beta 4.
Verified as fixed on the latest Nightly 85.0a1 and the on the latest Firefox 84 beta 7 - on Windows 8.1, Ubuntu 20.04 x64 and Mac OS X 10.15.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: