Closed
Bug 172302
Opened 22 years ago
Closed 6 years ago
unify unicodeToEntity
Categories
(Other Applications :: DOM Inspector, enhancement)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: timeless, Unassigned)
References
Details
Attachments
(1 file)
view partial source and dom inspector have very similar functions which could be
unified. We should consider doing this, but we don't have to do it today :).
Comment 1•21 years ago
|
||
Mass re-assigning bugs to dom.inspector@extensions.bugs
Assignee: caillon → dom.inspector
Updated•20 years ago
|
Product: Core → Other Applications
Comment 2•18 years ago
|
||
We can use this in everything becuase it is part of toolkit, right? My only concern is Seamonkey.
http://lxr.mozilla.org/seamonkey/source/toolkit/components/viewsource/content/viewPartialSource.js#467
OS: Windows 2000 → All
Hardware: PC → All
Comment 3•18 years ago
|
||
There are parts of toolkit that are actually toolkit and parts that are not, apparently. Talk to a toolkit peer about what parts of toolkit are guaranteed to be present in all XULRunner apps, then if this is one of those parts talk to the seamonkey UI folks to make sure it gets built in Seamonkey.
Comment 4•18 years ago
|
||
(In reply to comment #3)
> There are parts of toolkit that are actually toolkit and parts that are not,
> apparently. Talk to a toolkit peer about what parts of toolkit are guaranteed
> to be present in all XULRunner apps, then if this is one of those parts talk to
> the seamonkey UI folks to make sure it gets built in Seamonkey.
<gavin> its apparently enabled for everything but MOZ_EMBEDDING_PROFILE=(basic|minimal)
So, we are good to use that code then, correct?
Comment 5•18 years ago
|
||
We would be if everything were a XULRunner app... sadly, I doubt it is -- for example I just don't see the relevant files in a Seamonkey objdir (something you could have checked on yourself, btw).
Updated•17 years ago
|
Assignee: dom-inspector → nobody
QA Contact: timeless → dom-inspector
Comment 6•13 years ago
|
||
Comment 7•13 years ago
|
||
Comment on attachment 536817 [details] [diff] [review]
Use unicodeTOentity from viewPartialSource; remove associated now-dead code (including _toXML)
I don't think viewPartialSource's unicodeTOentity is suitable as it includes HTML markup to highlight the entity.
Interestingly I notice that the XML serialiser only encodes the basic entities.
Attachment #536817 -
Flags: review?(neil) → review-
Updated•13 years ago
|
Assignee: Sevenspade → nobody
Comment 9•6 years ago
|
||
No assignee, updating the status.
Comment 10•6 years ago
|
||
No assignee, updating the status.
Comment 11•6 years ago
|
||
No assignee, updating the status.
Comment 12•6 years ago
|
||
Bulk close. This component is no longer supported or maintained.
https://bugzilla.mozilla.org/show_bug.cgi?id=1499023
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Comment 13•6 years ago
|
||
Bulk close. This component is no longer supported or maintained.
https://bugzilla.mozilla.org/show_bug.cgi?id=1499023
You need to log in
before you can comment on or make changes to this bug.
Description
•