Closed
Bug 661466
Opened 13 years ago
Closed 13 years ago
Refactor utils.js clipboard flavors
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crussell, Assigned: crussell)
References
Details
Attachments
(2 files)
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
// TODO: Move these (or similar) to jsutil/system/clipboardFlavors.js or
// something as part of bug 328878.
I actually want to do this as a prerequisite to bug 546170.
Two things:
1. Rename CSSDeclaration to CSSProperty. Style declarations are not properties. This probably contributed to the confusion in bug 536012 (comment 8).
2. Move it and DOMAttribute to jsutil/system/clipboardFlavors.js
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
The license block stuff is based on these two changesets:
http://hg.mozilla.org/dom-inspector/rev/402a613487b6 (i.e., bug 338383)
http://hg.mozilla.org/dom-inspector/rev/0809873fb812 (i.e., bug 341256)
You can see that, besides me, those are the only two to have ever touched the code:
http://hg.mozilla.org/dom-inspector/annotate/7056acde111a/resources/content/utils.js#l178
http://hg.mozilla.org/dom-inspector/annotate/cac8571880ea/resources/content/utils.js#l193
Attachment #536912 -
Flags: review?(neil)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #536913 -
Flags: review?(neil)
Assignee | ||
Updated•13 years ago
|
Attachment #536912 -
Attachment description: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js → Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js
Assignee | ||
Updated•13 years ago
|
Attachment #536913 -
Attachment description: Rename CSSDeclaration to CSSProperty and make entailing viewer changes → Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes
Comment 3•13 years ago
|
||
Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]
Sorry for the delay. I don't have a trunk build that knows how to handle file copies but then I realised that my branch build pulls trunk inspector anyway.
Attachment #536912 -
Flags: review?(neil) → review+
Updated•13 years ago
|
Attachment #536913 -
Flags: review?(neil) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 536912 [details] [diff] [review]
Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]
Pushed:
http://hg.mozilla.org/dom-inspector/rev/38f7c7d8867c
http://hg.mozilla.org/dom-inspector/rev/63179abb9bd5
Attachment #536912 -
Attachment description: Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js → Phase 1: Move CSSDeclaration and DOMAttribute from utils.js to jsutil/system/clipboardFlavors.js [pushed in comment 4]
Assignee | ||
Updated•13 years ago
|
Attachment #536913 -
Attachment description: Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes → Phase 2: Rename CSSDeclaration to CSSProperty and make entailing viewer changes [pushed in comment 4]
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Updated•13 years ago
|
No longer blocks: DOMi2.0.10
You need to log in
before you can comment on or make changes to this bug.
Description
•