Audit nsLayoutUtils::GetCrossDocParentFrame usage in EventStateManager::ComputeScrollTargetAndMayAdjustWheelEvent
Categories
(Core :: DOM: Events, task)
Tracking
()
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•3 years ago
|
||
I am totally unsure whether it's okay that it won't work across process boundaries or not.
Masayuki, can you audit the usage? And if it's okay as it is, can you please replace it with nsLayoutUtils::GetCrossDocParentFrameInProcess to avoid the confusion? Thanks!
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 2•3 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
I am totally unsure whether it's okay that it won't work across process boundaries or not.
It was intended for finding a scrollable frame across document boundaries. So, when user tries to scroll in an OOP <iframe>, its parent document's scrollable frame should be scrolled when there is no scrollable frames in the OOP <iframe> under the mouse cursor.
I guess that this is currently handled by APZ across process boundaries. If so, it's okay to keep current code. Otherwise, we need to fix something.
can you please replace it with nsLayoutUtils::GetCrossDocParentFrameInProcess to avoid the confusion? Thanks!
Well, I don't have much time to work around here because of handling some urgent web-compat issues.
|
|
Assignee | |
Comment 4•3 years ago
|
||
(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #2)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
I am totally unsure whether it's okay that it won't work across process boundaries or not.
It was intended for finding a scrollable frame across document boundaries. So, when user tries to scroll in an OOP <iframe>, its parent document's scrollable frame should be scrolled when there is no scrollable frames in the OOP
<iframe>under the mouse cursor.I guess that this is currently handled by APZ across process boundaries. If so, it's okay to keep current code. Otherwise, we need to fix something.
Great, thanks! Yep, you are right, the scrolling handoff case is handled inside APZ. I am going to replace GetCrossDocParentFrame with the in-process version in this bug.
(That said, I wonder once after we shipped Fission, we will no longer need the code in question?)
|
|
Assignee | |
Comment 5•3 years ago
|
||
|
||
Comment 7•3 years ago
|
||
Setting status-firefox92=wontfix because we don't need to uplift this change to Beta 92 since it is not changing behavior, just making the InProcess explicit.
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
Description
•