Open Bug 1725549 Opened 3 years ago Updated 3 years ago

Add comment about nsLayoutUtils::GetCrossDocParentFrame usage in EventStateManager::DecideGestureEvent

Categories

(Core :: DOM: Events, task, P3)

task

Tracking

()

Fission Milestone Future
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox91 --- wontfix
firefox92 --- disabled

People

(Reporter: hiro, Unassigned)

References

Details

(Whiteboard: [fission:m?])

Similar to bug 1725548, but for EventStateManager::DecideGestureEvent.

Masayuki, again, do you know who is the right person to audit this?

Fission Milestone: --- → M8
Flags: needinfo?(masayuki)

Searchfox says this EventStateManager::DecideGestureEvent function is not covered by any tests:

https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/dom/events/EventStateManager.cpp#3023

Do these gesture events happen in content processes? If they only happen in the parent process, then this code should work correctly.

Whiteboard: fission-soft-blocker

That particular code is parent process only.
I guess we can use this bug to add some comment there.

Fission Milestone: M8 → MVP
Whiteboard: fission-soft-blocker
Flags: needinfo?(masayuki)

(In reply to Olli Pettay [:smaug] from comment #3)

That particular code is parent process only.
I guess we can use this bug to add some comment there.

If this code works as expected and this bug is just to add a comment, then this bug doesn't need to block Fission Milestone MVP.

Fission Milestone: MVP → Future
Whiteboard: [fission:m?]
Severity: -- → N/A
Priority: -- → P3

(In reply to Chris Peterson [:cpeterson] from comment #4)

(In reply to Olli Pettay [:smaug] from comment #3)

That particular code is parent process only.
I guess we can use this bug to add some comment there.

If this code works as expected and this bug is just to add a comment, then this bug doesn't need to block Fission Milestone MVP.

Since this bug is now about adding a code comment instead of auditing the function calls, I will update the bug summary.

Summary: Audit nsLayoutUtils::GetCrossDocParentFrame usage in EventStateManager::DecideGestureEvent → Add comment about nsLayoutUtils::GetCrossDocParentFrame usage in EventStateManager::DecideGestureEvent
You need to log in before you can comment on or make changes to this bug.