Disabled status of message filters not shown in list of filters
Categories
(Thunderbird :: Filters, defect)
Tracking
(thunderbird_esr91+ fixed, thunderbird92 fixed, thunderbird93 fixed)
People
(Reporter: reg_bugzilla.mozilla.org, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36
Steps to reproduce:
Open Message Filter
Toggle "enabled" state for some filters by clicking the checkmark
Close Message Filter
Open Message Filter again
Actual results:
all the previous disabled Message Filters were enabled again
Expected results:
Thunderbird should save the enabled/disabled state of the message filters after closing the Message Filter window.
|
Reporter | |
Comment 1•3 years ago
|
||
Further infos:
Win 10 Pro 64 bit, Thunderbird 91.0.2 64 bit
Tried it with troubleshoot mode and created a new profile, bug persists in both cases.
|
||
Comment 2•3 years ago
|
||
I see this with 92.0b3. Nothing in error console.
This could lead to dataloss, so pretty serious.
I think I have disabled filters that are not being listed, so perhaps it is partly a display issue?
|
||
Comment 3•3 years ago
|
||
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=563485d4bac29add2876f31fb05e5b110ffd1b43&tochange=f734b3219c1da7ffa0f9c76c143ed8867a76e7f3
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=269819a25f93255894887689cac0df8e7dbf3cb5&tochange=b740f950e4971e9e17c16b0e19e569cd3b07ceb5
Regression window(with browser.proton.enabled = true):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=cb9f2cf495acec1c430981548787c7382bff209a&tochange=0870a62e5554cff44c2c2a1d74df29948027ef34
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8fdbcaa80217ed7e511f08f7aab4b8bb6fbae77c&tochange=6264f13d54a1caa4f5b60303617a819efd91b8ee
Suspect : Bug 1697315 or Bug 1697210
|
|
||
Comment 4•3 years ago
|
||
I looked at my msgfilters.dat file and I see rules with enabled="no". So it is definitely a display issue.
|
Assignee | |
Comment 5•3 years ago
|
||
The toolkit rule check only on [checked] and the checkbox uses checked="false". With this the rule is always true.
|
|
||
Updated•3 years ago
|
|
||
Comment 6•3 years ago
|
||
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 8•3 years ago
|
||
Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch
[Approval Request Comment]
User impact if declined: disabled filters are still shown as active
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): should be low, it's a simple JS change
|
|
||
Comment 9•3 years ago
|
||
Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch
[Triage Comment]
Approved for beta
|
||
Comment 10•3 years ago
|
||
| bugherder uplift | ||
Thunderbird 92.0b5: (fixed typo)
https://hg.mozilla.org/releases/comm-beta/rev/8f094a5c86b6
|
|
||
Comment 11•3 years ago
|
||
Comment on attachment 9237994 [details] [diff] [review]
1727366-filter-checked.patch
[Triage Comment]
Approved for esr91
|
|
||
Comment 14•3 years ago
|
||
| bugherder uplift | ||
Description
•