Creating a new address book or mailing list is not keyboard accessible in the new AB
Categories
(Thunderbird :: Address Book, defect, P1)
Tracking
(thunderbird_esr102? fixed, thunderbird104 fixed)
People
(Reporter: thomas8, Assigned: micah)
References
(Blocks 1 open bug)
Details
(Keywords: access, regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr102+
|
Details |
(deleted),
image/png
|
Details |
98.0a1 (2022-01-20) (64-bit), Win10
No keyboard way of creating a new custom address book or mailing list in the NEW address book.
Expected:
- Menu entries: File > New >
Address Book
(andAdd CardDav Address Book
/Add LDAP Address book
) - Menu entry: File > New >
Mailing List
- Respective context menu entries somewhere, e.g.: Directory pane context menu.
- Maybe the AB toolbar could also have a single tab focus stop on
New Address Book
button, then cursor keys to navigate adjacent buttons
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
See https://bugzilla.mozilla.org/show_bug.cgi?id=1705276#c6.
There is also no way to modify address books or mailing lists via keyboard.
Reporter | ||
Comment 2•3 years ago
|
||
(In reply to Nicolai Kasper from comment #1)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1705276#c6.
There is also no way to modify address books or mailing lists via keyboard.
What do you mean by "modify address books"?
Comment 3•2 years ago
|
||
Given that the string freeze is approaching next tuesday, if we have menu entries like you suggested they will need strings. So you might want to push a patch that just adds these menu strings in case we need them, similarly regarding bug 1751282.
Otherwise, we will need to put a tabindex="0"
on this element https://searchfox.org/comm-central/rev/2cf3a09a0127fe73e932c5ee793986f3bed2ccd2/mail/components/addrbook/content/aboutAddressBook.xhtml#41 and all the other toolbar buttons to have some way to add an addressbook, similarly regarding bug 1751282.
Reporter | ||
Comment 4•2 years ago
|
||
Mass-adding regression keyword to applicable AB bugs.
#20220530ABRegressionKeyword01
Reporter | ||
Comment 5•2 years ago
|
||
Alex, can we avoid making keyboard/screen reader depending users suffer for a full year with AB and mailing list creation inaccessible? Imo especially being unable to create a mailing list via keyboard looks like a pretty painful limitation.
- Either restore some of the main menu regressions mentioned in comment 0 (I guess we could always show those entries as long as they open up AB tab), which is part of bug 1771605.
- Or use Henry's quick fix of comment 3,
tabindex="0"
on the four AB toolbar buttons to make them accessible? This won't disturb regular navigation as we're focusing the search box when AB tab is opened, and the buttons are all before the search box in the tab sequence. Then later on at a time of our convenience we can reduce the four stops to one per toolbar in bug 1776192. This might be a fast and elegant solution, also very easy to undo. What do you think?
Comment 6•2 years ago
|
||
Yup, let's do that.
Micah, can you take care of this by following Henry's recommendation?
Otherwise, we will need to put a tabindex="0" on this element https://searchfox.org/comm-central/rev/2cf3a09a0127fe73e932c5ee793986f3bed2ccd2/mail/components/addrbook/content/aboutAddressBook.xhtml#41 and all the other toolbar buttons to have some way to add an addressbook, similarly regarding bug 1751282.
Make sure to test that tabbing will make possible to focus those buttons and trigger the creation dialogs when pressing Enter.
making this a P1 since it should happen pretty quickly
Assignee | ||
Comment 7•2 years ago
|
||
Comment 8•2 years ago
|
||
It seems that macOS completely ignores tabindex
for xul:toolbarbutton
.
I also tried adding -moz-user-focus: normal
but no luck, the focus is completely ignored and skipped.
Is this something xul toolbarbuttons don't support at all?
Kindly pinging Magnus to know if he has any clue, or if he knows someone we can ask from m-c.
Comment 9•2 years ago
|
||
(In reply to Alessandro Castellani [:aleca] from comment #8)
It seems that macOS completely ignores
tabindex
forxul:toolbarbutton
.
I also tried adding-moz-user-focus: normal
but no luck, the focus is completely ignored and skipped.Is this something xul toolbarbuttons don't support at all?
Kindly pinging Magnus to know if he has any clue, or if he knows someone we can ask from m-c.
This works for me on Mac and also the other platforms. Where is an accessibility setting on macOS to enable the focus ring on all elements.
On all platforms the focus ring is cut on the first button because of the outline-offset. Also does nothing happen when I press ENTER, SPACE or Cursor-DOWN.
Comment 10•2 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #9)
On all platforms the focus ring is cut on the first button because of the outline-offset. Also does nothing happen when I press ENTER, SPACE or Cursor-DOWN.
XUL toolbarbutton-menubutton-button
uses Alt+DownArrow for opening the menu. It is not very good, but it is the same for xul:menu.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4fd17e6552d8
Make toolbar buttons keyboard accessible in Address Book. r=aleca
Comment 12•2 years ago
|
||
Comment 14•2 years ago
|
||
Comment on attachment 9288671 [details]
Bug 1751282 - Make toolbar buttons keyboard accessible in Address Book. r=aleca
[Approval Request Comment]
Regression caused by (bug #): bug 1705276
User impact if declined: Inability to access the creation buttons with keyboard navigation
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): it should be low since this only adds the tabindex attribute to those buttons to make them available in the regular Tab roving.
IMPORTANT! The follow up test fix patch should be uplifted alongside this.
Comment 15•2 years ago
|
||
Comment on attachment 9288671 [details]
Bug 1751282 - Make toolbar buttons keyboard accessible in Address Book. r=aleca
[Triage Comment]
Approved for beta
Comment 16•2 years ago
|
||
bugherder uplift |
Thunderbird 104.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/a7b70b741629
Thunderbird 104.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/3e8db20f0154
Comment 17•2 years ago
|
||
Comment on attachment 9288671 [details]
Bug 1751282 - Make toolbar buttons keyboard accessible in Address Book. r=aleca
[Triage Comment]
Approved for esr102 (optimistically)
Comment 18•2 years ago
|
||
bugherder uplift |
Description
•