Closed Bug 1758294 Opened 3 years ago Closed 3 years ago

Download panel context menu acts on the first item in the list instead of the one clicked on

Categories

(Firefox :: Downloads Panel, defect, P1)

Firefox 99
x86_64
All
defect
Points:
3

Tracking

()

VERIFIED FIXED
100 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox97 --- unaffected
firefox98 --- unaffected
firefox99 + verified
firefox100 --- verified

People

(Reporter: smowtenshi, Assigned: dao)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-Quality-Foundation])

Attachments

(3 files)

Attached video Peek 2022-03-06 01-40.mp4 (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

I downloaded a few files and later I tried to remove the last one displayed in the downloads panel.

Actual results:

Even though I selected the last one and clicked "Remove From History", the first one listed was removed.

Expected results:

The entry I selected should get removed.

OS: Unspecified → Linux
Hardware: Unspecified → x86_64

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Downloads Panel

I can also reproduce this on Win11 running the latest Nightly build, today's.

OS: Linux → All

Hello I have managed to reproduce the issue only with 99.0a1 (2022-03-07) on Ubuntu 20.04, with the firefox versions 98.0 and 97.0.2 the issue did not reproduce, I have also tried to reproduce on macOS 12 and windows 10 but i didn't manage with firefox 99.0a1(2022-03-07) and 97.0.2.

Marking this issue as new in order for our developers to look more into it.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true

Any chance you can use mozregression to narrow it down further?

Flags: needinfo?(sergiu.negritas)

Thanks!

Flags: needinfo?(sergiu.negritas)

Set release status flags based on info from the regressing bug 1756113

:dao, since you are the author of the regressor, bug 1756113, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
Summary: Removing download from history removes the first one → Download panel context menu acts on the first item in the list instead of the one clicked on

This is pretty bad and we should not ship this.

Severity: -- → S2
Priority: -- → P1

Are there any concerns in fixing this for 99?
Can this be assigned?

Flags: needinfo?(mak)
Assignee: nobody → dao+bmo
Blocks: 1756002
Status: NEW → ASSIGNED
Flags: needinfo?(mak)
Whiteboard: [fidefe-Quality-Foundation]

Dao: Do we have an update here? We need to get a patch asap to avoid shipping this in 99.

Flags: needinfo?(dao+bmo)
Attachment #9269396 - Attachment description: WIP: Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. → Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6700f8451269 Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Comment on attachment 9269396 [details]
Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0 and bug 1758644; we should test all context menu items.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial fix
  • String changes made/needed:
Flags: needinfo?(dao+bmo)
Attachment #9269396 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

Hit a merge conflict in browser_downloads_panel_context_menu.js when trying to graft this to beta.
Please provide a patch with the merge conflicts resolved.

Flags: needinfo?(dao+bmo)
Attached patch patch for beta (deleted) — Splinter Review

fixed conflict in browser_downloads_panel_context_menu.js

Flags: needinfo?(dao+bmo)

Comment on attachment 9269396 [details]
Bug 1758294 - Download panel context menu acts on the first item in the list instead of the one clicked on. r=mak

Approved for beta uplift, available on the beta channel with 99RC1. Thanks.

Attachment #9269396 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Reproduced the issue with Firefox 99.0a1 (20220306190604) on Windows 10x64 and Ubuntu 20. The first item is deleted when selecting the Remove from history context menu option on another item.

The issue is verified fixed with Firefox 100.0a1 (20220327213550) and 99.0b9 (20220327183628) from comment 20 on Windows 10x64/ 11x64, macOS 10.15 on Ubuntu 20. Selecting the Remove From History context menu option deletes the expected item from the Download Panel.

All the remaining context menu items were tested and they work as follows:

  • Always Open Similar files- automatically open similar downloaded files when checked.
  • Show in folder- opens the Explorer with the selected item in focus
  • Go to Download Page- opens the webpage from where the item was downloaded.
  • Delete- deletes the selected file from the explorer only
  • Remove From History- successfully removes the selected item from the download panel
  • Clear Preview Panel- clears all download panel
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Points: --- → 3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: