Always first item drag & dropped from downloads list
Categories
(Firefox :: Downloads Panel, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox98 | --- | unaffected |
firefox99 | --- | verified |
firefox100 | --- | verified |
firefox101 | --- | verified |
People
(Reporter: tomaz.jandrok, Assigned: dao)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-2022-downloads-followup])
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
text/x-phabricator-request
|
diannaS
:
approval-mozilla-beta+
dmeehan
:
approval-mozilla-release+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0
Steps to reproduce:
-
I downloaded all STL files from this sample project
https://www.thingiverse.com/thing:5323499/files -
When I try to drag & drop the files visible in last downloaded list (not show all downloads) for example to Cura, there is always first downloaded file that is drag & dropped to the Cura (see attachment, where I tried to drag&drop third item in the list. It's the same with second item.).
Actual results:
When I drag & drop any downloaded file from last downloaded files list, first file from the list is always selected & drag & dropped to external program.
Expected results:
If I drag & drop for example second file in the last downloaded files list that should be drag & dropped to external program.
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Thanks for the report. This looks very similar to bug 1758294. Dão, can you take a look?
Reporter: are you seeing the same thing on more recent versions of beta? (I'm assuming you're on beta...)
Also, to confirm, if you use the library window (show all downloads - ctrl-j on Windows), does dragging from there work correctly?
Reporter | ||
Comment 2•3 years ago
|
||
I am testing this on beta version 99.0b (released on 8th of March), which is the latest currently on the Firefox website.
If I use library window (show all downloads) drag & drop functionality works correct as expected.
The bug can also be simply seen with just drag & dropping a file from last downloaded list to any folder in explorer on Windows (no external program needed).
Comment 3•3 years ago
|
||
it's likely a similar issue indeed, we drag the RLB selected item https://searchfox.org/mozilla-central/rev/26a1b0fce12e6dd495a954c542bb1e7bd6e0d548/browser/components/downloads/content/downloads.js#1045-1046 instead we should probably drag the closest download
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Set release status flags based on info from the regressing bug 1756113
Comment 7•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0; note that you don't need to drop the download on an external application, the tab bar works too for instance.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial fix
- String changes made/needed:
Comment 9•3 years ago
|
||
Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak
Approved for 100.0b3
Comment 10•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Comment 11•3 years ago
|
||
Reproduced with Fx 100.0a1 (2022-04-02) (64-bit) on Windows 10.
Verified fixed with Fx 101.0a1 (2022-04-07) and Fx 100.0b3 on Windows 10, macOS 11.0 and Ubuntu 20.04.
Comment 13•3 years ago
|
||
Comment on attachment 9270746 [details]
Bug 1762723 - Use proper dragstart event targets in the download panel. r=mak
Approved for 99.0.1.
Comment 14•3 years ago
|
||
bugherder uplift |
Comment 15•3 years ago
|
||
Verified fixed with FX 99.0.1 on Windows 10, macOS 11.0 and Ubuntu 20.04.
Description
•