Turn on dom.screenorientation.allow-lock=true in GeckoView Nightly
Categories
(GeckoView :: General, enhancement, P2)
Tracking
(firefox110 wontfix, firefox111 fixed)
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
(Whiteboard: [geckoview:2022h2?])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Fenix has implemented orientation delegate via https://github.com/mozilla-mobile/fenix/issues/23415. We should enable this pref in Nightly at least.
|
||
Comment 1•3 years ago
|
||
Makoto, are there known bugs we need to fix before this feature is ready to ride the trains to Beta and Release?
|
Assignee | |
Comment 2•3 years ago
|
||
I think most issues were done for nightly.
I think we need to fix bug 1750670 and bug 1763052 (this causes WPT failures) at least if we turn on this pref in all channels.
And I guess bug 1744288 is optional, it may occur on youtube.com (YouTube had some issues for orientation lock when I tested it one month ago), So I have to verify it again.
|
|
||
Updated•2 years ago
|
|
|
||
Comment 3•2 years ago
|
||
Assigning this bug to Makoto. He will decide whether we need to prioritize it for 2022 H2.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 5•2 years ago
|
||
I would like to enable this API in Nightly for testing.
Supported in GeckoView and Windows tablet mode. Other platforms are no
affect by this preference. WPT [*1] runs on non-supported platform, so
a lot of tests are failure. (GeckoView passes a lot of tests [*2].)
Also, there is an issue of hidden document [*2], it isn't fixed by spec
side yet.
*1 https://wpt.fyi/results/screen-orientation
*2 https://searchfox.org/mozilla-central/source/testing/web-platform/meta/screen-orientation
*3 https://github.com/w3c/screen-orientation/pull/232
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
|
||
Updated•2 years ago
|
|
||
Comment 8•2 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: New web developer functionality
[Affects Firefox for Android]: only
[Suggested wording]: all ready added to the 111 relnote doc
[Links (documentation, blog post, etc)]:
https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock needs updating to show support.
|
|
Assignee | |
Comment 9•2 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #8)
Release Note Request (optional, but appreciated)
[Why is this notable]: New web developer functionality
[Affects Firefox for Android]: only
[Suggested wording]: all ready added to the 111 relnote doc
[Links (documentation, blog post, etc)]:https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock needs updating to show support.
This is only Nightly, so I don't turn on this on release channel yet.
Description
•