User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:99.0) Gecko/20100101 Firefox/99.0

Steps to reproduce:

The email display does not seem to recognize that an email address is in my contacts if it is a secondary email address, even though it does find all the addresses in the Compose window.

Actual results:

Email address that is listed as a secondary address in address book does not register as being in my contacts in the email display.

Expected results:

The email display should recognize all addresses included for the contact. (The address book in question is syncing with Google, not sure if that is relevant)

This worksforme on 102.1.0 (64-Bit), Win10, see screenshot.

Both default and secondary email address (via Google-CALDAV) recognized as known in recipient area, and unknown similar address correctly indicated with black dot.

Wfm per my comment 1.

Reporter, please note that only the unknown addresses will be indicated with a dot.
If you think that you're still seeing this problem on 102.1.0, please attach a screenshot after blacking out private data with graphics editor. Attach New File button above comment 0

Maybe you were confused about what I meant, I mean in received emails. So I have an email that I received and the sender email is in my address book as a secondary email, but the sender icon does not show up as blue for being in my contacts though they should be. Not sure how to actually demonstrate that with a screenshot, but it's still the case in the 103 beta as far as I can tell.

The line that determines whether it is shown as in the addressbook is here https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mail/base/content/widgets/header-fields.js#466

And I think this method is still using "SecondEmail", which is not set anymore https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mailnews/addrbook/modules/AddrBookDirectory.jsm#447-451

It seems "SecondEmail" is still used in a number of places https://searchfox.org/comm-central/search?q=SecondEmail&path=&case=false&regexp=false

Geoff or Nicolai will know better what to do to replace these.

(In reply to mn2482 from comment #3)

Maybe you were confused about what I meant, I mean in received emails. So I have an email that I received and the sender email is in my address book as a secondary email, but the sender icon does not show up as blue for being in my contacts though they should be. Not sure how to actually demonstrate that with a screenshot, but it's still the case in the 103 beta as far as I can tell.

Hey thanks for reaching out!
I do have issues to replicate this issue. I attached a screenshot to be sure that we are talking about the same issue. I tested this on daily with a google address book.

Only to be sure there was a issue with google and secondary emails which got resolved by Bug 1777214.
Are you using Thunderbird 103.0b2 or higher or Thunderbird 102.0.1 or higher?

P.S. Regarding the usage of "SecondEmail" in the source code I do not feel confident to say if this is causing an issue or not.

I can reproduce with three emails set. Could it be an issue with the code only searching for the "PrimaryEmail" and "SecondEmail", when it should search the whole list of emails?

Steps to Reproduce

1. Create a contact with three emails: "1@e.net", "2@e.net", "3@e.net".
2. Compose a message.
3. Start typing "1". Get "1@e.net" suggestion.
4. Start typing "2". Get "2@e.net" suggestion.
5. Start typing "3". No suggestion.
6. Complete the pill as "3@e.net". Shown as "not in the addressbook" with the dot in the corner.
7. Save to drafts.
8. Find and display the draft. "1@e.net" and "2@e.net" are shown as in the address book. "3@e.net" is not.

(In reply to Henry Wilkes (they/them) [:henry] from comment #6)

I can reproduce with three emails set. Could it be an issue with the code only searching for the "primaryEmail" and "secondEmail", when it should search the whole list of emails?

Thanks for your clarification. I do get 3@e.net as a suggestion if I use the name though.
But once saved as a draft the contact is not shown to be in the address book.

Taking the requested information for mn2482 back.

Didn't look closely but
https://searchfox.org/comm-central/rev/03a5b79dbaeb0e8b2b9864fbe69eecd233a9133d/mail/base/content/widgets/mailWidgets.js#1347 ->
https://searchfox.org/comm-central/rev/03a5b79dbaeb0e8b2b9864fbe69eecd233a9133d/mailnews/addrbook/modules/AddrBookDirectory.jsm#447 should check all addresses (see https://searchfox.org/comm-central/rev/03a5b79dbaeb0e8b2b9864fbe69eecd233a9133d/mailnews/addrbook/modules/AddrBookCard.jsm#248)

Seems like a fair assessment. I'll take this.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e9f46b86384e
Make cardForEmailAddress look beyond the first two addresses. r=mkmelin

Comment on attachment 9287174 [details]
Bug 1777156 - Make cardForEmailAddress look beyond the first two addresses. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): Never worked
User impact if declined: Some parts of the UI don't recognised third addresses of contacts
Testing completed (on c-c, etc.): Landed a week ago
Risk to taking this patch (and alternatives if risky): Potentially affects performance, impact unknown at this point

Comment on attachment 9287174 [details]
Bug 1777156 - Make cardForEmailAddress look beyond the first two addresses. r=mkmelin

[Triage Comment]
Approved for beta

Thunderbird 104.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/4d9fda62d4db

Comment on attachment 9287174 [details]
Bug 1777156 - Make cardForEmailAddress look beyond the first two addresses. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: third email address mostly useless
Testing completed (on c-c, etc.): in 104b2
Risk to taking this patch (and alternatives if risky): had a perf regression, bug 1782725

Comment on attachment 9287174 [details]
Bug 1777156 - Make cardForEmailAddress look beyond the first two addresses. r=mkmelin

[Triage Comment]
Approved for esr102

Thunderbird 102.3.0:
https://hg.mozilla.org/releases/comm-esr102/rev/992d63958407