Open Bug 1782481 Opened 2 years ago Updated 2 years ago

[Meta] Double-check on instances of "SecondEmail" in the code to prevent bugs

Categories

(Thunderbird :: Address Book, defect, P3)

Thunderbird 102

Tracking

(Not tracked)

People

(Reporter: thomas8, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Keywords: meta)

+++ This bug was initially created as a clone of Bug #1777156 +++

We're no longer using "SecondEmail" now that we support more.

[Edit: The premise of this bug isn't quite right, see comment 1]

So instances of "SecondEmail" in the code have a high risk of causing weird bugs.
We should double-check if we need to eliminate/fix some old instances before wasting resources on such bugs.
I suggest to fix this in satellite bugs which block this meta bug.

I've updated Henry's query to exclude SeaMonkey.
https://searchfox.org/comm-central/search?q=SecondEmail&path=%5Email&case=false&regexp=false

(In reply to Henry Wilkes (they/them) [:henry] from Bug 1777156 comment #4)

And I think this method is still using "SecondEmail", which is not set anymore https://searchfox.org/comm-central/rev/4bee93af727f0d1c1a919012de9c31fd73a3adf0/mailnews/addrbook/modules/AddrBookDirectory.jsm#447-451

It seems "SecondEmail" is still used in a number of places https://searchfox.org/comm-central/search?q=SecondEmail&path=&case=false&regexp=false

Geoff or Nicolai will know better what to do to replace these.

Depends on: 1782483

(In reply to Thomas D. (:thomas8) from comment #0)

We're no longer using "SecondEmail" now that we support more.
So instances of "SecondEmail" in the code have a high risk of causing weird bugs.
We should eliminate those instances before wasting resources on such bugs.

Or so I thought, based on Henry's claim in Bug 1777156 comment #4 that we no longer set "SecondMail" any more.
Turns out we still do (here), and looking at Geoff's latest patch, it's deliberate (D152834).

Geoff, any instances of "SecondMail" in code that may still be leftovers of the old implementation?

Flags: needinfo?(geoff)
Summary: [Meta] Remove "SecondEmail" from code to prevent bugs → [Meta] Double-check on instances of "SecondEmail" in the code to prevent bugs
Depends on: 1782608

Yes. Many. I deliberately didn't remove SecondEmail as many things still rely on it. They will be picked apart when more time is available.

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.