Closed Bug 1778725 Opened 2 years ago Closed 2 years ago

Use primary (master) password unlocking at Thunderbird at startup time on macOS - default security.prompt_for_master_password_on_startup to true

Categories

(Thunderbird :: Mail Window Front End, enhancement)

Unspecified
macOS
enhancement

Tracking

(thunderbird_esr91 wontfix, thunderbird_esr102+ fixed, thunderbird103 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
thunderbird_esr91 --- wontfix
thunderbird_esr102 + fixed
thunderbird103 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(1 file)

Today, bug 177175 is still unresolved in general.

We had introduced a workaround in bug 1610390, that had improved the situation for Linux and Windows.

Unfortunately the workaround did not work on macOS in Thunderbird versions 78.x and 91.x, so it was kept disabled for macOS (see bug 1612456).

In the meantime we've gotten positive test results that the workaround from bug 1610390 is working in Thunderbird 102.x !

Therefore I suggest that we enable the workaround from bug 1610390 by default for TB 102 and later versions on macOS, too.

The suggestion is to enable pref security.prompt_for_master_password_on_startup by default on macOS, too.

Summary: Enable security.prompt_for_master_password_on_startup for macOS, too → Use master password unlocking at Thunderbird at startup time on macOS
Attachment #9284713 - Attachment description: Bug 1778725 - Use master password unlocking at Thunderbird at startup time on macOS. r=wsmwk → Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=wsmwk

FYI, works for me in TB 91.11.0. About TB dialog and Preferences tab open just fine with this flag enabled. I just filed this blocker bug 1778922.

Depends on: 1778922

I realize Wayne might not be set up to review patches in phabricator.

Wayne, does it make sense to ask you for review of this default preference change, or would you prefer if I ask someone else?
If you are willing to r+, just say here in a comment.

Flags: needinfo?(vseerror)

The change makes sense to me. But I am not a code reviewer.

Flags: needinfo?(vseerror)
Attachment #9284713 - Attachment description: Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=wsmwk → Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

We should ask beta users on mac to test this.

Status: NEW → ASSIGNED
Target Milestone: --- → 104 Branch

Comment on attachment 9284713 [details]
Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: mac users with master password face multiple prompts on startup
Testing completed (on c-c, etc.): needs testing on beta
Risk to taking this patch (and alternatives if risky): rather low, the code is working fine on other platforms, and the only known side effect on macos can no longer be reproduced

Attachment #9284713 - Attachment description: Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin → Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=wsmwk
Attachment #9284713 - Flags: approval-comm-beta?

(In reply to Magnus Melin [:mkmelin] from comment #6)

We should ask beta users on mac to test this.

How should we ask them? Posting on the tb-beta list?

Flags: needinfo?(vseerror)

Note, if we have a good channel to ask, we could even ask release users of 102 to test this, they could manually flip the pref.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e53c07a17b7d
Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attachment #9284713 - Attachment description: Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=wsmwk → Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

Comment on attachment 9284713 [details]
Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

[Triage Comment]
Approved for beta

We don't really have a good way to get 102 feedback, but beta certainly can be posted to the forum.

Flags: needinfo?(vseerror)
Attachment #9284713 - Flags: approval-comm-beta? → approval-comm-beta+
Summary: Use master password unlocking at Thunderbird at startup time on macOS → Use primary (master) password unlocking at Thunderbird at startup time on macOS

103b5 (macos) has definitely changed/fixed this for me! Now I get just one prompt on startup before the main window shows up. Before the main window would show up and then I'd get the multiple prompts. So much better!

OS: Unspecified → macOS
Summary: Use primary (master) password unlocking at Thunderbird at startup time on macOS → Use primary (master) password unlocking at Thunderbird at startup time on macOS - default security.prompt_for_master_password_on_startup to true

As the reporter of bug 1778010, I can confirm this is fixed on macOS 10.13. :)

(In reply to Kai Engert (:KaiE:) from comment #9)

Note, if we have a good channel to ask, we could even ask release users of 102 to test this, they could manually flip the pref.

I can confirm that on 102.1.0, by following the recommended workaround (in #1), the duplicate password prompt goes away.

Time to uplift to 102?

Comment on attachment 9284713 [details]
Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

[Approval Request Comment]
see comment 7

Attachment #9284713 - Flags: approval-comm-esr102?

Comment on attachment 9284713 [details]
Bug 1778725 - Use master password unlocking at Thunderbird startup time on macOS. r=mkmelin

[Triage Comment]
Approved for esr102

Attachment #9284713 - Flags: approval-comm-esr102? → approval-comm-esr102+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: