Closed Bug 1821376 Opened 2 years ago Closed 2 years ago

Overflow Menu area in "Customize Toolbar" page does not work correctly

Categories

(Core :: XUL, defect)

Firefox 112
defect

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- unaffected
firefox111 --- unaffected
firefox112 --- disabled
firefox113 --- verified

People

(Reporter: Fanolian+BMO, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression, reproducible)

Attachments

(2 files)

Attached video Overflow menu area.mp4 (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0
Build ID: 20230309093044

Steps to reproduce

  1. In a new profile, enter "Customize Toolbar" page.
  2. Try to drag buttons into the bottom part of the overflow menu area.
  3. Drag many buttons into the area.

Actual result

Please refer to attached video.

  1. Buttons are not added to overflow menu if they are dragged into the bottom part of the overflow menu area.
  2. Large gaps between buttons in the area if there are only few buttons.
  3. The area pushes the bottom row of menu out of view.
    -> This happens even in a maximised Firefox window with 1920×1080 100% scale display. I cannot play the hidden unicorn pong game. 😑

Expected result

Before bug 1820534, the overflow menu area expands downwards only when needed. It shows a scrollbar and does not push items below it out of view.

Regression

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=53491bc68f81d4c082d3d6cfdda617fe4deca8b0&tochange=c25af897c9bcb33045fe7664d93684de65cbf2a8
This is regressed by bug 1820534

Flags: needinfo?(emilio)
Has STR: --- → yes
Regressed by: 1820534
Flags: needinfo?(emilio)

Customize mode was already using display: flex. This meant that the
-moz-box-flex: 1 rules had no effect at all. Remove some
previously-useless flex attributes / properties, and unflex items in the
overflow menu to restore previous behavior

Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Set release status flags based on info from the regressing bug 1820534

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93333c28e28e Fix interactions of overflow menu with modern flexbox migration. r=Gijs
Duplicate of this bug: 1821678
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
Flags: qe-verify+

Reproduced using an old Nightly build before the fix, verified that using Firefox 113.0b8 across platforms (macOS 13, Windows 10, Ubuntu 22.04) the overflow menu area is smaller and can add items in its entire size.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: