User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030110 Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030110 When going to the specified URL, I get an error message "The plugin performed an illegal operation. You are strongly advised to restart Navigator." I don't mind getting an error - the page contains SVG and I don't think I do have an up-to-date plugin - but the application name "Navigator" seems to be hard-coded. Reproducible: Always Steps to Reproduce: 1. Load the above URL without a suitable SVG plugin. Actual Results: See an error "The plugin performed an illegal operation. You are strongly advised to restart Navigator." Expected Results: Should see "... You are strongly advised to restart Phoenix", if using Phoenix. I don't know whether Mozilla should say "Navigator" or "Mozilla". seems to be BadPluginMessage in xpfe/components/xfer/resources/locale/en-US/downloadProgress.properties

"plugin" is also spelled wrong. Should be "plug-in"

Just noticed this too in Firefox 1.0PR Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20040913 Firefox/0.10 And in this case, "plugins" aren't even called "plug-ins" anymore, but "extensions". Would be best if this string wouldn't be hardcoded both to use the proper product name and the term used in the product.

jonas.nordlund@gmail.com: a plug-in is a plug-in. it always has been, it always will be. not to be confused with extensions.

Sorry, my bad, got confused :-) Anyway, there's yet another reason to fix this since the Firefox Help won't find any information about "plugins" or where to get them. It will, however, if you search for "plug-ins".

*** Bug 259171 has been marked as a duplicate of this bug. ***

*** Bug 273501 has been marked as a duplicate of this bug. ***

*** Bug 273582 has been marked as a duplicate of this bug. ***

Neil: Could you advise on the following? I guess we need to use the StringBundleOverride stuff here, but I'm not sure. What I think is: when the StringBundle is initialized in <>, we need to add an mOverrideBundle, which probably should be this one: nsCOMPtr<nsIStringBundle> bundle; bundleService->CreateBundle("chrome://global/locale/brand.properties", getter_AddRefs(bundle)); And then add that as an argument when creating the StringBundle for downloadProgress.properties. The patch for the properties file would be as simple as this: - BadPluginMessage=The plugin performed an illegal operation. You are strongly advised to restart Navigator. + BadPluginMessage=The plugin performed an illegal operation. You are strongly advised to restart %S. Or am I completely wrong - does nsIPersistentProperties have anything to do with this ?

Right, the '<>' was supposed to be filled with: <http://lxr.mozilla.org/seamonkey/source/modules/plugin/base/src/nsPluginHostImpl.cpp#6082>

I was wrong in my last comment(s), as pointed to by bsmedberg and biesi on IRC. Thankfully, they helped me along to the correct way. These are the C changes. properties changes coming up.

Uses %S instead of 'Navigator'.

This includes all the three files in one attachment (sorry about the spam!). It also includes the second (!) downloadProgress.properties (one for suite and one for other apps). The file should probably be moved, as biesi pointed out on IRC, but that's for Peter to decide, I guess. It's also terribly confusingly named :)

Comment on attachment 168661 [details] [diff] [review] includes the two above patches, and the second properties file r+sr=jst

jst: As discussed on IRC, could you check this in when you get a chance?

timeless suggested that we only use one bundle variable, so here's my try on that approach

Comment on attachment 168997 [details] [diff] [review] alternate approach jst: timeless thinks this is a better approach - could you take a look? Feel free to land the patch of your choice.

*** Bug 277110 has been marked as a duplicate of this bug. ***

Comment on attachment 168997 [details] [diff] [review] alternate approach I'm fine with either patch here... r=jst

Re: additional comment #1, shouldn't this text have "plugin" changed to "plug-in" with a hyphen? +BadPluginMessage=The plugin performed an illegal operation. You are strongly advised to restart %S.

yes. "plugin" should be "plug-in"

I'll update the patch. I think we'll go for the alternate approach in attachment 168997 [review], because it's smaller. We'll wait till after 1.8a6 before landing it, though, as this isn't really critical for an alpha anyway.

New patch to that effect (derived from attachment 168997 [details] [diff] [review]). Carrying forward r+sr=jst.

Fix checked in.

*** Bug 176542 has been marked as a duplicate of this bug. ***

*** Bug 279534 has been marked as a duplicate of this bug. ***

One-liner fix for the chrome URL to brand.properties

Comment on attachment 172802 [details] [diff] [review] fix for legal chrome URL r=me, as it concerns locale things and it's simple ;-)

Comment on attachment 172802 [details] [diff] [review] fix for legal chrome URL I'm picking jst here because he has reviewed some earlier patches. jst, this is a 1 line change to make the original fix actually work.

Attachment 172802 [details] [diff] was checked in by James - thanks! Can anyone verify the fix?

*** Bug 290104 has been marked as a duplicate of this bug. ***

Another instance of this bug or a dupe? bug 300296

*** Bug 300296 has been marked as a duplicate of this bug. ***

*** Bug 305889 has been marked as a duplicate of this bug. ***