Closed Bug 236304 Opened 21 years ago Closed 19 years ago

MacIE Profile Migrator

Categories

(Firefox :: Migration, defect, P2)

Product:
Firefox
Component:
Migration
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox1.5

People

(Reporter: bugs, Assigned: asaf)

References

Details

(Whiteboard: [l10n impact])

Attachments

(1 file, 3 obsolete files)

patch
(deleted), patch
jaas
: review+
mconnor
: superreview+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review
Status: NEW → ASSIGNED
Flags: blocking1.0+
Priority: -- → P2
Target Milestone: --- → Firefox1.0
Flags: blocking1.0+ → blocking1.0mac+
Target Milestone: Firefox1.0 → Firefox1.0Mac
Blocks: 265907
*** Bug 265907 has been marked as a duplicate of this bug. ***
*** Bug 268843 has been marked as a duplicate of this bug. ***
Blocks: 269451
moving blocking1.0mac bugs to Firefox1.1 Target Milestone.
Target Milestone: Firefox1.0Mac → Firefox1.1
*** Bug 271413 has been marked as a duplicate of this bug. ***
*** Bug 273122 has been marked as a duplicate of this bug. ***
No longer blocks: 265907
Blocks: macmeta
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Only imports Favorites. IE5 is getting on in years. Not that interested in
importing much else.
*** Bug 274764 has been marked as a duplicate of this bug. ***
Blocks: deermac
*** Bug 295273 has been marked as a duplicate of this bug. ***
Blocks: branching1.8
Blocks: 300861
No longer blocks: 300861
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Updated version of ben's patch.

changelog:
 * Update to tip.
 * Don't remove the BeOS system bookmark support (in case we actually want to
this, it shound't happen as a side effect of this bug).
 * Handle various failures
 * Use CopyUTF16toUTF8 instead of NS_ConvertUCS2toUTF8
 * use NC_URI

This is all about bookmarks, so asking vladimir to review.
Assignee: bugs → bugs.mano
Attachment #167999 - Attachment is obsolete: true
Attachment #189672 - Flags: review?(vladimir)
Flags: blocking1.8b4?
Whiteboard: [l10n impact][have patch]
Blocks: 300842
Comment on attachment 189672 [details] [diff] [review]
patch

r=vladimir, should get josh or someone to do an additional test on OSX
Attachment #189672 - Flags: review?(vladimir) → review+
Attachment #189672 - Flags: superreview?(joshmoz)
Attached patch patch (obsolete) (deleted) — — Splinter Review 
<sigh/> I forgot to diff the bookmarks service folder, asking for re-review.
Attachment #189672 - Attachment is obsolete: true
Attachment #189746 - Flags: superreview?(vladimir)
Attachment #189746 - Flags: review?(joshmoz)
Attachment #189672 - Flags: superreview?(joshmoz)
Flags: blocking1.8b4? → blocking1.8b4+
Attached patch patch (deleted) — — Splinter Review 
also missed migration.properties.
Attachment #189746 - Attachment is obsolete: true
Attachment #189925 - Flags: superreview?(vladimir)
Attachment #189925 - Flags: review?(joshmoz)
Attachment #189746 - Flags: superreview?(vladimir)
Attachment #189746 - Flags: review?(joshmoz)
Comment on attachment 189925 [details] [diff] [review]
patch

builds and works fine, doesn't seem to mess with anything else
Attachment #189925 - Flags: review?(joshmoz) → review+
vlad might be unavailable as he's on vacation, who else can superreview?

/cb
Whiteboard: [l10n impact][have patch] → [l10n impact][have patch, needs superreview]
Comment on attachment 189925 [details] [diff] [review]
patch

OK, asking mconnor.

Mike, vladimir has already reviewed the migrator code, I've asked for another
review since i've not diffed the old IE migrator stuff removal (the changes to
bookmarks/ in this patch).
Attachment #189925 - Flags: superreview?(vladimir) → superreview?(mconnor)
Comment on attachment 189925 [details] [diff] [review]
patch

Not having a Mac, I assumed this code was already dead, sadly I was wrong until
now!
Attachment #189925 - Flags: superreview?(mconnor) → superreview+
Attachment #189925 - Flags: approval1.8b4?
Whiteboard: [l10n impact][have patch, needs superreview] → [l10n impact][have patch, needs approval]
Flags: blocking-aviary1.0mac+
Attachment #189925 - Flags: approval1.8b4? → approval1.8b4+
checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [l10n impact][have patch, needs approval] → [l10n impact]
Blocks: 302230
QA Contact: marcia
No longer blocks: 269451
*** Bug 269451 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: