Closed
Bug 247116
Opened 20 years ago
Closed 18 years ago
Web pages bounce/shake/jump when "Bookmarks Toolbar Items" is empty and placed to right of menu bar
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
People
(Reporter: jayemery, Assigned: mossop)
References
Details
(Keywords: verified1.8.0.12, verified1.8.1.4, Whiteboard: For workarounds, see http://kb.mozillazine.org/Window_shakes)
Attachments
(5 files, 1 obsolete file)
(deleted),
application/x-zip
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mossop
:
review+
dveditz
:
approval1.8.1.4+
dveditz
:
approval1.8.0.12+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9
After modifying the toolbar and deleting all links, the webpage (html) would
start to move up and down rapidly.
Reproducible: Always
Steps to Reproduce:
1. I customized the toolbar by relocating the "Bookmarks Toolbar Items" up
beside the menus (immediately to the right of 'help').
2. Then I deleted all items in the bookarms toolbar (the three default links
after a fresh install).
3. I then went to a new website and the entire page (not the browser interface,
just the html) began to move 10 or so pixels up and down in half-second intervals.
4. Sometimes going to a new page would resolve the 'bouncing', but by minimizing
and maximizing the browser, the problem reoccured.
Actual Results:
The website would start moving up and down several pixels in half-second intervals.
Expected Results:
Displayed the webpage without the content moving.
This happened on a fresh install of Firefox, not 10 minutes after completing the
installation.
Comment 1•20 years ago
|
||
dupe of bug 254990 (although I realized this one was filed first)
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•20 years ago
|
||
*** Bug 254990 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Summary: Web pages 'bounce' when "Bookmarks Toolbar Items" is empty → Web pages bounce/shake when "Bookmarks Toolbar Items" is empty and placed to right of menu bar
Comment 3•20 years ago
|
||
same here... an easy fix would be to keep the size of the "bookmarks toolbar
items" constant ... right now it's like 2px or 3px smaller when nothing is in
there and that's probably why we see the jump (it jumps from empty-state size to
have-some-items-state size constantly)
Flags: blocking-aviary1.0?
Comment 4•20 years ago
|
||
*** Bug 259637 has been marked as a duplicate of this bug. ***
Comment 5•20 years ago
|
||
*** Bug 256792 has been marked as a duplicate of this bug. ***
Comment 6•20 years ago
|
||
*** Bug 259506 has been marked as a duplicate of this bug. ***
Comment 7•20 years ago
|
||
*** Bug 260179 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Assignee: bugs → vladimir
Flags: blocking-aviary1.0? → blocking-aviary1.0+
Asa, dbaron, and I spent a little while looking at this, and couldn't figure
anything out. This is probably a layout bug; someone who knows how our
layout/reflow works and knows how to debug it should probably look at it.
Comment 10•20 years ago
|
||
an easy solution for that: make the height of the bookmark toolbar items region
constant; right now when there is no icon, the height is unspecified, creating
the jumping behaviours ... if you place a defined height item (a button for
exemple) in the menu bar (where you have the menu and the bookmark toolbar
items), it'll stop jumping around.
the problem is not present in linux because the menu bar height == the height of
any other toolbar
Comment 11•20 years ago
|
||
*** Bug 257710 has been marked as a duplicate of this bug. ***
Comment 12•20 years ago
|
||
*** Bug 269605 has been marked as a duplicate of this bug. ***
Comment 13•20 years ago
|
||
the webpage is only shaking when firefox is not maximized
Updated•20 years ago
|
Attachment #167448 -
Attachment description: short movie of the shaking → short demonstration clip
Updated•20 years ago
|
Attachment #167448 -
Attachment description: short demonstration clip → short demonstration clip
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Comment 14•20 years ago
|
||
*** Bug 280449 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 15•20 years ago
|
||
I think the problem occurs even when no customisation of the toolbars has been
done. Yesterday I did a clean install of firefox and imported from IE, and was
given a bouncing start page. If that's what everyone sees when they import from
IE then this should be blocking 1.1
Comment 16•20 years ago
|
||
The reason this happens, as mentioned in comment 10, is that the menubar is
21px high, by default, while the bookmark toolbar is 23px high when it contains
items, and has no height (effectively 21px) when it doesn't. The resize watcher
toggles the .collapsed property of the chevron at each resize, which in turns
causes a resize event to fire, and we're stuck in a loop. Defining a minimum
height on the toolbar ensures that toggling the chevron's visibility doesn't
trigger a resize, at least not on XP using the default Luna theme (I don't
think it ever was a problem using the Classic theme). This is kind of an ugly
"fix", but I can't think of anything better, at least not at the moment.
Note that the rule can be added to userChrome.css to correct the problem in
current installs.
Comment 17•20 years ago
|
||
*** Bug 290979 has been marked as a duplicate of this bug. ***
Comment 18•20 years ago
|
||
*** Bug 291597 has been marked as a duplicate of this bug. ***
Comment 19•19 years ago
|
||
*** Bug 247032 has been marked as a duplicate of this bug. ***
Comment 20•19 years ago
|
||
*** Bug 296168 has been marked as a duplicate of this bug. ***
Comment 21•19 years ago
|
||
(In reply to comment #16)
> Created an attachment (id=180246) [edit]
> Workaround
>
> The reason this happens, as mentioned in comment 10, is that the menubar is
> 21px high, by default, while the bookmark toolbar is 23px high when it contains
> items, and has no height (effectively 21px) when it doesn't. The resize watcher
> toggles the .collapsed property of the chevron at each resize, which in turns
> causes a resize event to fire, and we're stuck in a loop. Defining a minimum
> height on the toolbar ensures that toggling the chevron's visibility doesn't
> trigger a resize, at least not on XP using the default Luna theme (I don't
> think it ever was a problem using the Classic theme). This is kind of an ugly
> "fix", but I can't think of anything better, at least not at the moment.
>
> Note that the rule can be added to userChrome.css to correct the problem in
> current installs.
Then that was why I was unable to reproduce this on bug 247032. I was using the
Classic theme (not Luna) when testing. You are correct in that it does /not/
reproduce using the classic theme. I, incidentally, had not even thought of
that as a variable in reproduction when testing previously.
Comment 22•19 years ago
|
||
*** Bug 296993 has been marked as a duplicate of this bug. ***
Comment 23•19 years ago
|
||
*** Bug 297135 has been marked as a duplicate of this bug. ***
Comment 24•19 years ago
|
||
*** Bug 298245 has been marked as a duplicate of this bug. ***
Comment 25•19 years ago
|
||
*** Bug 269173 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
QA Contact: bugzilla → toolbars
Comment 26•19 years ago
|
||
I can confirm this still occurs in the Firefox 1.5 Beta ("Mozilla/5.0 (Windows;
U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4").
I left the bookmarks toolbar in the original place, and it still occurs.
Strangely enough it also causes the unoffical googlebar's search listbox to also
shake the same way (I know Mozilla isn't reponsible for third-party extensions,
but thought I'd mention it for the googlebar users, since it's related). If the
"Bookmarks" item is removed from the toolbar (via customization) then it no
longer shakes. I can also confirm that it doesn't occur on the XP classic theme.
A plausible fix could be to set the "Bookmarks" item to a size, like the rest of
the buttons? I haven't looked at the source code, so I don't know what happens
"under the hood".
Daniel
Comment 27•19 years ago
|
||
Bug 178884 is essentially the same bug. This has been changed trunk&branch by
bug 243078, it shouldn't be an issue anymore.
Assignee: vladimir → nobody
Depends on: 178884
Comment 28•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
after some testing i can't reproduce this bug in FF 1.5 :)
could someone mark this bug as fixed?
Comment 29•19 years ago
|
||
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
I can confirm this still occurs in the Firefox 1.5, on Windows XP.
Reproducible: Always
Steps to Reproduce:
1. Right-click on the toolbar, click "Customize..."
2. Drag "Bookmarks Toolbar Items" to the space next to menu (right hand side of "Help"), then click "Done" to close the "Customize Toolbar" window.
3. In the menu, click "Bookmarks" -> "Manage Bookmarks..." to open Bookmarks manager
4. Delete all bookmarks in the "Bookmarks Toolbar Folder". Once you delete all bookmarks, you can see the webpage and the icon in the location bar shake immediately.
Actual Results:
The webpage would start moving up and down 1 pixel in half-second
intervals.
Expected Results:
the webpage should be displayed without moving.
This happened on a fresh install of Firefox 1.5.
Comment 30•19 years ago
|
||
This problem didn't occur when I used Windows 98SE uSP(unOfficialServicePack) 2.1a with FFox 1.5 20051216 installed over a previous version. I did find this bug a few months ago, but I used Firefox 1.4.1 then and didn't have the uSP installed. (In general, the win98se uSP contains all the M$ updates for 98, a few tweak tools and a Win2000 desktp scheme.)
Can someone please confirm this bug in Win 98Second/Standard Edition and/or Win 2000?
Comment 31•19 years ago
|
||
*** Bug 320905 has been marked as a duplicate of this bug. ***
Comment 32•19 years ago
|
||
i have the problem no mofications can't add enhancements and bouncing no matter what i do except for viewing the page in "full page mode"
Comment 33•19 years ago
|
||
*** Bug 325888 has been marked as a duplicate of this bug. ***
Comment 34•19 years ago
|
||
*** Bug 328349 has been marked as a duplicate of this bug. ***
Comment 35•19 years ago
|
||
*** Bug 330821 has been marked as a duplicate of this bug. ***
Comment 36•19 years ago
|
||
*** Bug 332455 has been marked as a duplicate of this bug. ***
Comment 37•19 years ago
|
||
*** Bug 332543 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
Flags: blocking-firefox2?
Updated•18 years ago
|
Severity: normal → minor
Flags: blocking-firefox2? → blocking-firefox2-
Comment 38•18 years ago
|
||
*** Bug 343381 has been marked as a duplicate of this bug. ***
Comment 39•18 years ago
|
||
*** Bug 343798 has been marked as a duplicate of this bug. ***
Comment 40•18 years ago
|
||
*** Bug 345004 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
Summary: Web pages bounce/shake when "Bookmarks Toolbar Items" is empty and placed to right of menu bar → Web pages bounce/shake/jump when "Bookmarks Toolbar Items" is empty and placed to right of menu bar
Comment 41•18 years ago
|
||
*** Bug 345209 has been marked as a duplicate of this bug. ***
Comment 42•18 years ago
|
||
*** Bug 346416 has been marked as a duplicate of this bug. ***
Comment 43•18 years ago
|
||
*** Bug 349386 has been marked as a duplicate of this bug. ***
Comment 44•18 years ago
|
||
*** Bug 354125 has been marked as a duplicate of this bug. ***
Comment 45•18 years ago
|
||
*** Bug 325573 has been marked as a duplicate of this bug. ***
Comment 46•18 years ago
|
||
*** Bug 354856 has been marked as a duplicate of this bug. ***
Comment 47•18 years ago
|
||
*** Bug 356679 has been marked as a duplicate of this bug. ***
Comment 48•18 years ago
|
||
*** Bug 356752 has been marked as a duplicate of this bug. ***
Comment 49•18 years ago
|
||
After upgrading to Vista RC2, browser window wobbles whenever I open Firefox. Does not occur with any other browsers.
Comment 50•18 years ago
|
||
*** Bug 358335 has been marked as a duplicate of this bug. ***
Comment 51•18 years ago
|
||
*** Bug 358342 has been marked as a duplicate of this bug. ***
Comment 52•18 years ago
|
||
As basically all the "jump" bugs get duped to this one, I can as well add a comment here...
We see something similar on OS/2, probably triggered in some way by the theme improvements of bug 314843 and bug 336997. Whenever the bookmarks overflow on the bookmarks toolbar and the chevron is shown, various parts of the displayed webpage or the UI can start to jump around. That happens even if the bookmarks toolbar is not placed onto the menubar.
If this makes somebody think of another bug than this one, please tell me.
Comment 53•18 years ago
|
||
*** Bug 338782 has been marked as a duplicate of this bug. ***
Comment 54•18 years ago
|
||
Comment on attachment 180246 [details] [diff] [review]
Workaround
No one requested review on this :( Hope it hasn't bitrotted.
Attachment #180246 -
Flags: review?
Updated•18 years ago
|
Attachment #180246 -
Flags: review?
Updated•18 years ago
|
Assignee: nobody → gavin.sharp
Comment 55•18 years ago
|
||
I noticed it does it after even opening the Bookmarks menu
Comment 56•18 years ago
|
||
(In reply to comment #54)
> (From update of attachment 180246 [details] [diff] [review] [edit])
> No one requested review on this :( Hope it hasn't bitrotted.
>
Seeing this all too often. Isn't there some automated way to find patches which have not been approved yet? Maybe bugzilla needs a better way to flag this/these.
Comment 57•18 years ago
|
||
I didn't ask for review on it because I didn't want anyone to review it.
Comment 58•18 years ago
|
||
*** Bug 361202 has been marked as a duplicate of this bug. ***
Comment 59•18 years ago
|
||
*** Bug 361194 has been marked as a duplicate of this bug. ***
Comment 60•18 years ago
|
||
*** Bug 361397 has been marked as a duplicate of this bug. ***
Comment 61•18 years ago
|
||
I'm shocked this serious bug has gone 2 years essentially unfixed. I've seen this happen to my and many others Firefox, and it often also seems to mess around with the bookmarks themselves, requiring a backup to be re-instated. Getting around it is not something the majority of users should have to, or would do, thus this is ridding of users and frustrating many others persevereing.
This needs to be looked at broadly in terms of why are users customising the user face in this way? To move the bookmarks toolbar to somewhere else where space is available, to better use interface space. Not only is this only possible in an un-usual way of not moving the toolbar itself but turning it off, but it create issues such as this, with something as basic as the customise interface function.
Solution 1: When approx 10% of internet users use bookmarks, and increasing amounts search and other, an entire bookmarks toolbar un-necessary clutter to an approximate 90% majority, and even some of the 10% whom even use bookmarks in this modern day of the web. Firefox is for the majority yet the only browser forcing an entire un-necessary toolbar on a majority whom dont use it, so turn it off, keep Firefox simple and for the majority, not with the most toolbars and clutter than other browsers with a more simple less cluttered UI.
Solution 2. As per comment 10, the width of the toolbar is variable, if it wasn't, problem fixed, or at least close to.
This needs increased efforts to actually deal with this bug in one of the above ways, or others some noted in comments above. 2 years is too long for such a bug that I've witnessed effecting many.
Comment 62•18 years ago
|
||
I had been using Firefox 1.5 for a little less than a month in Mac OS 10.4 and XP. However, when I switched my XP installation to the Vista RC1 (Build 5600), FF 1.5 began jumping, as described by many others. The problem usually occurs when I hit CTRL+F to perform a find, but also is already jumping most of the time when the browser is initially opened.
Comment 63•18 years ago
|
||
*** Bug 363913 has been marked as a duplicate of this bug. ***
Comment 64•18 years ago
|
||
I removed the bookmarks toolbar and it stopped.
Comment 65•18 years ago
|
||
my FF V.2 is jumping from i start the browser until i close it... bookmark/no bookmark don´t matter and i have reinstalled it more that 3 times...
Comment 70•18 years ago
|
||
nominating for the next release. Vista users are hitting this quite a bit, and would be a win since the behavior will drive people away from using the browser.
Flags: blocking1.8.1.3?
Comment 72•18 years ago
|
||
Marcia is right, im going to stop using Firefox for a while.
Bookmarks dont seem to affect my jumping, just happens randomly for me, when page is maximised or not, full size or not, loads of tabs 1 tab, bookmarks, no bookmarks.
I've had this problem before when installing certain themes on windows xp using windowsblinds, such as the emerance or w/e theme, made it jump.
im on vista atm and it jumps randomly, right now it isnt. and now i just closed 1 tab and clicked another it is starting to bounce. Open a new link in a new tab and close previous tab, stops jumping.
Seems weird XD
Comment 73•18 years ago
|
||
sion: Can you please reply with your build ID (type about: in the URL bar). I thought most of the people that were having that issue were hitting the "no bookmarks in the toolbar issue." Also, note any themes and extensions you have installed as well since I will try my best to repro this on Vista. thanks.
(In reply to comment #72)
> Marcia is right, im going to stop using Firefox for a while.
>
> Bookmarks dont seem to affect my jumping, just happens randomly for me, when
> page is maximised or not, full size or not, loads of tabs 1 tab, bookmarks, no
> bookmarks.
>
> I've had this problem before when installing certain themes on windows xp using
> windowsblinds, such as the emerance or w/e theme, made it jump.
>
> im on vista atm and it jumps randomly, right now it isnt. and now i just closed
> 1 tab and clicked another it is starting to bounce. Open a new link in a new
> tab and close previous tab, stops jumping.
>
> Seems weird XD
>
Comment 74•18 years ago
|
||
Build identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.8.1.1) Gecko/2006120418 Firefox/2.0.0.1
Still doing it at random times. For example.
Open Up Firefox (not jumping)
load Hotmail (not jumping)
Login to hot mail (starts jumping)
go into inbox (jumping)
Click the email link for this page in new tab (stops jumping)
Close hotmail tab (starts jumping)
Comment 75•18 years ago
|
||
sion: it was reported on http://forums.mozillazine.org/viewtopic.php?t=478782 that windows blind can also cause this problem.
Does this window shaking/jumping also occur when you turn off windows blind ?
Comment 76•18 years ago
|
||
I dont know if windows blinds works on Vista, and I wouldnt use it on Vista anyway, but im on vista. I am not using windows blinds, I just stated that previously when I have had windows blinds it jumped on certain themes, but most like 9/10 I've tried, it didn't jump for me.
If I didn't have windows blinds, it never shakes, ever.
Comment 80•18 years ago
|
||
I can confirm this bug on Vista 32-bit, with my bookmarks toolbar folder empty. Very annoying.
Comment 81•18 years ago
|
||
Weather it is empty or not, you will still get this.
Comment 82•18 years ago
|
||
If you're seeing this and the bookmark toolbar is not empty, you're seeing a different bug (probably bug 221604).
Comment 83•18 years ago
|
||
Yes, I can confirm that I only get the bounce with the toolbar *empty*.
Comment 84•18 years ago
|
||
Are you guys on Windows Vista?
I'm using Vista, I added bookmarks to toolbar and it still continues to bouce, but it isnt doing it as much :S maybe im tired.
I checked the site out Gavin, some of the dates go back along time, but I will have a thorough read.
Thank you.
Comment 85•18 years ago
|
||
Yeap I am on Vista and I was so upset by the whole thing I just started using another browser while we figure out a fix. I tried everything,, even re-install!
Comment 86•18 years ago
|
||
I was told by a friend to edit some stuff on the config (about:config) and that didnt fix it, nore did it mess it up any other way (or so i thought)
I did an reinstall cuse I hadn't tried to and I thought there was no point reinstalling if I never knew what the actual problem was.
I reinstalled and it still bounced, so starting from scratch I right click the bookmark area and add a book mark and it doesnt bounce no more.
I must of messed up my about:config? or maybe my vista is messed up a little because I had to do a repair as Nero for vista wouldn't work cuse of currupt install.
Cheers.
Updated•18 years ago
|
Whiteboard: For workarounds, see http://kb.mozillazine.org/Window_shakes
Comment 87•18 years ago
|
||
There is no about:config setting that will fix this bug.
Comment 88•18 years ago
|
||
This is happening to me on Linux, too, when I drag the bookmarks toolbar items from the actual bookmarks toolbar to the top menu bar, right of the help menu, and then shrink the Firefox window so that it is so small that no bookmarks actually show up. When I enlarge it again so that at least one bookmark shows up, the bouncing stops.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.2) Gecko/20060601 Firefox/2.0.0.2 (Ubuntu-edgy)
Comment 89•18 years ago
|
||
I noticed this happening after Firefox downloaded the 2.0.0.2 update. I uninstalled Firefox and reinstalled a fresh copy (no customizations whatsoever) and the problem continued. I only use Firefox as a testing platform, so I pretty much stick with the defaults (except for making it automatically dump its cache/cookies/etc and not save browser history) and therefore my bookmarks toolbar is empty, as described above, but has not been moved from it's default location (below the navigation toolbar).
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Description: Vista x64 Ultimate (fully patched).
Background Processes (other than standard Windows components):
Kaspersky AV 6.0.2.614 (fully patched)
uTorrent 1.6.1
Virtual DAEMON Manager V4.08HE
ATI Catalyst Control Center 7 (0122.1848.2579.33475)
Comment 90•18 years ago
|
||
Please note that this is not platform or OS dependent, this should not be assigned to PC/Windows. I get it on all different OSs.
Also, the Bookmarks Toolbar needs not be "empty", if the window is too small to fit any bookmarks in the toolbar, this still happens.
It also doesn't need to be placed right to the menu bar, happens when it's in the default location, too. Please change the title.
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
Comment 91•18 years ago
|
||
same here
if u delete the bookmark and the live news ,it happens like that then i added show book marks icon from the toolbar ( customize ) it works normally
Comment 92•18 years ago
|
||
I twould suggest that the status of this bug should be at least normal, not minor, since it is very visible, and completely inhibits the use of firefox by the bug's "victims".
Updated•18 years ago
|
Severity: minor → normal
Assignee | ||
Comment 94•18 years ago
|
||
Extremely simple fix. If there are no bookmarks in the toolbar, then collapse the chevron and bail. This stops the resize loop.
This patch is against trunk, but the same fix will work against branch which is where ideally this could go to.
Assignee: gavin.sharp → mossop.bugzilla
Status: NEW → ASSIGNED
Attachment #258855 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 95•18 years ago
|
||
Per discussion on IRC, clear _overflowTimerInEffect at the start of resizeFunc to cover all early return cases.
Attachment #258855 -
Attachment is obsolete: true
Attachment #258860 -
Flags: review?(gavin.sharp)
Attachment #258855 -
Flags: review?(gavin.sharp)
Comment 96•18 years ago
|
||
I was having this same problem, and it was driving me crazy. I really didn't want to have to go back to IE. But look at this logically... If it was working before we deleted the links out of the 'Bookmarks Toolbar Folder', and it started screwing up after that, the solution is clear. Just put some links back in the folder, and put it back in its original location in the drop down menu. They don't have to be the same ones that were deleted, and you don't have to switch back to Windows Classic. I'm on Vista, and it's working fine for me. I've gone through all my links, and not a single jumping page since I've replaced the links. I've minimized windows, reopened, and opened new tabs. Everything's fine.
Comment 97•18 years ago
|
||
Comment on attachment 258860 [details] [diff] [review]
patch rev 2
Ideally we could, in addition to this, do something like the first patch, to avoid the "jump" when adding a bookmark to a blank bookmark toolbar, but the unpredictability of the native theming code means that any min-height value we'd hard code would be a hack. Thanks for taking this.
Attachment #258860 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: For workarounds, see http://kb.mozillazine.org/Window_shakes → [needs checkin] For workarounds, see http://kb.mozillazine.org/Window_shakes
Updated•18 years ago
|
Whiteboard: [needs checkin] For workarounds, see http://kb.mozillazine.org/Window_shakes → [checkin needed] For workarounds, see http://kb.mozillazine.org/Window_shakes
Comment 98•18 years ago
|
||
mozilla/browser/components/bookmarks/content/bookmarksMenu.js 1.57
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] For workarounds, see http://kb.mozillazine.org/Window_shakes → For workarounds, see http://kb.mozillazine.org/Window_shakes
Assignee | ||
Comment 99•18 years ago
|
||
This is an identical patch but against branch so carrying over review.
Pretty much no risk as far as I'm concerned and would resolve a fairly popular support issue.
Attachment #259537 -
Flags: review+
Attachment #259537 -
Flags: approval1.8.1.4?
Assignee | ||
Updated•18 years ago
|
Attachment #259537 -
Flags: approval1.8.0.12?
Comment 101•18 years ago
|
||
Comment on attachment 259537 [details] [diff] [review]
Branch version of patch
approved for 1.8.0.12/1.8.1.4, a=dveditz for release-drivers
Attachment #259537 -
Flags: approval1.8.1.4?
Attachment #259537 -
Flags: approval1.8.1.4+
Attachment #259537 -
Flags: approval1.8.0.12?
Attachment #259537 -
Flags: approval1.8.0.12+
Updated•18 years ago
|
Flags: blocking1.8.1.4? → blocking1.8.1.4+
Assignee | ||
Updated•18 years ago
|
Whiteboard: For workarounds, see http://kb.mozillazine.org/Window_shakes → [checkin needed (1.8 and 1.8.0 branch)] For workarounds, see http://kb.mozillazine.org/Window_shakes
Comment 105•18 years ago
|
||
browser/components/bookmarks/content/bookmarksMenu.js: 1.48.2.6.2.1
Keywords: fixed1.8.0.12
Whiteboard: [checkin needed (1.8 and 1.8.0 branch)] For workarounds, see http://kb.mozillazine.org/Window_shakes → [checkin needed (1.8 branch)] For workarounds, see http://kb.mozillazine.org/Window_shakes
Comment 106•18 years ago
|
||
browser/components/bookmarks/content/bookmarksMenu.js: 1.48.2.10
Keywords: fixed1.8.1.4
Whiteboard: [checkin needed (1.8 branch)] For workarounds, see http://kb.mozillazine.org/Window_shakes → For workarounds, see http://kb.mozillazine.org/Window_shakes
Comment 109•18 years ago
|
||
I"m Having problems installing fire fox Update,It keeps asking to install every time I go on the internet and doesn"t install ,Just repeats every time
Comment 110•18 years ago
|
||
(In reply to comment #109)
> I"m Having problems installing fire fox Update,It keeps asking to install every
> time I go on the internet and doesn"t install ,Just repeats every time
>
what version of firefox are you currently using? what you might seeing is bug 351949
Comment 111•18 years ago
|
||
The version of Fire fox ,its trying to install is Firefox 2.0.0.3
Comment 113•18 years ago
|
||
(In reply to comment #112)
> *** Bug 377508 has been marked as a duplicate of this bug. ***
>
So is that Problem Solved Now,I may Have send you an email,Just ignore it,simon,thankyou
Comment 115•18 years ago
|
||
(In reply to comment #114)
> *** Bug 377974 has been marked as a duplicate of this bug. ***
>
Comment 116•18 years ago
|
||
(In reply to comment #115)
> (In reply to comment #114)
> > *** Bug 377974 has been marked as a duplicate of this bug. ***
> >
> Still Have problem with firefox,Still Repeating installed Updates
Comment 117•18 years ago
|
||
Simon: this bug has absolutely nothing to do with repeated updates, and Bugzilla is the wrong place to look for user support. Please use http://forums.mozillazine.org/viewforum.php?f=38 instead.
Comment 120•18 years ago
|
||
verified fixed on the 1.8 branch using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.4pre) Gecko/2007050804 BonEcho/2.0.0.4pre. I tested with Win Vista Home Basic. No bounces or shakes observed. I also checked on Mac as well, since this bug was cross platform, and things look good there as well. adding branch keyword.
Keywords: fixed1.8.1.4 → verified1.8.1.4
Comment 123•18 years ago
|
||
well in my case it has nothing to do with the bookmarks/tool bars, even typing in a web address and the damn page constantly bounces it's annoying, has anyone actualy got a fix for this instead of having to read thru every line in which gives no indecation of a fix just indecates more problems
Comment 128•18 years ago
|
||
verified fixed 1.8.0.12 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US;
rv:1.8.0.12) Gecko/20070508 Firefox/1.5.0.12 with the steps to reproduce from
this bug and the Mozillazine KB Article.
No window bounce/shake/jump -> adding verified keyword
Keywords: fixed1.8.0.12 → verified1.8.0.12
Comment 130•17 years ago
|
||
I wouldn't consider this issue resolved. My wife just upgraded Firefox to version 2.0.0.4 and started getting the shakes described in this bug, which didn't exist before. Her bookmarks toolbar is enabled and has bookmarks in it. She also has the Yahoo Toolbar installed. If she uses the default theme, then she doesn't experience the shakes. If she uses the Pink Paula theme, then she gets the shakes. Nothing else has changed. I'm not sure if this issue has to do with the Pink Paula theme or not, but the description is exactly what happens on her laptop.
Assignee | ||
Comment 131•17 years ago
|
||
(In reply to comment #130)
> I wouldn't consider this issue resolved. My wife just upgraded Firefox to
> version 2.0.0.4 and started getting the shakes described in this bug, which
> didn't exist before. Her bookmarks toolbar is enabled and has bookmarks in it.
> She also has the Yahoo Toolbar installed. If she uses the default theme, then
> she doesn't experience the shakes. If she uses the Pink Paula theme, then she
> gets the shakes. Nothing else has changed. I'm not sure if this issue has to
> do with the Pink Paula theme or not, but the description is exactly what
> happens on her laptop.
>
This bug is about the shaking occurring when the bookmarks toolbar is empty so what you are seeing is clearly different, possibly bug 178884. If it is not that I would suggest either consulting with the Pink Paula theme author or filing a new bug.
Comment 134•17 years ago
|
||
(In reply to comment #1)
> dupe of bug 254990 (although I realized this one was filed first)
>
I'm using firefox 2.0.0.4. Every time I boot up it wants to install 2.0.0.4 again. I say "later". As part of this problem, I think, my screen bounces or shakes when I go from page to page. Any idea what this is?
Bill
Comment 135•17 years ago
|
||
I'm using Mozilla Firefox 1.5.0.8 (jus updated to 1.5.0.12) and ever since I have installed the browser, it starts this action of jumping/dancing/shaking and just does not stop. even tabs act similarly. it stabilises for a a few seconds when I want to attach a file in emails, but after I am done attaching it starts this weird behaviour all over again. Help!
On Windows XP SP2 and no themes installed, only a google toolbar.
June
Comment 136•17 years ago
|
||
Windows XP Professional* SP2. there! its begun shaking again :(
This is a fresh install after I uninstalled Firefox 2.0 thinking there was something wrong with the browser. However, 1.5.0.8 shows the same bouncing up and down behaviour as I write this.
23 June 2007
Assignee | ||
Comment 137•17 years ago
|
||
This is an equivalent patch applied to the places bookmarks toolbar.
Attachment #269862 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #269862 -
Flags: review? → review?(mano)
Comment 138•17 years ago
|
||
Comment on attachment 269862 [details] [diff] [review]
places version of patch
r=mano.
Attachment #269862 -
Flags: review?(mano) → review+
Assignee | ||
Comment 139•17 years ago
|
||
Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v <-- toolbar.xml
new revision: 1.94; previous revision: 1.93
done
Comment 141•17 years ago
|
||
I fooled around with the toolbars and wound up with, from top to bottom, nav., bookmarks and Google and that seemed to do it. Keeping my fingers crossed.
Comment 142•17 years ago
|
||
Jason, as bug reporter, can you verify?
Comment 143•17 years ago
|
||
whats up with this non working script message? whenever I go onto any YouTube channel this pops up:
a script on this page may be busy, or it may have stopped responding. you can stop the script now, or you can continue to see if the script will complete.
LAME!!! Help me immediately.. not as a threat to you.. but im thinking about going back to Internet Explorer..
(In reply to comment #143)
> whats up with this non working script message? whenever I go onto any YouTube
> channel this pops up:
> a script on this page may be busy, or it may have stopped responding. you can
> stop the script now, or you can continue to see if the script will complete.
> LAME!!! Help me immediately.. not as a threat to you.. but im thinking about
> going back to Internet Explorer..
That has absolutely nothing to do with this bug.
Please see http://kb.mozillazine.org/Script_busy_or_stopped_responding
Comment 145•16 years ago
|
||
it's shakeing again in firefox 3.0.1
Comment 150•16 years ago
|
||
This issue is not "fixed" Ever since Firfox (Firefox/3.0.10) was released I periodically have the constant jumping up and down. I have checked my video card and drivers and can find nothing wrong. With the thousands of people reporting this problem I would think Mozilla would take a better look at this. I like Firefox but it looks like I may have to switch back to IE.
Comment 151•15 years ago
|
||
Using 3.0.11. My bookmarks toolbar is not empty but it is placed in the top right of the menubar and exhibiting the same symptoms. This very page is twitching right now.
Comment 152•15 years ago
|
||
I got the jumping when i first upgraded to 3.5.1 and clicked "Release Notes" on the Mozilla page
Comment 153•15 years ago
|
||
The problem still exists in 3.0.13. It's not fixed.
Comment 154•15 years ago
|
||
(In reply to comment #153)
> The problem still exists in 3.0.13. It's not fixed.
For workarounds, see http://kb.mozillazine.org/Window_shakes
and how about when using Firefox 3.5.2. Also, open a new bug if you can confirm that this problem exists using the latest firefox (3.5.2) and if you can reproduce this problem with your extensions disabled.
Comment 155•15 years ago
|
||
My tollbar is http://riyac.ourtoolbar.com/ and don't works.
Comment 157•14 years ago
|
||
Updated•10 years ago
|
Flags: blocking1.8.1.4+
Flags: blocking-firefox2-
Flags: blocking-aviary1.0-
You need to log in
before you can comment on or make changes to this bug.
Description
•