Using this bug number to track the incremental theme changes that I will be making to the default theme("Winstripe").

Updates to toolbar icons. Go, History, Downloads, New Window, New Bookmark Folder, and most notably a tab that hopefully doesn't look like a toaster to some people.

are matching changes also going to be made to pinstripe?

Why does the Go icon still have text attached to it, while for all other icons the text is optional?

(In reply to comment #2) > are matching changes also going to be made to pinstripe? We haven't discussed that yet. Some elements may flow back and forth.

(In reply to comment #3) > Why does the Go icon still have text attached to it, while for all other icons > the text is optional? That is a good question. It has always been that way, but I don't see any reason that is should stay that way. There may have been some rational behind it that I am not aware of.

(In reply to comment #5) > (In reply to comment #3) > > Why does the Go icon still have text attached to it, while for all other icons > > the text is optional? > > That is a good question. It has always been that way, but I don't see any reason > that is should stay that way. There may have been some rational behind it that I > am not aware of. I have to agree with comment #3; I don't think the text should be attached to the Go icon. Having the text attached to it creates an additional UI issue as well, namely that all text appears below the icons when turned on, except for Go, where it stays to the right of the icon. Nice & inconsistent. However, I assume this behavior was done to mimic IE, which doesn't follow any sort of UI standard for the Go button. The text for the Go button always appears in IE, and always appears to the right, regardless of how your toolbars are configured. So, separating the two might be a far bigger issue, especially if people are used to the text on the right for only that button in IE. It would be nice to have a hidden pref to turn text off, or something like that, but that's getting a little too far out there. Maybe it's the job for an extension.

Maybe a stoplight kind of idea with Stop and Go INSIDE the button would be better. Make the buttons real big at the same time. The yellow (Proceed With Caution) could be for secure sites somehow.

The 'attached' text of the Go button might be due to the fact that it's only a button, *not* a toolbar button, So it doesn't need to function like one, with text/icons/text and icons modes.

See bug 235277 and bug 225088, which was WONTFIXED, for those Go button issues. Stephen, i'm not sure if you're handling both image and css issues and make decisions on things, but can you take a look at bug 235300 about the bookmarks toolbar items object, which rebroke at some point in the conversion to Winstripe?

I guess this might also be the place to add comments about the "x" to close tabs and to close the search bar. That "x" is too small. Thanks.

(In reply to comment #10) > I guess this might also be the place to add comments about the "x" to close tabs > and to close the search bar. That "x" is too small. > > Thanks. Please keep comments about the close button to the bug for the close tabs button. Also it is not too small, it is fine, and it won't be changing in size.

(In reply to comment #11) > (In reply to comment #10) > > I guess this might also be the place to add comments about the "x" to close tabs > > and to close the search bar. That "x" is too small. > > > > Thanks. > > Please keep comments about the close button to the bug for the close tabs > button. Also it is not too small, it is fine, and it won't be changing in size. Here is one bug for that that I've found: http://bugzilla.mozilla.org/show_bug.cgi?id=245806 The size is WAY too small. ;-)

With the latest checkin to center the toolbar icons on their "buttons" on 08/05/2004 19:55 there is significant improvement. It does appear that the "reload" icon is still slightly off-center to the left by approx 2 pix. The "print this page" also appears slightly off-center to the right by approx 1 pix.

(In reply to comment #13) > With the latest checkin to center the toolbar icons on their "buttons" on > 08/05/2004 19:55 there is significant improvement. > > It does appear that the "reload" icon is still slightly off-center to the left > by approx 2 pix. The "print this page" also appears slightly off-center to the > right by approx 1 pix. I thought that about several of them, but I think it is just an optical illusion. Probably caused by the 2 pixels of space reserved for the drop-shadow on the right and bottom within the icon image itself.

(In reply to comment #13) > With the latest checkin to center the toolbar icons on their "buttons" > on 08/05/2004 19:55 there is significant improvement. I've been trying to figure out the reason for that for a few weeks now. See bug 215839 comment #27. That browser.css update seems to "fix" that problem, but i don't understand why that toolbarbutton.css rule is there to begin with. The only thing i can think of is for spacing in between bookmark icons and their labels. And if that's the case, then there's a more specific rule that can deal with that, and not screw up all the other buttons. I also don't really understand the margin-right on .toolbarbutton-menubutton-buttons. Depending on how bug 226274 gets fixed, that might screw with the edge between the menubuttons and dropmarkers.

I don't know if this is the right place to post, but I have a suggestion for enhancement on Winstripes. If you look at the bottom right corner where the additional status icons reside, You'll find that space is allocated for Security icon, Popup blocked icon, Stylesheet icon, Livemark icon, and Live update Icon. However, when the icons are not present, there are still tooltips for each of them and all of them are clickable. So my suggestion is that when the icons are not active (visible), there should be a greyed-out/inactive version of the icon in-place to to indicate the funcionality.

(In reply to comment #16) This is a good observation, and something I have been thinking about myself. I am going to try and get to the bottom of the intended behaviour and go from there.

A few days late, here are shots of the updated bookmark sidebar icons.

I'm wondering about the new page-livemarks.png, is it a good idea to emphasize (or call it prefer) RSS over ATOM like that?

(In reply to comment #16) This is bug 251821. (In reply to comment #19) This is bug 256088.

Could you guys take a look at bug 222799? It deals with the text on the options and privacy panels being unreadable with certain system colors. We've had a patch for some time, though the developers haven't touched it (not that I blame them). Since this is your department, I thought I'd check here.

its a tracking bug, blocking means nothing since its an ongoing bug with no set issue to fix.

Updated Bookmark Manager Toolbar icons to match updated Theme style.

Updating Print icon, as well as tweaks to Cut/Copy/Paste icons.

Hiya, two comments. Firstly I prefered the old printer icon. I think this new one is too dark especially in small icons mode. Also with regards to the new "Web Features" icon (globe on America), I was under the impression FF was meant to be using this non-Earth globe like in the about dialogue screen to stop the moaners. (I couldn't care less myself but we still get the *OMG OMG YOUR LOGO HAS RED YOU ARE COMMUNISTS* crowd appearing ever so often)

(In reply to comment #26) > Also with regards to the new "Web Features" icon (globe on America), I was under > the impression FF was meant to be using this non-Earth globe like in the about > dialogue screen to stop the moaners. (I couldn't care less myself but we still > get the *OMG OMG YOUR LOGO HAS RED YOU ARE COMMUNISTS* crowd appearing ever so > often) I totaly agree about the globe. Why is it showing America??? It certainly shouldn't.

(In reply to comment #27) > I totaly agree about the globe. Why is it showing America??? It certainly shouldn't. Because North America and South America are continents on the planet Earth? I don't really have the time to appease people's sense of political correctness. What would you have me put on it that wouldn't offend someone? Something has to be on there, complaining about something like that is just silly. Not to mention that is had been like that for months.

Did the Find Toolbar closer button get moved recently in the latest nightlies as of my guess 0ct 16th (The 1.0 maxversion change)? Because I use the MOOX nightlies and the last two he's done 17th and 18th the closer button is on the far left instead of being on the far right as it usually has been. This also affects my themes because Noia eXtreme Theme can not show the new button placement but in the default Firefox Theme the Findbar closer button is visible and on the leftmost side of the findbar.

depends on 244691?

Winstripe is dead.....

This should be more a wontfix. Even its a tracking bug no other bugs were added to the dependency list and no patches given. That will never change anymore. RIP...