File | New Bookmark should create a new bookmark inside a folder, if one is selected. If a folder is selected and you paste a bookmark, then the bookmark should be filed inside the selected folder. Right now, there seems to be no way to actually get bookmarks into a folder. To reproduce: 1. Manage Bookmarks 2. Create new folder 3. Select folder 4. File | New Bookmark Actual result: a new bookmark appears at the end of the bookmark list. Expected result: the new bookmark should be filed inside the new folder. 5. Select new bookmark 6. Edit | Cut 7. Select new folder 8. Edit | Paste Actual result: Bookmark reappears at end of list Expected result: bookmark is moved into new folder Linux build 2000.02.11.11

*** Bug 28509 has been marked as a duplicate of this bug. ***

It appears that the same issue was already reported as bug 20073, "Context menu should add item to selected folder", P2, M15.

*** Bug 20073 has been marked as a duplicate of this bug. ***

this is technically fixed. If you select a folder and paste or create a new bookmark, the bookmark will go inside. I contend that this is wrong and should only be the case when the folder is open/expanded because now you can't create/paste below the folder, but rjc disagrees with me and that is the subject of bug 28853. I'm going to mark this fixed and verified

VERIFIED with 2000022209 builds

> If you select a folder and paste or create a new bookmark, the bookmark will > go inside. I don't see that happening. When I select a folder (it's a folder inside my personal toolbar folder), and create a new bookmark, the new bookmark becomes a peer of the folder, not a child. Reopening the bug. (I'm using 2000-02-23-08 on NT)

My bad. As it turns out some more careful QA shows us that the behavior is different for paste vs. create new bookmark. cc'ing rjc as I believe it's his code that fixed the paste as peer(instead of nesting) bug so this would be the same thing except it's create instead.

m19

Reassigning 79 Bookmarks bugs to Ben. I was told this was going to be done shortly about two months ago, but it clearly hasn't been. I think that's long enough for all these bugs to remain assigned to nobody. Feel free to filter all this spam into the trashcan by looking for this string in the message body: ducksgoquack

*** Bug 59946 has been marked as a duplicate of this bug. ***

*** Bug 59946 has been marked as a duplicate of this bug. ***

Ben, please take a look at this patch so it doesn't get lost.

Netscape Nav Triage Team: adding german to the cc list - we need UE help.

*** Bug 59948 has been marked as a duplicate of this bug. ***

If this was fixed, with the current UI there would be no way to create a new item at the top level in a window where the only current top-level items were folders, and where the list of folders was larger than the window -- because there would always be a folder selected, and there would be no way to deselect it without selecting another one. That problem could be fixed in any of three ways: (1) only make new bookmarks go into the selected folder if the folder is expanded; (2) implement drag-selection of multiple tree items (bug 48912), which would require that tree items would be deselected if the user moused down outside the actual text of the item (but even that wouldn't work for people who couldn't use a pointing device); (3) return 4.x's `Bookmarks for Jane Doe' root folder to Seamonkey's bookmarks window (as I suggested in bug 28853), so the user could select the top-level folder in order for new items to go at the top level.

I like (3), mpt do you want to file an RFE for it?

(3) works for me too, and is analogous to the organization of mail folders.

Ugh. I suck. Sorry for letting this one sit so long, guys. I need the nsBookmarksService.cpp part of this patch now, as I'm rewriting the bookmarks window and want this functionality. The js code for the bookmarks window has mostly changed in my tree however so I'll rework your js to make it work with my code. As for mpt's comments, yes I believe there should be a root folder. After I'm done with my core bookmarks tasks, I'm going to investigate this. btw: after my bookmarks checkin dragging of multiple items will be possible again.

(3) was long ago suggested and solves a number of other problems as well. There is an RFE or bug floating around in bugzilla somewhere asking for a root bookmarks folder.

Bug 36339 : bookmark manager needs a root level. (That's marked as WONTFIX though...)

(3) is the most sensible way for me as well

Patch checked in.

for pete's sake, now with a 2001041004 build on Win98, if I File|New Bookmark with a closed folder selected and enter a name and location in the dialog and just click 'OK' the new bookmark is created inside the folder as the last child. However, if I cut a bookmark and selecta closed folder context menu-->paste results in the bookmark being pasted below the folder as a peer. Reopening.

nav triage: downgrading to P2, paul wants to take this bug so reassigning to him.

pchen, please r. alecf, please sr. Thanks!

coolness. sr=alecf

Samir, you stud you! r=pchen

Fix checked in.

samir's patch fixes the last remaining issue in this bug - namely that creating a new bookmark with a folder selected now creates the bookmark inside that folder. I'm marking this VERIFIED Fixed with 2001050403 builds even though i still contend that this approach is all wrong. I still believe pasting/creating onto a closed folder should paste/create as peer and on an open folder should paste/create as child. In this way we maintain all the same abilities w/o relying on D&D. With the current setup one can _never_ place a bookmark between two folders without using D&D.

"However, if I cut a bookmark and selecta closed folder context menu-->paste results in the bookmark being pasted below the folder as a peer. Reopening." Claudius, I may have misinterpreted your comments above which sounded like context menu paste was the erroneous behavior. Were you suggesting that File|New Bookmarks behavior should be like context menu paste instead of the other way around? It was not clear to me. If this is correct and per the spec then I can change the behavior accordingly. Please help me understand the issue by clarifying as I ramp up on this part of the product. Thanks.