Closed
Bug 285529
Opened 20 years ago
Closed 18 years ago
Option-forward delete does not work in page text input fields
Categories
(Camino Graveyard :: HTML Form Controls, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: danielwilson, Assigned: uriber)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
(deleted),
patch
|
aaronlev
:
review+
bzbarsky
:
superreview+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050304 Camino/0.8+
Pressing Option-forward delete should delete the word to the right of the cursor.
Reproducible: Always
Steps to Reproduce:
1. Input text into a page form.
2. Position the text input cursor to the immediate left of a word.
3. Press Option-forward delete.
Actual Results:
Error beep.
Expected Results:
The word to the immediate right of the cursor should be deleted.
Yup I can confirm.
Status: UNCONFIRMED → NEW
Component: General → HTML Form Controls
Ever confirmed: true
Target Milestone: --- → Camino1.2
Comment 2•19 years ago
|
||
Do we have any idea why this might be happening? This would be really nice polish for 1.0 if someone can come up with a patch fairly quickly. I'd be willing to give it a shot if someone can point me in the right direction.
It's probably platformHTMLBindings (or whatever that file is called), so it can't make 1.0. Wevah, Simon, is that right?
See also bugs like bug 299565, bug 188602, bug 175620.
Comment 4•19 years ago
|
||
Yeah, I'm pretty sure that's the case. As usual, we don't get it for free since it's not a real OS X text field.
Comment 5•19 years ago
|
||
Would that be this file?
http://lxr.mozilla.org/mozilla/source/content/xbl/builtin/mac/platformHTMLBindings.xml
cl
Assignee | ||
Comment 6•18 years ago
|
||
This is an issue with Firefox as well. Should I report a separate bug, or is this one really a core bug?
Comment 7•18 years ago
|
||
That file, as I understand it, gets pulled into both Camino and Firefox, so when it's fixed, it'll be fixed in both instances, I think.
cl
Assignee | ||
Comment 8•18 years ago
|
||
Attachment #228952 -
Flags: review?(aaronleventhal)
Updated•18 years ago
|
Attachment #228952 -
Flags: review?(aaronleventhal) → review+
Updated•18 years ago
|
Assignee: mikepinkerton → uriber
QA Contact: form.controls
Target Milestone: Camino1.2 → Camino1.1
Assignee | ||
Updated•18 years ago
|
Attachment #228952 -
Flags: superreview?(bzbarsky)
Comment 9•18 years ago
|
||
Comment on attachment 228952 [details] [diff] [review]
patch
Looks reasonable. sr=bzbarsky
Attachment #228952 -
Flags: superreview?(bzbarsky) → superreview+
Comment 10•18 years ago
|
||
We should get this on the trunk before requesting branch approval.
Whiteboard: [checkin needed]
Assignee | ||
Comment 11•18 years ago
|
||
Checked in:
Checking in content/xbl/builtin/mac/platformHTMLBindings.xml;
/cvsroot/mozilla/content/xbl/builtin/mac/platformHTMLBindings.xml,v <-- platformHTMLBindings.xml
new revision: 1.18; previous revision: 1.17
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Comment 12•18 years ago
|
||
Comment on attachment 228952 [details] [diff] [review]
patch
Requesting approval for Uri.
This is a Mac-only change to platformHTMLBindings.xml which will add opt-delete (forward delete to be specific) as a key command. It has r/sr from aaronlev/bz, respectively. (Note that aaronlev is the module owner for this code.)
Attachment #228952 -
Flags: approval1.8.1?
Comment 13•18 years ago
|
||
Comment on attachment 228952 [details] [diff] [review]
patch
a=drivers, please land on the 181branch
Attachment #228952 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 14•18 years ago
|
||
Checked into 1.8 branch:
Checking in content/xbl/builtin/mac/platformHTMLBindings.xml;
/cvsroot/mozilla/content/xbl/builtin/mac/platformHTMLBindings.xml,v <-- platformHTMLBindings.xml
new revision: 1.16.16.2; previous revision: 1.16.16.1
done
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•