Closed
Bug 306209
Opened 19 years ago
Closed 19 years ago
Should fire NS_FOCUSCONTENT event on nsPluginInstanceOwner by clicking plugin's content
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: masayuki, Assigned: emk)
References
()
Details
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
When object frame created child widget for plugin content, the events for plugin
conent is catching on nsPluginInstanceOwner class. This class has focus listner.
But this focus listner is fired by using keyborad tabbing. We click prugin content,
the event isn't fired. I need this event for advanced IME implementation(See bug
55751). Please help me.
Reporter | ||
Updated•19 years ago
|
Reporter | ||
Updated•19 years ago
|
Reporter | ||
Comment 1•19 years ago
|
||
If base widget of flash plugin has focus, you can show alert.
You can set focus by Keyborad only. You may not be able to set focus by mouse
click.
Reporter | ||
Updated•19 years ago
|
Assignee: events → VYV03354
Assignee | ||
Comment 2•19 years ago
|
||
When plug-in window clicked, the messages will be sent in the following order:
1. PluginWndProc
2. WndProc set by plug-ins
3. nsWindow::ProcessMessage
and NS_PLUGIN_ACTIVATE will be generated in nsWindow::ProcessMessage.
But some plug-ins (including Flash Player) won't forward messages to
nsWindow::ProcessMessage. Therefore I moved WM_MOUSEACTIVATE to PluginWndProc.
Attachment #194246 -
Flags: superreview?(jst)
Attachment #194246 -
Flags: review?(jst)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•19 years ago
|
||
*** Bug 243824 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 4•19 years ago
|
||
*** Bug 213466 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 5•19 years ago
|
||
I tested the patch, it works fine.
Reporter | ||
Comment 6•19 years ago
|
||
Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0
roc:
Could you r+sr for this?
This blocks bug 55751.
I tested this patch. This patch works fine for me.
Attachment #194246 -
Flags: superreview?(roc)
Attachment #194246 -
Flags: superreview?(jst)
Attachment #194246 -
Flags: review?(roc)
Attachment #194246 -
Flags: review?(jst)
Comment on attachment 194246 [details] [diff] [review]
Patch rv1.0
This is a risky patch. Make sure it only lands on trunk!
Attachment #194246 -
Flags: superreview?(roc)
Attachment #194246 -
Flags: superreview+
Attachment #194246 -
Flags: review?(roc)
Attachment #194246 -
Flags: review+
Reporter | ||
Comment 8•19 years ago
|
||
checked-in. thank you.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Reporter | ||
Comment 9•19 years ago
|
||
Comment 10•19 years ago
|
||
I'm proposing that we back out this fix because it has caused bug 323142 and reopen this bug.
Is it possible to fix this bug in a similar way to the way bug 317486 was fixed?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 11•19 years ago
|
||
Ian:
Don't reopen this bug until the patch is backed out.
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Comment 12•19 years ago
|
||
We might need both handlers or something to satisfy all needs.
Comment 13•18 years ago
|
||
*** Bug 356554 has been marked as a duplicate of this bug. ***
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•