Closed Bug 33467 Opened 25 years ago Closed 21 years ago

Cookie Manager should allow direct entry of entries to reject/allow - add site button

Categories

(Core :: Networking: Cookies, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
mozilla1.6beta

People

(Reporter: rekle, Assigned: mconnor)

References

Details

(Keywords: helpwanted)

Attachments

(2 files)

The Cookie Manager is great. One additional feature I'd like to see though is the ability to directly add/delete/edit cookie entries in the Cookie Manager. Say I install Mozilla on a new PC. I know I want to block doubleclick.net. I'd like to be able to go into the cookie manager and manually add it as a blocked cookie site, rather than having to keep browsing until I hit a doubleclick.net cookie and reject it then. Another useful feature would be to be able to export the cookie manager 'black list' to a file and then be able to import it into a different machine's copy of Mozilla.
These were thought about but rejected for the present. Problem is that it would take a sophisticated user to know in advance which sites he wants to block cookies from. And such a sophisticated user could always hand-edit the cookperm.txt file. I'm not saying that this wouldn't be a nice feature, just that it wasn't considered as important as the ability to permanently block cookies as they are being encountered. If someone volunteers to implement this, then I'll certainly see that it gets checked in. Otherwise this will probably have to wait for post 6.0.
Status: NEW → ASSIGNED
Target Milestone: --- → M20
Target Milestone: M20 → M30
Changing fictional "M30" to reality
Target Milestone: M30 → Future
Adding self to CC list
Modifying the summary to include image manager as well as cookie manager.
Summary: Cookie Manager should allow direct entry of cookies to reject/allow → Cookie/Image Manager should allow direct entry of entries to reject/allow
*** Bug 57418 has been marked as a duplicate of this bug. ***
Summary: Cookie/Image Manager should allow direct entry of entries to reject/allow → [z]Cookie/Image Manager should allow direct entry of entries to reject/allow
Summary: [z]Cookie/Image Manager should allow direct entry of entries to reject/allow → Cookie/Image Manager should allow direct entry of entries to reject/allow
Whiteboard: [z]
Netscape nav triage team: based on Steve Morse's pre-triage recommendation, this is not a beta stopper.
Keywords: nsbeta1-
.
Assignee: morse → nobody
Status: ASSIGNED → NEW
Whiteboard: [z]
*** Bug 26742 has been marked as a duplicate of this bug. ***
*** Bug 67431 has been marked as a duplicate of this bug. ***
OS: other → All
Hardware: PC → All
*** Bug 69148 has been marked as a duplicate of this bug. ***
*** Bug 89221 has been marked as a duplicate of this bug. ***
Internet Explorer 6 is going to have a feature like this. Microsoft are promoting it on their Windows XP site. See http://www.microsoft.com/windowsxp/expertzone/columns/bowman/june25.asp for more details. It would be nice if Mozilla had this feature before IE6 launches.
*** Bug 89904 has been marked as a duplicate of this bug. ***
The workaround is to edit cookperm.txt in your profile. Never mind the "This is a generated file! Do not edit." bit ;) There's no documentation on the file format, but: 0F site can't set cookies 0T site can set cookies 1F site can't load images I've never seen 1T naturally occur, it probably does the obvious, though. Not sure what the @@@@ line controls.
@@@@ reflects the last-used state of the do-you-want-to-remember checkbox that appears in the cookie-warning box and the image-warning box 1T will occur if you put a checkmark in the image-warning checkbox for a particualur site.
*** Bug 115801 has been marked as a duplicate of this bug. ***
*** Bug 110363 has been marked as a duplicate of this bug. ***
*** Bug 129489 has been marked as a duplicate of this bug. ***
*** Bug 142397 has been marked as a duplicate of this bug. ***
*** Bug 151330 has been marked as a duplicate of this bug. ***
See also: bug 92469 import/export image permissions lists bug 109810 manually add to Passwords never saved list in passwordmanager
*** Bug 161830 has been marked as a duplicate of this bug. ***
*** Bug 176917 has been marked as a duplicate of this bug. ***
*** Bug 183830 has been marked as a duplicate of this bug. ***
As a user, I think this is a reasonably important feature to have, since I use it very regularly with IE (which is another reason we should support it). I'm aware of cookperm.txt's existence, but that doesn't address the issue; the user should be able to do this within the UI, especially since it (seems like) such a simple thing to implement. This isn't just for 'power users' who want to enter permissions on browser install - this is something I use everyday. As explained in bug 183830 (sorry for the dup), it's useful if you want a 'blanket reject' policy for cookies, but then enable them when you encounter a site where you want to specifically enable them. For instance, webmail sites usually require cookies, but that doesn't mean I want to enable cookies for all sites. In 183830, I mentioned what I think would be a nice way to implement this - by adding to the cookie manager, and also by having a small 'cookie icon' in the status bar which shows if a cookie has been rejected (or stored) for that site. Clicking this icon would allow the user to 'set allow' or 'set reject' very quickly, without clicking all the way thru prefs to the cookie manager. Image and popup managers might want similar features.
Blocks: 100573
*** Bug 201060 has been marked as a duplicate of this bug. ***
Tweaking summary. (I would have found this one otherwise.)
Summary: Cookie/Image Manager should allow direct entry of entries to reject/allow → Cookie/Image Manager should allow direct entry of entries to reject/allow - add site button
adding mvl to cc. we should consider this at some point if (when) we're reworking UI stuff.
Please get direct entry fixed on at least the Image manager. Thanks
Rich: cookies and image blocking are separate componenets now. Can you create a bug just for Image Manager in Image Manager?
QA Contact: tever → cookieqa
Summary: Cookie/Image Manager should allow direct entry of entries to reject/allow - add site button → Cookie Manager should allow direct entry of entries to reject/allow - add site button
*** Bug 210142 has been marked as a duplicate of this bug. ***
*** Bug 211321 has been marked as a duplicate of this bug. ***
taking
Assignee: nobody → mvl
*** Bug 214974 has been marked as a duplicate of this bug. ***
Attached patch first try (deleted) — Splinter Review
A first try at a patch. Just add a "Add Site" button, which pops up a dialog that asks you to enter a sitename, and a checkbox to indicate allow cookie/image or block it.
Attachment #129761 - Flags: review?(dwitte)
Comment on attachment 129761 [details] [diff] [review] first try >Index: extensions/wallet/cookieviewer/CookieViewer.properties >=================================================================== >+addPermissionTitle = Add Site >+addPermissionCookieText = Enter a site for which you want to set the cookie permission (eg "www.mozilla.org") s/eg/e.g./, and add a full-stop at the end? >+addPermissionImageText = Enter a site for which you want to set the image permission (eg "www.mozilla.org") same here. this looks good, but i'd still like to see two radioboxes instead of a checkbox here: "() allow cookies () reject cookies". it's up to jag, i guess, since we can't use the nice promptservice default if we do that, like you say. what about keybindings (checkbox)? r=dwitte, provided jag is happy with the checkbox prompt.
Attachment #129761 - Flags: review?(dwitte) → review+
Attachment #129761 - Flags: superreview?(jag)
Attached image Target UI for this enhancement (deleted) —
This bitmap is a screenshot for AtGuard, still the finest firewall/ content filter program in existence. This dialog box is *precisely* what is needed regarding popups, cookies, images, flash, and so forth. It asks you two questions: "is this session-only or permanent?" and "is it for this domain or this machine?" Four choices, real simple. No more distinction between files, or UI issues, or whatever else might be concocted. For permanent choices, you save either a domain or a machine name, and the attributes that go with it. For sessions it's the same thing, only it'll live in your cache folder or a temporary file and die on exit.
That screenshot is not a terget ui for this bug. This bug is about a way to add entries to the cookie sites, without browsing to that site. The screenshot is something for the dialog that pops up when a cookie is set.
*** Bug 219841 has been marked as a duplicate of this bug. ***
Comment on attachment 129761 [details] [diff] [review] first try Hmm, I think the checkbox is fine for now. If we ever get to the place where you can disable all cookies, and selectively enable them for some sites (none of the current UI suggests that's possible), then a more explicit choice would be needed. sr=jag
Attachment #129761 - Flags: superreview?(jag) → superreview+
Comment on attachment 129761 [details] [diff] [review] first try Hmm, I missed the "Cookie Sites" tab. So I guess you can block all cookies and then selectively unblock a few sites. Or at least it looks like you can. So perhaps two radio buttons would be better then. Unchecking the checkbox kinda suggests "whatever the current default is", though really the way to do that is to remove the domain from the list.
I agree that radio buttons would be clearer. I tried to create a dialog with it, but got bitten by bug 181331. I used JS to set the labels to eiterh "allow site to set cookies" or "allow site to show images". So either that bug needs to be fixed, or worked around using a different UI.
->
Assignee: mvl → mpconnor
fixed by the patch for bug 222553
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: Future → mozilla1.6beta
verify via closed dependency to kill this bug... will test and verify there.
Status: RESOLVED → VERIFIED
Depends on: 222553
QA Contact: core.networking.cookies → benc
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: