Closed
Bug 382679
Opened 18 years ago
Closed 18 years ago
moving items in the organizer down are off by 1
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha6
People
(Reporter: dietrich, Assigned: christineyen+bugs)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
see discussion here:
http://forums.mozillazine.org/viewtopic.php?p=2905540#2905540
Flags: blocking-firefox3?
Comment 1•18 years ago
|
||
FWIW, seems to work okay when moving an item down when within bookmark toolbar chevron's pulldown...but off-by-1 when done within organize bookmarks.
Reporter | ||
Comment 2•18 years ago
|
||
maybe a dupe of bug 381751
Comment 3•18 years ago
|
||
dietrich, thanks for logging this bug from the forums discussion.
yes, probably related to bug #381751
I did a little debugging and I think we are not calling moveItem() with the appropriate index, and I think that the tree view is not generating the proper insertionPoint when calling onDrop().
I plan to fix this one for A6, but let's keep from duping it until full investigated.
Assignee: nobody → sspitzer
Updated•18 years ago
|
Assignee: sspitzer → cyen
Assignee | ||
Comment 4•18 years ago
|
||
Removing the call to "this._adjustInsertionPoint(ip);" (_adjustInsertionPoint: http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/tree.xml#845 , only call within onDrop() at #921) fixes the drag/drop difficulties.
From CVS Blame, http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/components/places/content/tree.xml&rev=1.72#921 adjustInsertionPoint looks like first- or second-round code that may have been compensated for in a later patch for another drag&drop bug, like Bug #330263 or #326598.
Mostly also fixes Bug #381751, but if your mouse moves two pixels in the wrong direction while trying to see if issue #3 ( https://bugzilla.mozilla.org/show_bug.cgi?id=381751#c0 ) is fixed, the error is reproduced.
Attachment #268304 -
Flags: review?(sspitzer)
Assignee | ||
Updated•18 years ago
|
Attachment #268304 -
Flags: review?(sspitzer)
Assignee | ||
Updated•18 years ago
|
Attachment #268304 -
Flags: review?(sspitzer)
Updated•18 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: regression
Comment 5•18 years ago
|
||
Comment on attachment 268304 [details] [diff] [review]
patch
r=sspitzer
Attachment #268304 -
Flags: review?(sspitzer) → review+
Comment 6•18 years ago
|
||
fixed.
Checking in tree.xml;
/cvsroot/mozilla/browser/components/places/content/tree.xml,v <-- tree.xml
new revision: 1.77; previous revision: 1.76
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 7•17 years ago
|
||
Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707120404 Minefield/3.0a7pre.
Status: RESOLVED → VERIFIED
Comment 8•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•