jetxee Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9b1) Gecko/2007110903 Firefox/3.0b1

Bookmarks system of Firefox allows categorizing bookmarks by folders, but does not allow to search them by folder name. Neither bookmarks siderbar nor bookmarks manager do allow search for bookmarks by folder name.

Example, where it is useful. I have two bookmark folders: `Friends' and `Foes'.

In `Friends' there are
- `John'
- `Marry'
- `Alice'
- `Bob'

In `Foes' there are
- `John' (it may point to the other John)
- `Bill'

Searching by `Friends' or `Foes' gives nothing. The user is forced either to append folder name to bookmark's title or navigate folder tree manually (tiresome if there is a lot of folders).


Reproducible: Always

Steps to Reproduce:
1. Create a new folder `TestFolder' in Bookmarks manager
2. Add a new bookmark to this folder, label it with TestTag tag.
3. Open bookmarks sidebar
3.1. type `TestFolder' in search field
>>> no bookmarks found
3.2. type `TestTag' in search field
>>> the last bookmark is found
4. Open bookmark manager and repeat search there.
>>> the same results.

	Ondrej Brablc
	Comment 1 • 17 years ago

I can confirm the bug on Windows.

In nsNavHistory.cpp there is a function NeedToFilterResultSet, this returns TRUE for all bookmarks queries and if search term is defined or a folder is specified.

Afterwards all the bookmarks are read from the database (performance problem) and filtered later in FilterResultSet. Inside of this functions is following code:

---8<---

    // exclude-queries is implicit when searching, we're only looking at
    // plan URI nodes
    if (!aSet[nodeIndex]->IsURI())
      continue;

--->8---

This has impact on bug 385245 too. After removal of grouping, usage of maxResults excludes folders from the output.

	juan becerra [:juanb]
	Comment 2 • 17 years ago

Confirmed on Fx3rc2build2 on Vista. I tried creating a folder inside the Bookmarks Menu, and I named it "inside bm". Then I selected the Bookmarks Menu folder in the left pane and then entered the search "inside bm"; I got no results.

It can be argued that if you place items in a folder, they are all related and hopefully tagged so you can find all your "friends" and "foes" as explained in comment #0, but the current behavior seems to against user expectations.

	Dietrich Ayala (:dietrich)
	Comment 4 • 16 years ago

Not going to block the 3.1 release for this. Adding uiwanted keyword to get a discussion going for a consistent way to expose folder name search across all the different entry points, and visual identification of search result causality.

	Jean-Philippe Fleury
	Comment 5 • 16 years ago

I confirm this bug on Ubuntu 8.10, Firefox 3.0.4. In the bookmarks manager, I created a folder named MonDossierTest. I searched MonDossierTest in the bookmarks manager: no result. I did the same search in the bookmarks sidebar and the location bar: no result neither.

	Jean-Philippe Fleury
	Comment 7 • 16 years ago

I make a suggestion for the visual identification of the folders in the address bar. See the attached image.

We see in this image that the fifth result is a bookmark folder. There is:

- a folder icon instead of the favicon in the left
- in the right, the number of items in this folder
- the folder name instead of the title markup content
- the location of the folder (so there's the name of each potential parent folder) instead of the url

A left click on this folder (Gedit) could open the bookmarks sidebar with the focus on the Gedit folder and its content expanded.

A right click could open all the bookmarks contained in the Gedit folder.

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 8 • 16 years ago

>uiwanted

Let's keep the interface of the library window and the location bar in separate bugs.  In the case of searching for folder names in the library window, if the context of the search is set to All Bookmarks or the selected folder, any sub folders that contain text that matches the query should be displayed, along with other search results in the right pane.

	Alex Faaborg [:faaborg] (Firefox UX)
	Comment 9 • 16 years ago

Filed follow up bug 469424 for changes to the awesome bar.

	Jean-Philippe Fleury
	Comment 10 • 16 years ago

It think that the bug 292104 is a duplicate of this current bug. Am I wrong?

	Ken Winiecki, Jr.
	Comment 12 • 16 years ago

I vote for this bug.  As often as not, the folder what I am actually looking for.  But it's not 3.x specific; 2.x bookmarks sidebar search never returned folders either.  And I never really understood why, since they always seemed equally easy to identify in the 2.x bookmarks file.  I think this is not a duplicate of bug 292104 only because that refers to the library manager interface and this refers to the sidebar interface.

	Thomas D. (:thomas8)
	Comment 13 • 15 years ago

As per comment #0, this bug is about finding bookmark folders BOTH in the library AND in the bookmarks sidebar (against comment #12).
--> Updating summary for clarification and improved retrievability

Comment #10 is right, I will forward-duplicate bug 292104 to this bug.

As per Alex comment #8, Attachment 350354 [details] and nice comment #7 is about finding bookmark folders in the Location Bar (aka Awsome Bar) and therefore does not belong to this bug, but should go into follow-up Bug 469424 (Allow the user to navigate on Tags and Folders in the location bar). Is there a way to transfer the attachment (apart from re-posting it in the other bug?). As a first step, to avoid confusion in this bug, I will obsolete the attachment here.

	Thomas D. (:thomas8)
	Comment 15 • 15 years ago

Comment on attachment 350354 [details]
Suggestion for the visual identification of the folders in the address bar

Obsoleting attachment 350354 [details] as per comment #8 and comment #13. This attachment and comment #7 don't belong here: followup bug 469424.

	Gervase Markham [:gerv]
	Comment 16 • 15 years ago

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

	Michelle
	Comment 17 • 12 years ago

This is a problem for me too. I'm on XP Prof, but I have a feeling it's a problem on all OSs.

I don't use tags, as I always forget to label the bookmark, so I want to find the bookmarks by folder since I do file bookmarks in their proper folders & I name the folders properly.

I'm surprised it doesn't find the folders, only the bookmarks.

Thanks


Michelle

	Carlo 'Carcarlo' Carmagnini
	Comment 18 • 12 years ago

I can confirm this old bug in Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0
Yesterday I had a colleague of mine complaining about this lack-of-feature, so I recalled this bug and noticed it had not been fixed. Regarding competitors: Chrome behaves like Firefox, while Opera searches also for folder names. FX should copy Opera's, IMHO.

	Jim Michaels
	Comment 20 • 10 years ago

I would add that (for organization purposes), having some sort of checkbox or something to show the list of all folders in a clump up top would help bookmark organization for the user. I know this is something I want. finding folder names would also be VERY helpful for same.

	Greg
	Comment 28 • 7 years ago

I can confirm this bug on v57 Firefox. 

It is helpful to be able to view folders in the search listings. Often I am searching for something and I get many hits. But in the past I have organized the most relevant entries into a folder of that title. Having search bring up this folder takes me right to what I want, a folder that contains relevant entries. Folders should be listed in the search output.

	reg-github
	Comment 32 • 7 years ago

Tested it with 59.0a1 and seems this is still missing. Please add this, as with years of well organized folder structure, you sometimes don't know where the matching folder is. Therefore, listing matching folder in sidebar would be really helpful. Or add a feature to automatically assign individual bookmark folder tree structure as tags to each bookmark, please.

	Benjamin De Brasi
	Comment 33 • 7 years ago

I'd like to work on this bug. How can I get started?

	Jonathan Watt [:jwatt]
	Comment 34 • 6 years ago

Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)