Closed
Bug 424527
Opened 17 years ago
Closed 15 years ago
Remove dead file jsObjectView.js
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: WeirdAl, Assigned: crussell)
Details
Attachments
(1 file)
(deleted),
patch
|
neil
:
superreview+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•15 years ago
|
||
Is SR needed here?
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Attachment #426947 -
Flags: superreview?(neil)
Attachment #426947 -
Flags: review?(sdwilsh)
Comment 2•15 years ago
|
||
Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]
Probably not for an unused file, no ;-)
Attachment #426947 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]
sr+ seems sufficient
Attachment #426947 -
Flags: review?(sdwilsh)
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 4•15 years ago
|
||
(In reply to comment #3)
> (From update of attachment 426947 [details] [diff] [review])
> sr+ seems sufficient
I'm not sure whether to object to this or not. True, for this purpose (removing a single unused file) it probably only needs one review. But I don't remember ever seeing a patch where sr+ substituted for r+.
It does sound childish of me to request adherence to the rules, especially since I'm not very active in contributing to the Mozilla code base these days. What I do believe is that it is not the patch author's decision whether sr+ seems sufficient or not, but the module owner's.
Comment 5•15 years ago
|
||
rs=me :)
Reporter | ||
Comment 6•15 years ago
|
||
And objection withdrawn :)
Comment 7•15 years ago
|
||
Comment on attachment 426947 [details] [diff] [review]
remove it
[Checkin: Comment 7]
http://hg.mozilla.org/dom-inspector/rev/2bbdd20af50a
Attachment #426947 -
Attachment description: remove it → remove it
[Checkin: Comment 7]
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•