A catch-all bug for landing changes to tamarin redux taken from tracemonkey.

Mirror of bug 513539

Mirror of bug 513535

Mirror of change from bug 513838

Mirror of changes in bugs 513884 and 513843

(In reply to comment #4) > Created an attachment (id=399909) [details] > LIR_float added > > Mirror of change from bug 513838 does it cause problems if we are still using LIR_quad for double constants from Tamarin?

Comment on attachment 399913 [details] [diff] [review] gen() signature change / introduce LIR_flive code looks safe, and +1 for allocating loop variables to registers, but we need to make sure the expressions we use with LIR_live in Tamarin, match up here. we often use LIR_live(LIR_alloc expr), which should *not* get a register, so we should at least tweak this to include LIR_alloc in the list of instruction types that dont get registers assigned.

comment #6: no the code still works fine, but the suggestion from TM folks is that we should migrate over to LIR_float as there are fp optimizations that kick-in , when doing so. comment #7: nice catch; I had problems with that particular patch and ended up commenting out the handleLoopCarriedExprs. Would like to push the rest of the patch, commenting out that change (i.e leaving it as fingRegMem(). There will be some postmortem work where we need further changes, but I'd like to keep the continuity moving forward with the remaining patches.

(In reply to comment #8) > comment #7: nice catch; I had problems with that particular patch and ended up > commenting out the handleLoopCarriedExprs. Would like to push the rest of > the patch, commenting out that change (i.e leaving it as fingRegMem(). findMemFor, i think. > There will be some postmortem work where we need further changes, but I'd like > to keep the continuity moving forward with the remaining patches. cool

pushed attachment 399893 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/e28c4453402e pushed attachment 399898 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/3879b8d2fcf3 pushed attachment 399903 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/2271f49cb5df pushed attachment 399909 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/15e8f8a875f6 pushed attachment 399913 [details] [diff] [review] http://hg.mozilla.org/tamarin-redux/rev/595559231e42

Resolved fixed engineering / work item that has been pushed. Setting status to verified.