Closed Bug 517308 Opened 15 years ago Closed 15 years ago

TM merge: Part II set of changes from Tracemonkey

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rreitmai, Assigned: rreitmai)

References

Details

Attachments

(17 files)

(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
(deleted), patch
edwsmith
: superreview+
Details | Diff | Splinter Review
A collection of patches extracted from the Tracemonkey branch and rebased to apply against tamarin redux. The patches will be posted in order of application and rely on the landing of early patches outlined in 515539, 515548 and 515822 respectively. Each patch represents a check-in and associated patch from the Tracemonkey branch. Bug numbers will be specified for each of the patches.
Attached patch bug 514344 (deleted) — Splinter Review
Attachment #401276 - Flags: superreview?(edwsmith)
Attached patch bug 514374 - reg fence (deleted) — Splinter Review
Attachment #401279 - Flags: superreview?(edwsmith)
Attached patch bug 513831 (deleted) — Splinter Review
Attachment #401282 - Flags: superreview?(edwsmith)
Attached patch bug 513843 (deleted) — Splinter Review
Attachment #401284 - Flags: superreview?(edwsmith)
Attached patch bug 514537 (deleted) — Splinter Review
Attachment #401285 - Flags: superreview?(edwsmith)
Attached patch bug 512646 - regalloc cleaning (deleted) — Splinter Review
Attached patch bug 514503 - sanity filter (deleted) — Splinter Review
Attachment #401288 - Flags: superreview?(edwsmith)
Attached patch bug 514625 - rm highwater (deleted) — Splinter Review
Attachment #401290 - Flags: superreview?(edwsmith)
Attached patch bug 512824 - lir class changes (deleted) — Splinter Review
Attachment #401292 - Flags: superreview?(edwsmith)
Attached patch bug 513407 - expr fold case (deleted) — Splinter Review
Attachment #401296 - Flags: superreview?(edwsmith)
Attached patch bug 515138 - stack filter (deleted) — Splinter Review
Attachment #401297 - Flags: superreview?(edwsmith)
Attached patch bug 514586 - ldcd,s x64 bug (deleted) — Splinter Review
Attachment #401300 - Flags: superreview?(edwsmith)
Attached patch bug 514532 - lir 64b helpers (deleted) — Splinter Review
Attachment #401301 - Flags: superreview?(edwsmith)
Attached patch bug 514496 - cmov x64 (deleted) — Splinter Review
Attachment #401302 - Flags: superreview?(edwsmith)
Attached patch bug 514349 - rm Reservation (deleted) — Splinter Review
Attachment #401304 - Flags: superreview?(edwsmith)
Attached patch bug 514066 - lir inlining (deleted) — Splinter Review
Attachment #401305 - Flags: superreview?(edwsmith)
Attachment #401306 - Flags: superreview?(edwsmith)
Attachment #401286 - Attachment description: bug 512646 → bug 512646 - regalloc cleaning
Attachment #401286 - Flags: superreview?(edwsmith)
Attachment #401276 - Flags: superreview?(edwsmith) → superreview+
Attachment #401279 - Flags: superreview?(edwsmith) → superreview+
Attachment #401282 - Flags: superreview?(edwsmith) → superreview+
Attachment #401284 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 401285 [details] [diff] [review] bug 514537 Please don't re-add the NJ_LOG2_PAGE_SIZE = 12 constant in NativeX64.h
Attachment #401285 - Flags: superreview?(edwsmith) → superreview+
Attachment #401286 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 401288 [details] [diff] [review] bug 514503 - sanity filter This is based on the ValidateFilter in CodegenLIR.cpp, but is missing a bunch of other instruction categories. lets make sure we remove the duplicate code from ValidateFilter ASAP.
Attachment #401288 - Flags: superreview?(edwsmith) → superreview+
Attachment #401290 - Flags: superreview?(edwsmith) → superreview+
Attachment #401292 - Flags: superreview?(edwsmith) → superreview+
Attachment #401296 - Flags: superreview?(edwsmith) → superreview+
Attachment #401297 - Flags: superreview?(edwsmith) → superreview+
Attachment #401300 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 401301 [details] [diff] [review] bug 514532 - lir 64b helpers looks like we have some redundant helpers in CodegenLIR.cpp that can be removed due to this patch (i'm thinking of u2p() and i2p())
Attachment #401301 - Flags: superreview?(edwsmith) → superreview+
Attachment #401302 - Flags: superreview?(edwsmith) → superreview+
Attachment #401304 - Flags: superreview?(edwsmith) → superreview+
Attachment #401305 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 401306 [details] [diff] [review] bug 513787 - epilogue and jumptable curious how this ends up looking on tamarin where we have >1 LIR_ret per method (it occurs each place an OP_returnvalue occurs in ABC)
Attachment #401306 - Flags: superreview?(edwsmith) → superreview+
Blocks: 517560
Blocks: 517561
re comment #18 : done re comment #19 : created bug 517561 re comment #20 : created bug 517560 re comment #21 : doesn't seem to move the needle for us (at least on the tests I've run) but TM reports a modest gain
Blocks: 517562
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: