Open Bug 529229 Opened 15 years ago Updated 2 years ago

Add Empty Trash\Junk on context menu to Unified (ex Smart) Trash folder

Categories

(Thunderbird :: Folder and Message Lists, enhancement)

Product:
Thunderbird
Component:
Folder and Message Lists
Platform:
x86
All
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: jmordax, Unassigned)

References

(
URL
)

Details

(Whiteboard: [gs])

Attachments

(4 files)

An screen shot showing lack of Empty Trash option.
(deleted), image/png
Details
"empty trash" context menu item
(deleted), image/jpeg
Details
An screen shot showing lack of Empty Trash option also in Safe Mode
(deleted), image/png
Details
patch
(deleted), patch
wsmwk
: feedback+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 (CK-IBM) Firefox/3.5.5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0 Smart Trash folder seems to be very useful to wrap all trash folder of the accounts but it lacks an interesting feature which is Empty Trash option in the context menu. [workaround] To empty all the trashes I have to select the smart Trash folder and go to File menu. I think it doesn't make sense the lack of such option in the folder context menu. Reproducible: Always
This WFM - I can empty all the trash If I select the top level trash, when I do that I even get a warning that all my trashes are going to get emptied. Wayne, aureliano, can you confirm/infirm that it's also true on windows ?
I haven't said it doesn't clean all trashes, I said I miss a context menu option at smart Trash folder level. I you click right mouse button on any specific trash account, you have an empty trash option. But if you click right mouse button on smart Trash folder, you don't have such option. You are required to go to File menu. Why we don't have such empty trash button also on the wrap folder?
WFM too: "empty trash" context menu item delete all trash folders on "smart folder" view. Probably the only issue is that in this case menu item should be "empty trashes" and not "empty trash". Note: emptying trashes in smart folder view show bug #528667. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091116 Lightning/1.0pre Shredder/3.0.1pre ID:20091116032337
An screen shot showing lack of Empty Trash option at smart Trash folder level context menu.
I have added an attachment with a screen shot showing the context menu of smart Trash folder. Aureliano, do you see in that same context menu the "Empty Trash" option? I am using: "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0" BTW, I agree with you that perhaps the wording of such option should be a different one.
Attached image "empty trash" context menu item (deleted) —
(In reply to comment #5) >Aureliano, do you see in that same context menu the "Empty Trash" > option? I am using: "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; > rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0" No I see "empty trash" item as show in attached file. Could you try in safe-mode? see here http://kb.mozillazine.org/Safe_mode
(In reply to comment #4) > Created an attachment (id=412801) [details] > An screen shot showing lack of Empty Trash option. > > An screen shot showing lack of Empty Trash option at smart Trash folder level > context menu. Good we are talking about the same thing :-) SO now let's try to figure out why it doesn't work for you. Can you start thunderbird in safe-mode (see http://kb.mozillazine.org/Safe_mode) and tell us if you still have the issue ? Anything in Tools -> Error console when you open the context menu ?
In Safe Mode same behavior (see attachment). and nothing new is added to the Error Console when I open the context menu. BTW, I have POP3 and RSS accounts under Trash folder. Is it also your case?
(In reply to comment #8) > BTW, I have POP3 and RSS accounts under Trash folder. Is it also your case? me too.
Any other test or anything to look for? BTW, if I select "Properties..." from smart Trash folder context menu, I get the "Edit Saved Search Properties for Trash" and following error in Error Console: Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://messenger/content/mailWidgets.xml :: get_valueLabel :: line 1223" data: no] Do you see the same behavior? Could it be related? Should I fill a new bug with this error (although I think it is not affecting)?
(In reply to comment #10) > Any other test or anything to look for? Beats me for now. I would do a reinstall to see if things get fixed. > BTW, if I select "Properties..." from smart Trash folder context menu, I get > the "Edit Saved Search Properties for Trash" and following error in Error > Console: I don't get that.
I uninstalled TB 3.0 RC1 and reinstalled it. Same behavior. But remember I upgraded from a previous TB 2.0 installation with a already existing profile. So, although I have reinstalled TB 3.0 I still reusing my daily work profile.
Do you have Get Messages option in smart Inbox folder context menu or any of its subfolders (accounts)? I haven't...
(In reply to comment #13) > Do you have Get Messages option in smart Inbox folder context menu or any of > its subfolders (accounts)? I haven't... I don't either.
Same goes for Junk Smart Folder
(In reply to comment #15) > Same goes for Junk Smart Folder Chris so same isse even in safe-mode and same error message in Tools -> Error console.
> so same isse even in safe-mode yes. > same error message in Tools -> Error console. do you mean that "unhandeled exception ..." on properties menu item? then yes i see no other messages in error console
This bug is because the smart trash has the context menu for saved searches, not trash folders. Same thing for junk. It's unrelated to the properties dialog error described here. This should be a fairly easy folderPane.js fix.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
See Also: → https://launchpad.net/bugs/525507
Summary: Add Empty Trash to smart Trash folder → Add Empty Trash\Junk on context menu to Unified (ex Smart) Trash folder
I have been looking for a way to get "Empty Trash" and "Empty Junk" menu items on the smart folders. (Imo, these menu labels should be "Empty All Trash/Junk") To me it seems there is a problem with the "special folder flag". The menu item wants the "Trash" flag but the smart folder gets the "Virtual" flag. (See mailContextMenus.js lines 332 and 466) And, as I can see, the Junk smart folder does not have this support at all. (Compare folderPane.js line 2004 and 1979) This could be easily added, though, in the same way that the Trash smart folder is designed. I'm new here and new to "Mozilla programming" so I could be completely wrong. //j [Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4]
So what is the easy folderPane.js fix mentioned in comment 18? Is that fix available anywhere? And I'm not sure if this is 100% related or not, but the Sent and Junk unified folder seem to be broken. If I select either inbox or trash unified folder, the message list will show "location" column to indicate which account it is from. This is missing in sent and junk unified folders. And, as we've been discussing above, the context menu seem to be broken in all the unified folders.
Depends on: 405627
Whiteboard: [gs]
This is one of the more annoying issues of the "unififed collection" - http://mzl.la/1Uao00J (In reply to David :Bienvenu from comment #18) > This bug is because the smart trash has the context menu for saved searches, > not trash folders. Same thing for junk. It's unrelated to the properties > dialog error described here. This should be a fairly easy folderPane.js fix. As easy as David indicates?
URL: http://getsatisfaction.com/mozilla_me... → https://support.mozilla.org/en-US/que...
Severity: enhancement → minor
Flags: needinfo?(acelists)
Maybe. For some reason, the top level folder for Drafts, Templates and Junk returns "Drafts", "Templates" and "Junk" respectively in the specialFolder variable, that is then used to determine which menuitems to show. Inbox, Trash, Sent return "Virtual". I would not try to understand why that is. But anyway, I can make the "Empty trash" menuitem appear. "Empty Junk" is showing for me already.
Flags: needinfo?(acelists)
Attached patch patch (deleted) — — Splinter Review
So this patch enables the menuitem. However, I am not sure this operation is actually supported on this node. When I used it, all the Trash folders got empties. BUT, their order under the top-level Trash got changed. Also, I then moved some messages to some of the Trashes. But collapsing and uncollapsing the top-level Trash made some of them vanish (even though they contained messages). Changing folder mode to All and then to Unified made them appear again.
Attachment #8744686 - Flags: feedback?(vseerror)
(In reply to :aceman from comment #29) > Created attachment 8744686 [details] [diff] [review] > patch > > So this patch enables the menuitem. > However, I am not sure this operation is actually supported on this node. > When I used it, all the Trash folders got empties. BUT, their order under > the top-level Trash got changed. I see what you mean. > Also, I then moved some messages to some of > the Trashes. But collapsing and uncollapsing the top-level Trash made some > of them vanish (even though they contained messages). Changing folder mode > to All and then to Unified made them appear again. I didn't reproduce this. But I made only a couple attempts. I personally don't use unified, so I don't have advice about what might be considered normal or strange. So I'm CCing a couple people who probably use it.
I don't use Unified either, so not much help here, sorry...
Comment on attachment 8744686 [details] [diff] [review] patch So, a tenative + from me
Attachment #8744686 - Flags: feedback?(vseerror) → feedback+
I use unified and would like to see this implemented; so I can leave my unified trash and junk folders 'closed' and still get rid of the junk. I'm willing to test (I'm on the Release update channel, with Windows 10 on Intel. Two mailboxes, unified.
I would like this feature too.

Why for 10 years no-one fixed that very annoying bug? Its still impossible now to Empty Unified Junk and Trash folders as it was 10 years ago!!!!! Opera Mail does it in split second despite not being updated for years.

Its not "Minor" as it was classified, if you have several mail accounts as everyone does. I'd gladly go back to Opera Mail just because of this never fixed bug to avoid clicking 20 times Empty Trash in 20 mail accounts. Does anyone still work on Thunderbird project?

There are other major issues with Unified folders. One is low productivity: instead of comprising unified folder content from the always update local DB, each unified folder uses IMAP to show content. Another is not showing folders in the Accs list below Unified folders list. Without folders shown, the acc list serves no purpose in Unified Folders View.

What is the progress on fixing this bug? Why Thunderbird is updated to new versions without this bug ever fixed? Any reasonable person will say that 10 years is enough to fix this bug!

Type: defect → enhancement

I will update this to an enhancement request as that ios what it is.

I agree that it is rather an enhancement request than a bug, but I still believe it makes a lot of sense to implement it (and the functionality of the unified folders is diminished by not having this). It should be an integral part of the unified folders. Either support them - and include this - or remove them. (I hope this can be added).

So after 10 years of doing nothing, updating it from Bug to Enhancement is expected to do what - extend the timeline for another 10 years? Isn't it obvious, its a bug as how you can possibly have a Trash folder without Empty Trash option? Its not logical, these features come only in pairs, therefore its a bug. Missing mandatory option is not the same as "nice to have" feature request. Its like having a car without wheels, and then claiming adding wheels is an enhancement, and likely won't come any time soon. And saying "severity is minor" is wrong. If there was such option, but it didn't work, would you mark severity as minor, despite it directly affects privacy and security?

Same applies to Junk folder, but the RMC option should be "Move Junk to Trash" rather than "Empty Junk". Do you have any mandatory completion deadlines for "enhancements" with "minor" severity?

@zamarac: (On a meta level:) People have different interests and priorities. People are free [not] to work on something. If you really want something to be implemented, feel free to provide a software patch and getting it reviewed or to convince someone else to write that software patch. "What have you done in the last 10 years to fix this problem?", basically. Also see https://www.mozilla.org/en-US/about/governance/policies/participation/ - thanks! :)

Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: