Closed
Bug 532024
Opened 15 years ago
Closed 15 years ago
update accessible tree when accessible reorder event is occurred
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: access)
Attachments
(1 file)
|
(deleted),
patch
|
sdwilsh
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
When accessible tree is mutation then reorder event is fired on the container of changed accessibles. It's worth to use it to update accessible tree view.
|
Assignee | |
Comment 1•15 years ago
|
||
(In reply to comment #0)
> Created an attachment (id=415331) [details]
> patch
the patch is a bit hacky but it sounds it's a simplest way.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #415331 -
Flags: superreview?(neil)
Attachment #415331 -
Flags: review?(sdwilsh)
|
||
Updated•15 years ago
|
Attachment #415331 -
Flags: superreview?(neil) → superreview+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 415331 [details] [diff] [review]
patch
>+ if (node.accessible == accessible) {
>+ // Toggle open state twice to update the children.
>+ this.toggleOpenState(idx);
>+ this.toggleOpenState(idx);
>+ break;
>+ }
Nit: only need to toggle twice if the index was already open.
(Still want to break of course.)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 415331 [details] [diff] [review]
patch
nit: s/var/let/ please
r=sdwilsh with that change.
Attachment #415331 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
landed with addressed Neil's and Shawn's comments - http://hg.mozilla.org/dom-inspector/rev/2f604b4db3d0
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•