Closed
Bug 537994
Opened 15 years ago
Closed 13 years ago
Get rid of unused util.dtd
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crussell, Assigned: foss)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
crussell
:
review+
|
Details | Diff | Splinter Review |
The only file that is interested in either of these strings is pref-sidebar.js, and JavaScript doesn't benefit from DTDs, anyway.
$ cat ./mozilla/extensions/inspector/resources/content/util.dtd
<!ENTITY INS-rdf "http://www.mozilla.org/inspector#">
<!ENTITY NC-rdf "rdf:http://home.netscape.com/NC-rdf#">
$ grep -re "INS-rdf" ./mozilla/extensions/inspector/
./mozilla/extensions/inspector/resources/content/util.dtd:<!ENTITY INS-rdf "http://www.mozilla.org/inspector#">
$ grep -re "NC-rdf" ./mozilla/extensions/inspector/
./mozilla/extensions/inspector/resources/content/util.dtd:<!ENTITY NC-rdf "rdf:http://home.netscape.com/NC-rdf#">
./mozilla/extensions/inspector/resources/content/prefs/pref-sidebar.js:const kNCURI = "http://home.netscape.com/NC-rdf#";
|
Reporter | |
Updated•15 years ago
|
|
Assignee | |
Comment 1•13 years ago
|
||
Deletes file util.dtd and removes code referencing to it.
Assignee: nobody → leofigueres
Attachment #563463 -
Flags: review?(Sevenspade)
|
|
Reporter | |
Updated•13 years ago
|
Attachment #563463 -
Flags: review?(Sevenspade) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
Comment on attachment 563463 [details] [diff] [review]
patch [Checkin: comment 2]
http://hg.mozilla.org/dom-inspector/rev/7fae8fac61df
(Patch had bitrotten due to bug 553364 but I fixed it before pushing.)
Attachment #563463 -
Attachment description: patch → patch [Checkin: comment 2]
|
|
||
Comment 3•13 years ago
|
||
Leaving it up to you whether or when to close the bug.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #2)
> Comment on attachment 563463 [details] [diff] [review] [diff] [details] [review]
> patch [Checkin: comment 2]
>
> http://hg.mozilla.org/dom-inspector/rev/7fae8fac61df
>
> (Patch had bitrotten due to bug 553364 but I fixed it before pushing.)
Thank you for the fix to the patch, Jens.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•