Closed
Bug 548139
Opened 15 years ago
Closed 15 years ago
Enable double-click to edit in DOM node viewer
Categories
(Other Applications :: DOM Inspector, enhancement)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crussell, Assigned: crussell)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
crussell
:
review+
crussell
:
superreview+
|
Details | Diff | Splinter Review |
To work like the CSS Rules viewer.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → Sevenspade
Status: NEW → ASSIGNED
Attachment #428568 -
Flags: superreview?(neil)
Attachment #428568 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #428570 -
Flags: superreview?(neil)
Attachment #428570 -
Flags: review?(sdwilsh)
|
||
Updated•15 years ago
|
Attachment #428568 -
Flags: superreview?(neil) → superreview+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 428570 [details] [diff] [review]
real changes
Nit: the previous "cleanup" for this element makes no sense in the context of this patch, since you're changing it anyway. I would have preferred to see:
> <treechildren id="olAttrBody"
> alternatingbackground="true"
>- />
>+ ondblclick="viewer.pane.panelset.execCommand('cmdEditEdit');"/>
> </tree>
Attachment #428570 -
Flags: superreview?(neil) → superreview+
|
||
Comment 4•15 years ago
|
||
Comment on attachment 428568 [details] [diff] [review]
cleanup
r=sdwilsh
Attachment #428568 -
Flags: review?(sdwilsh) → review+
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 428570 [details] [diff] [review]
real changes
r=sdwilsh
Attachment #428570 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•15 years ago
|
||
(In reply to comment #3)
>(From update of attachment 428570 [details] [diff] [review])
>Nit: the previous "cleanup" for this element makes no sense in the context of
>this patch, since you're changing it anyway. I would have preferred to see:
>> <treechildren id="olAttrBody"
>> alternatingbackground="true"
>>- />
>>+ ondblclick="viewer.pane.panelset.execCommand('cmdEditEdit');"/>
>> </tree>
Although pushing both patches in one commit would have a similar effect.
|
|
Assignee | |
Comment 8•15 years ago
|
||
Attachment #428568 -
Attachment is obsolete: true
Attachment #428570 -
Attachment is obsolete: true
Attachment #431911 -
Flags: superreview+
Attachment #431911 -
Flags: review+
|
||
Comment 9•15 years ago
|
||
Comment on attachment 431911 [details] [diff] [review]
cleanup+realchanges
[Checkin: Comment 9]
http://hg.mozilla.org/dom-inspector/rev/052598952e7e
Attachment #431911 -
Attachment description: cleanup+realchanges → cleanup+realchanges
[Checkin: Comment 9]
|
|
||
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•