add to the compile step's environment PATH value the /tools/jdk6/bin path to allow the SUTAgent build to work until they fix their issue

Comment on attachment 452914 [details] [diff] [review] add jdk6 bin/ to PATH for compile step wish i knew why java_home wasn't working, but i'm not going to block builds on that.

Comment on attachment 452914 [details] [diff] [review] add jdk6 bin/ to PATH for compile step http://hg.mozilla.org/build/buildbotcustom/rev/3d93f905a060

Comment on attachment 452964 [details] [diff] [review] seems you do need a default param for the get() call for path >- envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH') >+ envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', os.environ['PATH']) while we use the same ref image for the slave and master, we should not be pulling the environment of the master to set up the environment of the slave. Instead, could we set the path explicitly in mobile_config.py?

Comment on attachment 452972 [details] [diff] [review] seems you do need a default param for the get() call for path >- envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH') >+ envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin']) Assuming that bin']) should have been bin'). If that is the case, will land with this :)

(In reply to comment #6) > (From update of attachment 452972 [details] [diff] [review]) > >- envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH') > >+ envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin']) > > Assuming that bin']) should have been bin'). If that is the case, will land > with this :) yes, was too busy arguing with you to notice the errant key - thanks

Resolved?

yes