Closed Bug 59638 Opened 24 years ago Closed 22 years ago

[stand alone msg window] reading news/mail across newsgroups/folders does not load next unread message

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.3beta

People

(Reporter: timr, Assigned: sspitzer)

References

Details

(Whiteboard: [adt2])

Attachments

(3 files, 8 obsolete files)

(deleted), patch
Details | Diff | Splinter Review
(deleted), patch
Details | Diff | Splinter Review
(deleted), patch
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20001109 BuildID: 2000110904 When reading newsgroups, I hit 'n' to read the next unread message. When all are read, Mozilla then prompts me to read the next group with unread messages. I say "OK", and Mozilla jumps to the next unread message in the next group. However, the message is not displayed in the "preview pane" in mailnews. If I hit enter, the message is displayed properly in the standalone message window. Reproducible: Always Steps to Reproduce: Read news, using "n" key. go to next unread in next group when prompted. Actual Results: Message not displayed in 3-pane mailnews window. Expected Results: Mozilla should show the message.
*** Bug 59639 has been marked as a duplicate of this bug. ***
*** Bug 59643 has been marked as a duplicate of this bug. ***
reassigning to sspitzer
Assignee: putterman → sspitzer
yes, this is known. see other issues in bug #17801. as soon as I log bugs for all those issues, I'll mark 17801 fixed.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
QA Contact: esther → fenella
*** Bug 62129 has been marked as a duplicate of this bug. ***
This is working for me using apr30 build, win98.
*** Bug 80680 has been marked as a duplicate of this bug. ***
*** Bug 78303 has been marked as a duplicate of this bug. ***
I've got a couple "next unread" problems that I need to sort out, but I haven't had time. moving to mozilla 1.0, but I hope to get to it sooner. hopefully I can find time to fix all these problems in one fell swoop.
Summary: reading news across newsgroups does not next unread message → reading news across newsgroups does not load next unread message
Target Milestone: --- → mozilla1.0
*** Bug 89056 has been marked as a duplicate of this bug. ***
Note to QA: when/if this bug is addressed, we need to verify cross navigation across various types of accounts and folders. There are many bugs marked duplicate of this scenario which are not news specific.
*** Bug 80870 has been marked as a duplicate of this bug. ***
*** Bug 88351 has been marked as a duplicate of this bug. ***
*** Bug 90423 has been marked as a duplicate of this bug. ***
*** Bug 92104 has been marked as a duplicate of this bug. ***
Adding mostfreq at 10 dups.
Keywords: mostfreq
*** Bug 96399 has been marked as a duplicate of this bug. ***
QA Contact: fenella → nbaca
This is not restricted to news; it happens with my mail every time I hit 'n' (next unread message) or click the toolbar 'next' button and the next unread message is in a different folder. If I do a forward/back the message then shows. Another strange bit: The message headers display but the message body does not. Also, if I mark the "blank" message as unread, go to another folder, then hit 'n' again the message body will be shown properly.
*** Bug 100445 has been marked as a duplicate of this bug. ***
updating summary to include mail (80680, 78303, 89056, 80870, 88351, 90423, 92104, 96399, 100445), os->all
OS: Windows 2000 → All
Summary: reading news across newsgroups does not load next unread message → reading news/mail across newsgroups/folders does not load next unread message
This worksforme now. Is anyone still seeing this issue in the latest nightly build?
Not in mail with linux 2001102606 trunk
Not in win32 2001102603
So exactly how do I reproduce this? I clicked on the last unread msg in a group, and then hit 'n', OK to go to the next group, and after a while the next msg loaded.
win98 2001102503, 2001102603: seems to work right in news now, but not in mail - the message body doesn't show up. Yes, your steps look ok
QA Contact: nbaca → olgam
*** Bug 110458 has been marked as a duplicate of this bug. ***
QA Contact: olgam → laurel
Keywords: nsbeta1
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
I've noticed a change in behavior in the last couple builds. When crossing folders with next unread, it now loads a message that is not the next unread. Is that change an attempt to work around the issue here?
*** Bug 106249 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1nsbeta1+
*** Bug 114577 has been marked as a duplicate of this bug. ***
mythdraug@pobox.com, I think your problem is bug 112574.
*** Bug 103246 has been marked as a duplicate of this bug. ***
With the current CVS build, 'n' works like it should for news. But if the next unread is in a mail box, the message is selected but not displayed. Linux
I'm using the 1/3 build and this appears to work for me for both imap mail and news. Local mail seems to just load the header but not the body.
Blocks: 122274
Keywords: nsbeta1+nsbeta1-
Target Milestone: mozilla1.0.1 → mozilla1.2
This was my most hated bug since 2000110904. I think this is fixed in the latest nighlies. Works for me with 2002032803 . Can anyone confirme.
no, doesn't work for me in latest win98 nightly 2002032803 across folders w/ pop3 mail
*** Bug 126164 has been marked as a duplicate of this bug. ***
*** Bug 100184 has been marked as a duplicate of this bug. ***
Looking at the number of dupes and votes, this is not a minor bug. I'd even suggest major since this is extremely confusing for the average user who simple seems not to be able to read mail. pi
Update: just noticed WFM 2002050807 on win2kpro when reading mail, haven't access to NNTP server to test.
Nope, false alarm. Not working on today's win32 build 2002050908. Feh.
If I select the folder (3-pane window) the next 'n' would jump to before pressing the key, the next unread message is loaded normally (mail, no problem with news, 2002051206). Missing procedure call (opening folder-database?) after the "unread message"-dialog? HTH Jens
If you go the first folder with an unread messages, they are displayed correctly. The problem only seems to appear if you go to the following folders. (tested with RC2 under Win)
Severity: minor → normal
A bit more about my experience with this (only reading Mail, Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc2) Gecko/20020514). As described above, when going to the next unread message (hitting 'n') takes you to a new folder, the message doesn't get displayed in the preview pane. A couple of extra quirks: - If you're in the above situation (with message A selected but not displayed in preview) then hit 'n' again to go to message B in another new folder, message B actually does get displayed in the preview pane. - If you hit 'n' from an empty folder (no message displayed in preview), the new message in the next folder _does_ get displayed.
*** Bug 145526 has been marked as a duplicate of this bug. ***
*** Bug 145686 has been marked as a duplicate of this bug. ***
*** Bug 146425 has been marked as a duplicate of this bug. ***
*** Bug 146805 has been marked as a duplicate of this bug. ***
Still present in build 2002052306 (win2k); Some additional observation: if I delete the last message of a folder, it sometimes disappears from the message pane, sometimes it doesn't. This latter case feels weird and not correct: the message list pane is empty, but the message body pane still shows one!?. Anyhow, when I hit n in that case, it never displays the next message as reported in this bug. If the initial message does disappear from the message pane, hitting 'n' usually shows the next message in the next folder without problems. This is a real show stopper when selling mozilla to a new user!
Guido, I agree with you judgement. This bug sucks, big time! Your observation with not cleaning the display on deletion is bug 62938. pi
Same happens when going from one mail account to another is mail is unread in another account
If I have activated the Mail Start Page in Preferences, when hitting next button, the page especified is showed instead of message or blank. I don't know if this helps.
*** Bug 151289 has been marked as a duplicate of this bug. ***
build 20020620 [win2k] still experiencing. funny thing is, that it happens every 2nd time (as described in comment #44) didn't saw things told to see in comment #52 p.s. i think that bug 103246 is dupe of this one (although there are some discussions)
I definitely think that bug 103246 is a duplicate of this one, as is bug 82833. Bug 152135 is also a duplicate of 103246. The most salient point of the other bugs seems to be that this only happens with local folders / offline news reading (see bug 103246 comment #13). I can only confirm that I'm seeing the problem with local mail folders, which is all I use.
*** Bug 153434 has been marked as a duplicate of this bug. ***
*** Bug 103246 has been marked as a duplicate of this bug. ***
*** Bug 154677 has been marked as a duplicate of this bug. ***
Still present on 1.1a+ (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a+) Gecko/20020701) I have several folders and filters (mailing lists junkie.) When I check email, I use the toolbar "Next" button and when it jumps to the next unread message in _another_ folder, the body of the message is not shown. To reproduce is not necessary to get new mails. Just create some folders, and move messages to them. Then, go to any folder, mark one or more messages as unread. Repeat a couple of times. Select the root folder (or account, I don't even know how to name it) and press the Next button. If the message belongs to the folder currently selected, it will display properly. If the next unread message it's on another folder, the program will ask if it's okay to move to "X" folder. The message will be shown properly too; if you press again the "next" button, and the message is in another folder, it will ask again. Press Ok, and the body of the message is not shown. If "next" is pressed again, and if the message is in the same folder, it will be showed properly this time. Should I mention that I REALLY HATE this bug? no? Ok, then. Sorry for the long message, and/or for my english.
The behaviour just noted is precisely the behaviour I've noticed. One thing he forgot to try, was (on a transition that didn't show the message) was to switch to another message, then (as that message begins to render) switch back to the one the renderer missed. It will now display. This really, really needs to be fixed ASAP, since I think that this bug isn't present in NS 4.7x, and I can't recall if NS 6 had it; I despised NS6.x because it was very slow, mainly because it was in Java Debug Mode continuously. (At least, that was true for the NS 6.x builds I ran, oh, so long ago!) This bug is so annoying that /I/ would consider it a major bug.
This bug seems to be fixed with the most recent build (Gecko/20020708). I have been testing it for 2 days with approx 70 mail filters and have not encountered it once.
nah still bugs linux trunk cvs 2002-07-09
Still happens with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a+) Gecko/20020708 Also, "next unread message" now just don't work (the folders have the correct icon, but aren't highlighted and "next unread message" don't "travel" between folders)
WFM with 2002070904 on NT, This was my most hated bug since 2000110904. please confirm. Günter
Re Leonardo Herrera's comment. This bug does look to be fixed (at least on the Windows build). As for the trouble you are referring to. If you take focus away from the message body (click on the headers eg.) the next/previous functionality returns. I would suggest this would be a different bug as when you use the next/previous unread message buttons, the message is displayed without requiring a reload. df
WFM on today's win32 build 2002070908
Wheeee! Looks good now (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a+) Gecko/20020709) Big thanks to the, eh, inflictor of this fix :-)
Ummm. NOTFORME (tm) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a+) Gecko/20020712 Works in 3-pane. Does not work in MailStandalone even tho' the "offer" is made.
*** Bug 155505 has been marked as a duplicate of this bug. ***
WFM: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b) Gecko/2002072818 pi
wfm too Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020801 Günter
*** Bug 124352 has been marked as a duplicate of this bug. ***
Setting Platform=All per comment 72.
Hardware: PC → All
This works for me in the 3 pane, but not in the standalone mail window. Reassigning to ssu.
Assignee: sspitzer → ssu
Status: ASSIGNED → NEW
Keywords: nsbeta1-nsbeta1+
Whiteboard: [adt2]
Status: NEW → ASSIGNED
Attached patch patch v1.0 (obsolete) (deleted) — Splinter Review
this is a preliminary patch that does fix this bug. However, I'm still making sure that the patch is the correct way to fix this bug.
Mac OS 9.1 Build 2002100911 I have noticed that when the inbox of my pop account is selected, n shortcut or Next button never works. Trash is set to an unselected state, that's all, no message
Comment on attachment 102522 [details] [diff] [review] patch v1.0 > if (supportsFolderPane) > SelectFolder(folder.URI); >+ else >+ UpdateDBView(folder.URI); Is there a good reason why the functionality of the UpdateDBView function can't be merged into the SelectFolder function (removing UpdateDBView)? This would allow you to remove the supportsFolderPane hack.
Attachment #102522 - Flags: review?(racham)
Attachment #102522 - Flags: review?(racham) → review?(sspitzer)
heavily duped bug, let's see if we can get this into 1.3 alpha.
Target Milestone: mozilla1.2alpha → mozilla1.3alpha
I'm seeing some xpconnect errors, not sure if they are new, or existing. looking into them... ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsI Supports.QueryInterface]" nsresult: "0x80004002 (NS_NOINTERFACE)" location: "J S frame :: chrome://messenger/content/mailWindowOverlay.js :: OnMsgLoaded :: lin e 1898" data: no] ************************************************************ ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIMsgDBView.URIForFirstSelectedMessage]" nsresult: "0x8000ffff (NS_ERROR_UNE XPECTED)" location: "JS frame :: chrome://messenger/content/msgMail3PaneWindow. js :: anonymous :: line 259" data: no] ************************************************************
I have a theory. I think all msg windows are getting these events, the 3 pane and the stand alone msg window, but only the appropriate window should react.
looks like we knew about this. from mailWindow.js, OnMsgLoaded() // XXX TODO // bienvenu tells me: // if you have two message windows open, you can get multiple attempts // to copy into the pfc. the second will fail and assert. dump("not loading msg into this window - loaded message = " + messageURI + "loading " + msgURI + "\n"); // return; I'm going to fix this by passing around the msg window.
ok, patch coming that uses the msg window to drop msgLoaded events. this prevents both XPConnect errors I was seeing.
Attachment #108434 - Attachment is obsolete: true
taking from ssu, since I've got this in my tree
Assignee: ssu → sspitzer
Status: ASSIGNED → NEW
accepting
Status: NEW → ASSIGNED
Attachment #108457 - Flags: superreview?(bienvenu)
Attachment #102522 - Flags: review?(sspitzer)
Comment on attachment 108457 [details] [diff] [review] ssu's patch + neils suggestion + XPConnect error fixes >@@ -393,18 +393,12 @@ > > function IsNewsMessage(messageUri) > { >- if (!messageUri) >- return false; >- else >- return (messageUri.substring(0,14) == "news-message:/"); >+ return (messageUri && messageUri.substring(0,14) == "news-message:/"); > } > > function IsImapMessage(messageUri) > { >- if (!messageUri) >- return false; >- else >- return (messageUri.substring(0,14) == "imap-message:/"); >+ return (messageUri && messageUri.substring(0,14) == "imap-message:/"); > } > > function SetMenuItemLabel(menuItemId, customLabel) >@@ -1893,6 +1887,7 @@ Nit: if you want to improve these, use function IsNewsMessage(messageUri) { return(/^news-message:/.test(messageUri)); } function IsImapMessage(messageUri) { return(/^imap-message:/.test(messageUri)); } (well you could test for the / as well but that's less readable...)
Why not call OnMsgLoaded() directly from messageHeaderSink.onEndMsgDownload()?
Comment on attachment 108457 [details] [diff] [review] ssu's patch + neils suggestion + XPConnect error fixes sr=bienvenu - I wouldn't push this for 1.3a just because the risk seems greater than the reward
Attachment #108457 - Flags: superreview?(bienvenu) → superreview+
the reason I was hoping for 1.3 alpha was it was one mailnews's most dup'd bugs. (see jar:http://bugzilla.mozilla.org/duplicates.jar!/duplicates.xul) but if bienvenu thinks it should wait until after 1.3 alpha, I'll wait.
> Why not call OnMsgLoaded() directly from messageHeaderSink.onEndMsgDownload()? good point! that makes for a much cleaner fix. I'll work on it. > return(/^news-message:/.test(messageUri)); can you explain why that's better? does substring allocate, and test doesn't?
Comment on attachment 108504 [details] [diff] [review] updated patch, with neil's suggestion to remove the msgLoaded atom. (much simpler!) sr=bienvenu, yes, that is a lot simpler.
Attachment #108504 - Flags: superreview+
sorry david, one more patch coming, switching from substring() to test()...
Attached patch latest patch, testing now... (obsolete) (deleted) — Splinter Review
Attachment #108504 - Attachment is obsolete: true
Comment on attachment 108507 [details] [diff] [review] latest patch, testing now... tested it, looks good. r=sspitzer on ssu's stuff. can I get a review from ssu for the stuff he didn't write, and a sr for the whole enchilada? I'd like to get this into 1.3 alpha, to kill a top dup'd bug.
Attachment #108507 - Flags: superreview?(bienvenu)
Attachment #108507 - Flags: review?(ssu)
Comment on attachment 108507 [details] [diff] [review] latest patch, testing now... sr=bienvenu, I withdraw my comment about not being worth the risk for 1.3a - it's less risky now, and it is a mostfreq duped bug.
Attachment #108507 - Flags: superreview?(bienvenu) → superreview+
Seth, I was told that test was more efficient, so I passed on the information (assuming that I have remembered it correctly :-)
Attachment #108507 - Flags: review?(ssu) → review+
Comment on attachment 108507 [details] [diff] [review] latest patch, testing now... seeking approval
Attachment #108507 - Flags: approval1.3a?
fixed. thanks again to ssu for the initial patch.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment on attachment 108507 [details] [diff] [review] latest patch, testing now... not a 1.3a blocker, removing approval request.
Attachment #108507 - Flags: approval1.3a?
keep in mind, this is still broken for the stand alone msg window. see bug #127311
I think I'm still seeing the problem with the stand alone msg window, but I swore it was working. re-opening, until I'm less confused.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I tried to fix this back in 127311, and bienvenu pointed out that we need to wait for the folder to load, before we can find the unread message. this is how SelectFolder() works in the 3 pane js. not 100% sure why it appear to work in my tests yesterday, but I can get it to fail this morning. I've marked 127311 a dup of this bug, and I'll investigate. I'm have to undo some of the changes that I checked in, but not the msgLoaded atom change or the test() change, or some of the other code cleanup. sorry for all the thrashing.
Status: REOPENED → ASSIGNED
Summary: reading news/mail across newsgroups/folders does not load next unread message → [stand alone msg window] reading news/mail across newsgroups/folders does not load next unread message
*** Bug 127311 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.3alpha → mozilla1.3beta
Attached patch patch, in progress (obsolete) (deleted) — Splinter Review
here's what I'm working on. basically, similar to how the folder pane works. wait for the folder to load before taking action.
Attachment #108507 - Attachment is obsolete: true
Attached patch still in progress... (obsolete) (deleted) — Splinter Review
Attachment #109061 - Attachment is obsolete: true
Attached patch a working patch (obsolete) (deleted) — Splinter Review
Attachment #109064 - Attachment is obsolete: true
before I seek reviews, I need to test: 1) dnd into stand alone msg window 2) verify cross folder navigation work (I've been confused before) 3) test multiple 3 pane, multiple stand alone windows do the right thing
Attachment #109066 - Attachment is obsolete: true
fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Comment on attachment 109079 [details] [diff] [review] updated patch, with some additional code cleanup >+ else if (eventType == "FolderLoaded") { >+ if (folder) { >+ var resource = folder.QueryInterface(Components.interfaces.nsIRDFResource); >+ if (resource) { >+ var uri = resource.Value; >+ if (uri == gCurrentFolderToRerootForStandAlone) { >+ gCurrentFolderToRerootForStandAlone = null; >+ var msgFolder = folder.QueryInterface(Components.interfaces.nsIMsgFolder); >+ if (msgFolder) { >+ msgFolder.endFolderLoading(); >+ if (gRerootOnFolderLoadForStandAlone) { >+ RerootFolderForStandAlone(uri); >+ } >+ } >+ } >+ } >+ } Just out of interest, could you have used folder.URI instead of resource.Value thus saving you the QI to nsIRDFResource?
Cross folder navigation isn't updating the mail toolbar properly; when you navigate from a mail to a news server the delete button doesn't change to mark, until you start reading the second newsgroup.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Also, if there are new mail messages, it should go to the mail messages before going to newsgroups.
working on some of the issues mentioned. some might be spin off bugs.
Status: REOPENED → ASSIGNED
Amen! This is one of the most irritating things right now with Mozilla Messenger... the fact that (esp. with multiple POP3 email accounts with new messages) Mozilla blithely attempts to go straight to the unread newsgroups at the end of the first (default?) account's unread messages. I suppose I really do need to upgrade to 1.2.1, though. Beware; eWeek did another article on Mozilla; praised 1.2.1 quite highly...we might have more people entering the testing...
Hey, this wasn't working for me, but now is (standalone window). Good job everyone!
> Cross folder navigation isn't updating the mail toolbar properly; when you > navigate from a mail to a news server the delete button doesn't change to mark, > until you start reading the second newsgroup. fix in hand, patch coming.
fixes the toolbar problem, and I've remove the QI (also suggested by neil)
marking fixed. let's take comment #113 (From Mike Fedyk, "Also, if there are new mail messages, it should go to the mail messages before going to newsgroups.") to a spin off bug.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Using trunk build 20030303 on linux I have tested this by navigating to the next unread via Next Button and N key in the following scenarios: I have tested this by navigating while in the thread pane I have tested this by navigating while in the stand alone mail window I have crossed IMAP folders I have crossed over to POP accounts from IMAP I have crossed over POP folders I have crossed over to newsgroups from POP accounts I have crossed over newsgroups The toolbar and menu items changed when crossing into News from Mail. The only outstanding issue is comment 113, we don't go back to folders with unread within a IMAP or POP account. We do go back to messages within the same folder that are unread. I'll look for the new bug that should have been logged. Still need to verify Win and Mac
> The only outstanding issue is comment 113, we don't go back to folders with > unread within a IMAP or POP account. I think this might confuse quick search/message views, you would never be able to leave a folder which wasn't displaying its unread messages.
Using trunk build 20030303 on WinXP I have tested this by navigating to the next unread via Next Button and N key in the following scenarios: I have tested this by navigating while in the thread pane I have tested this by navigating while in the stand alone mail window I have crossed IMAP folders I have crossed over to POP accounts from IMAP I have crossed over POP folders I have crossed over to newsgroups from POP accounts I have crossed over newsgroups The toolbar and menu items changed when crossing into News from Mail. Windows is verified too. I agreee with Neil regarding comment 113. Still testing MacOSX
Using trunk build 20030303 on MAC OSX I have tested this by navigating to the next unread via Next Button and N key in the following scenarios: I have tested this by navigating while in the thread pane I have tested this by navigating while in the stand alone mail window I have crossed IMAP folders I have crossed over to POP accounts from IMAP I have crossed over POP folders I have crossed over to newsgroups from POP accounts I have crossed over newsgroups The toolbar and menu items changed when crossing into News from Mail. Mac is verified too.
Status: RESOLVED → VERIFIED
*** Bug 143716 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: