Closed Bug 599762 Opened 14 years ago Closed 14 years ago

TM: set right compartment in js::ctypes::CClosure::ClosureStub

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: gwagner, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

2 libmozjs.so!JS_CallFunctionValue [jsapi.cpp:ef1f16975962 : 4898 + 0x31] eip = 0x006acea4 esp = 0xa44ed310 ebp = 0xa44ed358 ebx = 0x00a1968c Found by: call frame info 3 libmozjs.so!js::ctypes::CClosure::ClosureStub [CTypes.cpp:ef1f16975962 : 5373 + 0x52] eip = 0x0095b28a esp = 0xa44ed360 ebp = 0xa44ed4f8 ebx = 0x00a1968c esi = 0xa44ed3b4 edi = 0x00000001 Found by: call frame info 4 libmozjs.so!ffi_closure_SYSV_inner [ffi.c:ef1f16975962 : 384 + 0x27] eip = 0x009706a6 esp = 0xa44ed500 ebp = 0xa44ed558 ebx = 0x00a1968c esi = 0x0095ae5d edi = 0xa1883240 Found by: call frame info 5 libmozjs.so + 0x2ec89d eip = 0x0097089e esp = 0xa44ed560 ebp = 0xa44ed588 ebx = 0x00a1968c esi = 0x00000001 edi = 0xa1883240 Found by: call frame info 6 libmozjs.so + 0x2ec7e1 eip = 0x009707e2 esp = 0xa44ed590 ebp = 0xa44ed598 ebx = 0x00a1968c esi = 0x00000001 edi = 0xa1883240 Found by: call frame info http://tinderbox.mozilla.org/showlog.cgi?tree=MozillaTry&errorparser=unittest&logfile=1285526805.1285528507.21126.gz&buildtime=1285526805&buildname=Rev3%20Fedora%2012%20tryserver%20debug%20test%20mochitest-other&fulltext=1#err1
Blocks: 594455
Attached patch patch (obsolete) (deleted) — Splinter Review
Gregor, want to tryserver this?
Assignee: general → gal
This is a callback stub and it has to enter the right compartment before calling back into JS.
try jsfnObj instead of thisObj
Attached patch patch (deleted) — Splinter Review
changed thisObj.
Attachment #478705 - Attachment is obsolete: true
Attachment #479514 - Flags: review?
Comment on attachment 479514 [details] [diff] [review] patch Argh wrong flag. Still Andreas patch.
Attachment #479514 - Flags: review? → review+
This patch does fix the problem I ran into in the ctypes test in our chrome mochitests. This should be ready to land IMO, and I can do so unless someone tells me not to...
I am about to land this.
Whiteboard: fixed-in-tracemonkey
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: