Closed
Bug 725575
Opened 13 years ago
Closed 13 years ago
add outputDOMAttrs function to accessibleEvents viewer
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
crussell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #595660 -
Flags: review?(Sevenspade)
|
Assignee | |
Updated•13 years ago
|
Summary: add outputDOMAttrs to accessibleEvents viewer → add outputDOMAttrs function to accessibleEvents viewer
|
||
Comment 1•13 years ago
|
||
Comment on attachment 595660 [details] [diff] [review]
patch
Review of attachment 595660 [details] [diff] [review]:
-----------------------------------------------------------------
::: resources/content/viewers/accessibleEvents/accessibleEvents.js
@@ +1086,5 @@
> + var DOMNode = QIAccessNode(aAccessible).DOMNode;
> + var DOMAttributes = DOMNode.attributes;
> + for (let i = 0; i < DOMAttributes.length; i++) {
> + var DOMAttribute = DOMAttributes.item(i);
> + output(DOMAttribute.nodeName + ": " + DOMAttribute.nodeValue);
Attribute nodes are going away (bug 611787). Instead of |nodeName| and |nodeValue|, just use |name| and |value|, respectively.
r+ with that change.
Attachment #595660 -
Flags: review?(Sevenspade) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
http://hg.mozilla.org/dom-inspector/rev/67f897bde847 with Colby's comment fixed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Blocks: DOMi2.0.11
You need to log in
before you can comment on or make changes to this bug.
Description
•