Justin Wood (:Callek) Assignee
	Description • 13 years ago

sut_lib should support logging rather than print in more instances. As well as actually log to the clientproxy log when we are called from there.

To do this s/print/log.*/ and add a sut_lib init for multiprocessing logging.

	Mike Taylor [:bear]
	Comment 1 • 13 years ago

Comment on attachment 615827 [details] [diff] [review]
[tools] v1

I don't think you need to use a common routine to get the log instance - that is what get_logger() returns.

You should be able to replace your multiprocessingLoggingInit() routine with:

from multiprocessing import get_logger

log = get_logger()

and ensure that log has module scope

	Justin Wood (:Callek) Assignee
	Comment 2 • 13 years ago

After IRC discussion this feels less dirty.

	Mike Taylor [:bear]
	Comment 3 • 13 years ago

Comment on attachment 615866 [details] [diff] [review]
[tools] v2

nit: remove the |if debug:| check, log.debug() does that

but doing this will mean setting the log debug level based on the option

	Justin Wood (:Callek) Assignee
	Comment 4 • 13 years ago

(In reply to Mike Taylor [:bear] from comment #3)
> Comment on attachment 615866 [details] [diff] [review]
> [tools] v2
> 
> nit: remove the |if debug:| check, log.debug() does that

Per IRC ok from bear, I'm planning to ignore this nit since changing the calling location is a bit scope creeping of making this library log properly.

	Justin Wood (:Callek) Assignee
	Comment 5 • 13 years ago

http://hg.mozilla.org/build/tools/rev/a874d4fb96f9

	Justin Wood (:Callek) Assignee
	Comment 6 • 13 years ago

This deployed