Closed Bug 749863 Opened 13 years ago Closed 12 years ago

Make sut_tools actually output to stdout now that it is using log module

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch [tools] v1 (obsolete) (deleted) — Splinter Review
Many buildbot scripts use sut_tools as well, and apparantly |log = logging.getLogger()| is not enough to give a StreamHandler as the output.

This will do it just fine for all of sut_tools. Alternative is to set |log = logging| and use logging.basicConfig() to set the level here. But I like this better (less magic involved)
Attachment #619234 - Flags: review?
Comment 0 is private: false
Attachment #619234 - Attachment is private: false
Attachment #619234 - Flags: review? → review?(bear)
Blocks: 750982
Attached patch [tools] v2 (deleted) — Splinter Review
This implements the more restrictive ps echoing than we had before. Rest of patch is the same
Attachment #619234 - Attachment is obsolete: true
Attachment #619234 - Flags: review?(bear)
Attachment #620433 - Flags: review?(bear)
Comment on attachment 620433 [details] [diff] [review]
[tools] v2

>@@ -508,7 +519,14 @@ def stopStalled(tegra):
>+    log.debug("checkStalled: matching Processes follow...")

Corrected to read "stopStalled" here
Attachment #620433 - Flags: review?(bear) → review+
Comment on attachment 620433 [details] [diff] [review]
[tools] v2

http://hg.mozilla.org/build/tools/rev/addb0b598d3f
Attachment #620433 - Flags: checked-in+
Comment on attachment 620433 [details] [diff] [review]
[tools] v2

Had to back this out, it was causing clientproxy to fail to startup (somehow staging didn't catch that initially).

And needed a context fix for a backout conflict:
http://hg.mozilla.org/build/tools/rev/272efac7ec20 (backout)
http://hg.mozilla.org/build/tools/rev/eca68fbcc7c0 (merge)
http://hg.mozilla.org/build/tools/rev/c0122cac3804 (context-fix)
Attachment #620433 - Flags: checked-in+ → checked-in-
Depends on: 794017
(Much of the attached patch is now covered by bug 781341 and bug 794017).
(In reply to Ed Morley [:edmorley UTC+0] from comment #5)
> (Much of the attached patch is now covered by bug 781341 and bug 794017).

Indeed, and fixed. [though we will have more logging cleanup to do]
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: