When there is no window open, the Mac menubars are showing that lots of commands that should be disabled (like Cut, Copy, Paste, Find etc etc) are actually enabled. In some cases (e.g. Find), choosing the command will cause Mozilla to lock up or crash. This is bad.

paul, don't you already have this bug?

Blake says that hiddenWindow.xul needs: <commandset id="navCommands"/> which helps somewhat. But tons of commands are badly enabled, still.

*** Bug 75252 has been marked as a duplicate of this bug. ***

would this be a dup of or dependent on bug 74499?

This would seem to be the antithesis of bug 74499.

Simon, can you go ahead and checkin the commandset line with sr? (r=blake)

Simon, can you check it in?

It's difficult to work on this without a mac. Simon, can you check in that patch? (it needs to change from navCommands to commandset now, or whatever Ben changed it to )

I need r= and sr= on the patch. Takers?

i checked in the <commandset id="commands"/> needed to make menus work at all with the hidden window late last week. is there more needed?

You're going to have to tell me :-) I think Simon said more was needed, earlier...if so, please describe exactly what the problem is. Is it still that too many items are enabled?

sairuh, can you check to see if this is working or help to describe the current state? time is running out on 0.9.1 if anything else needs to be done on this bug?

What needs doing here is to drag the browser window commands kicking and screaming into the command-updating world that the other components use. That's quite a bit of work.

moving off the 0.9.1 list. After talking to sfraser it sounds like we need a few things here. Simon thinks we are pretty protected against crashes and problems with the activated menus, its just mostly bad looking at this point but we could use some QA folks to poke at the menus just to make sure. lisa/asa, can you help with that? It would be best if the owner of the bug had a mac so they could view the current state and be able to test the fixes that are made to disable to some of the XUL and JS that needs to happen to fix the bug. Vishy, have a person like that? if not we can get blake a mac when he shows up in Mt. View in a few weeks.

sairuh, scalkins, and nbaca - for the menu testing for your areas, please make sure you can try the various commands when the application window is closed, but the menubar is still there. Thanks.

hrm, I have an inverse problem with im, can't access menu items when standalone is up..also, they don't morph see: http://Bugscape.netscape.com/show_bug.cgi?id=5138

We should be disabling some menu items by virtue of the hidden window loading about:blank: see bug 63047

tested using 2001.05.29.08 mozilla bits on Mac OS 9.x. when there are no windows, the following menubar items appear as [incorrectly] enabled --unless otherwise noted, selecting these items didn't do anything. File > Save As Send Page Send Link View > Toolbars Use Stylesheet Reload Stop Page Source Page Info: window opens --see bug 83253 Translate Search > Find Find Again My Sidebar Search Tab Bookmarks > File Bookmark: opens browser window --see bug 83254 Tasks > P&S > Cookie Manager > Unblock cookies from this site, and Block cookies from this site Tasks > P&S > Image Manager > Unblock images from this site, and Block images from this site i have also gone through and tested menu items which *should* be enabled when there are no windows --i need to file some bugs there, and will summarize findings here (later on, when i'm more awake :). however, i was wondering if the following people could check these menus in more detail, since i think they're more familiar with 'em? thanks so much! teruko, could you check if/how the following View submenus should work when there are no windows? View > Languages and Web Content submenu items View > Character Coding submenus, and their subsidiary items... claudius, could you check if all of the bookmark items [starting with the Personal Toolbar folder and downwards] in the Bookmarks menu open a window to the appropriate URLs? i tested only a few, but they seemed fine. not sure if there are others that might not work, tho'... terri, could you check if all the items in the Help menu [other than About Balloon Help and Show/Hide Balloons, which work fine] work fine by opening the appropriate pages?

here are menubar items that are/should be enabled when there are no windows [again using 2001.05.29.08 moz bits]. except where noted, i didn't have problems launching these. File > New [anything: navigator, mail, addr book, editor work fine] Open Web Location Open File: no file picker launched --see bug 83313 ?? Work Offline ?? Quit Edit > Preferences View > Apply Themes... Search > Search the Web does nothing --see bug 83329 Go > Home is disabled; should open browser to home page --see bug 83343 Bookmarks > Manage Bookmarks also opens blank browser window --see bug 83337 Tasks > P&S > Form Manager menu items should be enabled --see bug 83346 [??] Work Offline: laurel or gchan, how/if should this work when there are no windows? i don't do Offline stuff, so i don't know whether this should even be enabled...

imo, I think work offline should also be disabled if there are no windows since you can't do much offline stuff if there are no windows present.

But you can go offline, and then be offline while you open a new browser or mail window, right? Offline status is not dependent on any kind of window content.

Yeah Simon you make a good point. Offline applies to the whole application and not necessarily a specific window like the 'save as' option does. Ok. So Offline from File menu should be enabled and working even if there are no windows present.

sarah wrote: "View > Apply Themes..." as one of the things that should be enabled. Why? I don't actually care either way, my only concern is that I don't see that menuitem as any different than View> My sidebar or View> Toolbar >[...]. So I tend to think whether they're on or off the same logic would apply to these items and 'Apply Themes' as a group. I'll go look into those bookmark menuitems now...

The current theme is a global state for the app (like offline). You should be able to switch themes when no windows are open.

re: bookmarks menuitems - I've satisfied myself that the 80 or so menuitems below 'Manage Bookmarks' work correctly when there are no open windows, ie they open a new browser window and go to the selected site with 2001052908 builds on MacOS 8.5.1 re: my earlier comments - simon's correct and I see the logic that separates themes from the others now.

I'm largely helpless with this until I get a mac (Monday), and even then I'll probably need help from a mac person. Is this bug still dealing with a regression that we think one of my landings caused?

reassigning to default owner.

->ben

Would like to get to this sooner than future, but not likely before 1.2

nsbeta1- per Nav triage team

another menu item which should be disabled when there are no windows open: New > Navigator Tab

*** Bug 150985 has been marked as a duplicate of this bug. ***

nominating for buffy...

Nav triage team: are there still items that cause a crash or hang?

Nav triage team: nsbeta1-

By the definitions on <http://bugzilla.mozilla.org/bug_status.html#severity> and <http://bugzilla.mozilla.org/enter_bug.cgi?format=guided>, crashing and dataloss bugs are of critical or possibly higher severity. Only changing open bugs to minimize unnecessary spam. Keywords to trigger this would be crash, topcrash, topcrash+, zt4newcrash, dataloss.

Bug 25287 fixed (disabled) all inappropriate menuitems.