Closed Bug 795019 Opened 12 years ago Closed 12 years ago

check clobberer.py and count_and_reboot.py into mozharness

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: catlee)

References

Details

(Whiteboard: [mozharness])

Attachments

(3 files)

We've got hgtool.py; these two should round out what we need from build/tools on a consistent basis.
Attached patch mozharness/external_tools/ (deleted) — Splinter Review
Should allow us to stop cloning build/tools for these. ScriptFactory can point at count_and_reboot.py, but we'll need something in mozharness (BuildbotMixin?) to call clobberer.py.
Attachment #665540 - Flags: review?(catlee)
These are the same as the build/tools versions, except chmod'ed a+x, and I changed one from #!/usr/bin/python to #!/usr/bin/env python.
Comment on attachment 665540 [details] [diff] [review] mozharness/external_tools/ Review of attachment 665540 [details] [diff] [review]: ----------------------------------------------------------------- should purge_builds.py be added too?
Attachment #665540 - Flags: review?(catlee) → review+
Comment on attachment 665540 [details] [diff] [review] mozharness/external_tools/ Checked in, with purge_builds.py. Still need mozharness patches to use clobberer.py and purge_builds.py, and buildbot-configs patches to change the location of count_and_reboot.py for mozharness scripts. We can probably also remove build/tools from the repo list for a number of jobs now.
Attachment #665540 - Flags: checked-in+
Attachment #666047 - Flags: review?
Comment on attachment 666047 [details] [diff] [review] call count_and_reboot.py from external_tools/ IRC review from Catlee. http://hg.mozilla.org/build/buildbot-configs/rev/9c0386f3e28d
Attachment #666047 - Flags: review?
Attachment #666047 - Flags: review+
Attachment #666047 - Flags: checked-in+
Since we have a copy of count_and_reboot.py in mozharness/external_tools/ now, we can remove the requirement of cloning hg.m.o/build/tools for that file. Updated marionette, peptest, talos, unittests to no longer need to pull that repo. Since that was the only repo we were pulling, I removed that action and the repos config entries. Jetperf still needs to clone addon sdk repositories, so I left it alone. A few new talos docstrings crept their way into my testing repo -- I can remove them from the review or leave them.
Attachment #666063 - Flags: review?(jgriffin)
We're now using the in-mozharness version of count_and_reboot.py in production.
Comment on attachment 666063 [details] [diff] [review] stop pulling hg.m.o/build/tools for count_and_reboot.py Review of attachment 666063 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks!
Attachment #666063 - Flags: review?(jgriffin) → review+
Comment on attachment 666063 [details] [diff] [review] stop pulling hg.m.o/build/tools for count_and_reboot.py http://hg.mozilla.org/build/mozharness/rev/8e36db25e15f
Attachment #666063 - Flags: checked-in+
My current plan of attack for purge_builds.py and clobberer.py: * create a clobber() method in BuildbotMixin. I think this can override the BaseScript.clobber(), but I'd have to check * BuildbotMixin.clobber() would check a config flag on whether to clobber full, partial, check with clobberer_url, or not at all. If full (or clobberer_url says yes), BaseScript.clobber(). If partial, nuke a list of files/directories specified in the config. If not at all, skip this portion. We may have to default to partial or not at all for depend builds/tests. * Then it would check for an option to purge builds. This should be off by default for standalone/devs, and on by default for production. I'm not entirely sure if I will be able to do this before PTO, but it's on my list of things to try to get done.
Depends on: 795525
[16:36] <catlee-away> aki: when are you PTO? I could tackle purge/clobber for mozharness [16:36] <catlee-away> since we clearly need that for b2g builds Right now it looks like I might not get to this, and this was causing b2g jobs to fill up our aws boxen. Reassigning; thanks Catlee!
Assignee: aki → catlee
Blocks: 795776
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: