/usr/bin/gcc-4.2 -o host_mar_create.o -c -DXP_UNIX -DXP_MACOSX -DNO_X11 -O3 -I/builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src -I. -I../../../dist/include -I/builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/obj-l10n/dist/include/nspr -I/builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/obj-l10n/dist/include/nss -I/builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/obj-l10n/dist/include/nspr /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_create.c In file included from /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_create.c:12: /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_private.h:12:37: error: mozilla/StandardInteger.h: No such file or directory In file included from /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_create.c:12: /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_private.h:16: error: 'uint32_t' undeclared here (not in a function) /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_private.h:17: error: 'uint64_t' undeclared here (not in a function) /builds/slave/rel-m-beta-osx64-rpk-6/mozilla-beta/modules/libmar/src/mar_private.h:43: error: 'uint32_t' undeclared here (not in a function) make[2]: *** [host_mar_create.o] Error 1 make[1]: *** [libs] Error 2 make: *** [default] Error 2 The changes from bug 785066 were never ported from the nightly situation to the release automation.

Windows fail looks like e:\builds\moz2_slave\rel-m-beta-w32-rpk-5\mozilla-beta\modules\libmar\src\mar_private.h(12) : fatal error C1083: Cannot open include file: 'mozilla/StandardInteger.h': No such file or directory

This is my attempt to port the changes from bug 785066 over. To get StandardInteger.h we have to build in mfbt/, which is part of tier_base.

Comment on attachment 669835 [details] [diff] [review] [tools] build tier_base too I ran this patch on a mac slave (with appropriate env vars set) and it successfully compiled libmar and created mar files for the son locale. I blocked it uploading anything to leave a clean slate on ftp.

Comment on attachment 669835 [details] [diff] [review] [tools] build tier_base too Landed in https://hg.mozilla.org/build/tools/rev/798cbd07c55b

Reconfig'd on buildbot-master13

mozilla-beta repacks are passing with this patch.

This broke Thunderbird repacks, which have a non-empty mozilla_dir and start trying to do: command: START command: make command: cwd: comm-release/obj-l10n/mozilla/tier_base command: env: {'MOZ_MAKE_COMPLETE_MAR': '1', 'UPLOAD_USER': 'tbirdbld', ... command: output: command: END (0.01s elapsed) which ends up at OSError: [Errno 2] No such file or directory: 'comm-release/obj-l10n/mozilla/tier_base'

Comment on attachment 670202 [details] [diff] [review] [tools] make it work for Thunderbird too Review of attachment 670202 [details] [diff] [review]: ----------------------------------------------------------------- This is a horrible, horrible hack. r+ because it appears it will work, but can you file a bug or otherwise track finding a better solution for this?

Comment on attachment 670202 [details] [diff] [review] [tools] make it work for Thunderbird too http://hg.mozilla.org/build/tools/rev/652471b93bda and retagged THUNDERBIRD_16_0_1_{RELEASE,BUILD1}.

I'm verifying this before requesting for a review.